Skip to content

Commit 896df75

Browse files
committed
Corrects conditional compilation problem on ESP8266 and ESP32
Version 0.6.0 introduced a mechanism to supply the ICACHE_RAM_ATTR prefix to the onDio0Rise() interrupt service routine when compiling for ESP32 or ESP8266 boards. As written, "#ifdef ESP8266 || ESP32" produces "warning: extra tokens at end of #ifdef directive" when compiling in the Arduino IDE 1.8.9. If the board is an ESP8266 then ISR_PREFIX has the value ICACHE_RAM_ATTR (correct) but if the board is an ESP32, ISR_PREFIX is null (incorrect) This PR proposes alternative syntax "#if (ESP8266 || ESP32)" which compiles without warning and provides ICACHE_RAM_ATTR to both ESP8266 and ESP32 boards.
1 parent 22000b2 commit 896df75

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/LoRa.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757

5858
#define MAX_PKT_LENGTH 255
5959

60-
#ifdef ESP8266 || ESP32
60+
#if (ESP8266 || ESP32)
6161
#define ISR_PREFIX ICACHE_RAM_ATTR
6262
#else
6363
#define ISR_PREFIX

0 commit comments

Comments
 (0)