Normalize commit template paths on Windows

Author: smashwilson

lib/git-shell-out-strategy.js

@@ -454,6 +454,7 @@ export default class GitShellOutStrategy {
       // if no user is specified, fall back to using the home directory.
       return `${user ? path.join(path.dirname(homeDir), user) : homeDir}/`;
     });
+    templatePath = toNativePathSep(templatePath);
 
     if (!path.isAbsolute(templatePath)) {
       templatePath = path.join(this.workingDir, templatePath);

test/git-strategies.test.js

@@ -165,7 +165,8 @@ import * as reporterProxy from '../lib/reporter-proxy';
       });
 
       it('replaces ~ with your home directory', async function() {
-        await git.setConfig('commit.template', `~${path.sep}does-not-exist.txt`);
+        // Fun fact: even on Windows, git does not accept "~\does-not-exist.txt"
+        await git.setConfig('commit.template', '~/does-not-exist.txt');
         await assert.isRejected(
           git.fetchCommitMessageTemplate(),
           `Invalid commit template path set in Git config: ${path.join(os.homedir(), 'does-not-exist.txt')}`,
@@ -174,7 +175,7 @@ import * as reporterProxy from '../lib/reporter-proxy';
 
       it("replaces ~user with user's home directory", async function() {
         const expectedFullPath = path.join(path.dirname(os.homedir()), 'nope/does-not-exist.txt');
-        await git.setConfig('commit.template', `~nope${path.sep}does-not-exist.txt`);
+        await git.setConfig('commit.template', '~nope/does-not-exist.txt');
         await assert.isRejected(
           git.fetchCommitMessageTemplate(),
           `Invalid commit template path set in Git config: ${expectedFullPath}`,