Delete non-exec-based agent factories

Author: jglick

pom.xml

@@ -29,7 +29,7 @@
   <parent>
     <groupId>org.jenkins-ci.plugins</groupId>
     <artifactId>plugin</artifactId>
-    <version>4.12</version>
+    <version>4.16</version>
     <relativePath />
   </parent>
 
@@ -78,21 +78,6 @@
 
   <dependencies>
     <!-- regular dependencies -->
-    <dependency>
-      <groupId>org.apache.sshd</groupId>
-      <artifactId>sshd-core</artifactId>
-      <version>1.7.0</version>
-    </dependency>
-    <dependency>
-      <groupId>tomcat</groupId>
-      <artifactId>tomcat-apr</artifactId>
-      <version>5.5.23</version>
-    </dependency>
-    <dependency>
-      <groupId>com.cloudbees.util</groupId>
-      <artifactId>jnr-unixsocket-nodep</artifactId>
-      <version>0.3.1</version>
-    </dependency>
     <dependency>
       <groupId>org.jenkins-ci.plugins.workflow</groupId>
       <artifactId>workflow-step-api</artifactId>
@@ -107,11 +92,6 @@
       <groupId>org.jenkins-ci.plugins</groupId>
       <artifactId>ssh-credentials</artifactId>
     </dependency>
-    <dependency>
-      <groupId>org.jenkins-ci.plugins</groupId>
-      <artifactId>bouncycastle-api</artifactId>
-      <version>2.16.3</version>
-    </dependency>
     <!-- jenkins dependencies -->
     <!-- test dependencies -->
     <dependency>
@@ -142,7 +122,7 @@
       <dependency>
         <groupId>io.jenkins.tools.bom</groupId>
         <artifactId>bom-2.222.x</artifactId>
-        <version>20</version>
+        <version>26</version>
         <scope>import</scope>
         <type>pom</type>
       </dependency>
@@ -152,13 +132,10 @@
   <build>
     <plugins>
       <plugin>
-        <!-- critical because sshd needs to be loaded first, otherwise will just bail out -->
-        <!-- https://www.jenkins.io/doc/developer/plugin-development/dependencies-and-class-loading/ -->
         <groupId>org.jenkins-ci.tools</groupId>
         <artifactId>maven-hpi-plugin</artifactId>
         <extensions>true</extensions>
         <configuration>
-          <pluginFirstClassLoader>true</pluginFirstClassLoader>
           <compatibleSinceVersion>1.5</compatibleSinceVersion>
         </configuration>
       </plugin>

src/main/java/com/cloudbees/jenkins/plugins/sshagent/RemoteHelper.java

@@ -147,6 +147,7 @@ private void initRemoteAgent() throws IOException, InterruptedException {
             listener.getLogger().println(Messages.SSHAgentBuildWrapper_UsingCredentials(SSHAgentBuildWrapper.description(userPrivateKey)));
         }
 
+        // TODO UI could be streamlined now that there is only one impl
         listener.getLogger().println("[ssh-agent] Looking for ssh-agent implementation...");
         Map<String, Throwable> faults = new LinkedHashMap<String, Throwable>();
         for (RemoteAgentFactory factory : Jenkins.getActiveInstance().getExtensionList(RemoteAgentFactory.class)) {