Skip to content

Commit edb3593

Browse files
committed
v5.2.0 - Ping and pong messages now pass through formatter/codec
1 parent 55a7ac0 commit edb3593

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "socketcluster-server",
3-
"version": "5.1.6",
3+
"version": "5.2.0",
44
"description": "Server module for SocketCluster",
55
"main": "index.js",
66
"dependencies": {
@@ -12,7 +12,7 @@
1212
"sc-domain": "1.x.x",
1313
"sc-emitter": "1.0.x",
1414
"sc-errors": "1.0.x",
15-
"sc-formatter": "2.0.x",
15+
"sc-formatter": "3.0.x",
1616
"sc-simple-broker": "1.2.x",
1717
"uws": "0.11.0",
1818
"ws": "1.1.1"

scsocket.js

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -78,16 +78,15 @@ var SCSocket = function (id, server, socket) {
7878

7979
SCEmitter.prototype.emit.call(self, 'message', message);
8080

81-
// If pong, we don't need to decode the message.
82-
// We just check the token expiry and deauthenticate the socket if it has expired.
83-
if (message == '#2') {
81+
var obj = self.decode(message);
82+
83+
// If pong
84+
if (obj == '#2') {
8485
var token = self.getAuthToken();
8586
if (self.server.isAuthTokenExpired(token)) {
8687
self.deauthenticate();
8788
}
8889
} else {
89-
var obj = self.decode(message);
90-
9190
if (obj == null) {
9291
var err = new InvalidMessageError('Received empty message');
9392
SCEmitter.prototype.emit.call(self, 'error', err);
@@ -147,7 +146,7 @@ SCSocket.errorStatuses = scErrors.socketProtocolErrorStatuses;
147146

148147
SCSocket.prototype._sendPing = function () {
149148
if (this.state != this.CLOSED) {
150-
this.send('#1');
149+
this.sendObject('#1');
151150
}
152151
};
153152

0 commit comments

Comments
 (0)