Skip to content

Commit 98c60b3

Browse files
committed
More style tweaks.
1 parent bd002f0 commit 98c60b3

File tree

2 files changed

+16
-3
lines changed

2 files changed

+16
-3
lines changed

src/browser.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,8 +225,9 @@ class GitHubEditableName extends Widget {
225225
super();
226226
this.addClass('jp-GitHubEditableName');
227227
this._nameNode = document.createElement('div');
228+
this._nameNode.className = 'jp-GitHubEditableName-display';
228229
this._editNode = document.createElement('input');
229-
this._editNode.className = 'jp-GitHubEditableNameInput';
230+
this._editNode.className = 'jp-GitHubEditableName-input';
230231

231232
this._placeholder = placeholder || '<Edit Name>'
232233

@@ -241,7 +242,9 @@ class GitHubEditableName extends Widget {
241242
this._pending = true;
242243
Private.changeField(this._nameNode, this._editNode).then(value => {
243244
this._pending = false;
244-
this.name.set(value);
245+
if (this.name.get() !== value) {
246+
this.name.set(value);
247+
}
245248
});
246249
};
247250

style/index.css

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,20 @@
2525
white-space: nowrap;
2626
text-align: center;
2727
font-size: large;
28+
padding: 0px;
2829
flex: 8 8;
2930
}
3031

31-
.jp-GitHubBrowser .jp-GitHubEditableNameInput {
32+
.jp-GitHubBrowser .jp-GitHubEditableName-display {
33+
border: 1px solid transparent;
34+
}
35+
36+
.jp-GitHubBrowser .jp-GitHubEditableName-display:hover {
37+
border: 1px solid var(--jp-border-color1);
38+
box-shadow: 0px 0px 2px 0px rgba(0,0,0,0.24);
39+
}
40+
41+
.jp-GitHubBrowser .jp-GitHubEditableName-input {
3242
background-color: var(--jp-layout-color2);
3343
color: var(--jp-ui-font-color1);
3444
font-size: large;

0 commit comments

Comments
 (0)