Merge pull request strongloop-archive#50 from zero5100/tdb_length_fix

Ensure that a generated string value is not longer than the property's specified length

Author: bajtos

lib/test-data-builder.js

@@ -120,7 +120,16 @@ TestDataBuilder.prototype._gatherDefaultPropertyValues = function(Model) {
 
     switch (prop.type) {
       case String:
-        result[name] = 'a test ' + name + ' #' + (++valueCounter);
+        var generatedString = 'a test ' + name + ' #' + (++valueCounter);
+
+        // If this property has a maximum length, ensure that the generated
+        // string is not longer than the property's max length
+        if (prop.length) {
+          // Chop off the front part of the string so it is equal to the length
+          generatedString = generatedString.substring(
+            generatedString.length - prop.length);
+        }
+        result[name] = generatedString;
         break;
       case Number:
         result[name] = 1230000 + (++valueCounter);

test/test-data-builder.test.js

@@ -48,6 +48,23 @@ describe('TestDataBuilder', function() {
   itAutoFillsRequiredPropertiesWithUniqueValuesFor(Number);
   itAutoFillsRequiredPropertiesWithUniqueValuesFor(Date);
 
+  it('limits the length of the generated string value to the property length', function(done) {
+    var testMaxStringLength = 10;
+    givenTestModel({
+      required1: { type: String, required: true },
+      required2: { type: String, required: true, length: testMaxStringLength }
+    });
+
+    new TestDataBuilder()
+      .define('model', TestModel, {})
+      .buildTo(this, function(err) {
+        if (err) return done(err);
+        expect(this.model.required1).to.not.equal(this.model.required2);
+        expect(this.model.required2).to.have.length.of.at.most(testMaxStringLength);
+        done();
+      }.bind(this));
+  });
+
   it('auto-fills required Boolean properties with false', function(done) {
     givenTestModel({
       required: { type: Boolean, required: true }