Skip to content

Update v1 api to support image search #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update v1 api to support image search #276

wants to merge 1 commit into from

Conversation

dnth
Copy link
Contributor

@dnth dnth commented Sep 13, 2023

This PR adds image search support to the V1 API.

Closes #269

@dnth dnth requested review from dbickson and amiralush September 13, 2023 04:27
@dbickson
Copy link
Collaborator

@dnth the code will not support fully model_paths that are allowed resent50, efficientnet, clip14, clip336 etc etc
I prefer not to include onnxruntime here, if the user has no standard model all new resize param

@dbickson
Copy link
Collaborator

@dnth I merged this manually, please note the function documentation was missing i copied it from fastdup.init, in addition the user should resize the image on his own. I also added fd.vector_search() which is support for low level vector search (instead of image search)

@dbickson dbickson closed this Sep 15, 2023
@dnth dnth deleted the dnth/searchv1 branch September 19, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Image search parameters not passed to search function when using DINOv2s
2 participants