Skip to content

Commit a12a2c8

Browse files
committed
Don't keep extra id_token info in token_response.
This tweaks `Flow.step2_exchange` to only preserve the raw `id_token` response in the generated `Credentials`, and updates `CHANGELOG`.
1 parent 2c5fabd commit a12a2c8

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

CHANGELOG

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
v.next
2+
3+
Change `flow.step2_exchange` to preserve the raw `id_token` in the
4+
`token_response` field.
5+
16
v1.3.2
27
Version 1.3.2
38

@@ -8,7 +13,7 @@ v1.3.1
813
Version 1.3.1
914

1015
Quick bugfix for bad error handling in from_json.
11-
16+
1217
v1.3
1318
Version 1.3
1419

@@ -31,7 +36,7 @@ v1.3
3136
- Better logging for missing `refresh_token` in server replies (#21).
3237
- Support `login_hint` (#18, thanks @jay0lee).
3338
- Better overwrite options in `django_orm.Storage`. (#2, thanks
34-
@lraccomando).
39+
@lraccomando).
3540

3641

3742
v1.2

oauth2client/client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1838,14 +1838,14 @@ def step2_exchange(self, code=None, http=None, device_flow_info=None):
18381838

18391839
extracted_id_token = None
18401840
if 'id_token' in d:
1841-
d['extracted_id_token'] = _extract_id_token(d['id_token'])
1841+
extracted_id_token = _extract_id_token(d['id_token'])
18421842

18431843
logger.info('Successfully retrieved access token')
18441844
return OAuth2Credentials(access_token, self.client_id,
18451845
self.client_secret, refresh_token, token_expiry,
18461846
self.token_uri, self.user_agent,
18471847
revoke_uri=self.revoke_uri,
1848-
id_token=d.get('extracted_id_token', None),
1848+
id_token=extracted_id_token,
18491849
token_response=d)
18501850
else:
18511851
logger.info('Failed to retrieve access token: %s', content)

0 commit comments

Comments
 (0)