Move assigment logic to Json::Builder.assign!

Author: Klaas Speller

lib/jsonit/builder.rb

@@ -1,7 +1,7 @@
 module Jsonit
   class Builder
 
-    instance_methods.each { |m| undef_method(m) unless m.to_s =~ /^__|object_id|\?$/ }
+    instance_methods.each { |m| undef_method(m) unless m.to_s =~ /^__|object_id|\?$|!$/ }
 
     def initialize(scope={})
       @document = @current_scope = scope
@@ -18,30 +18,41 @@ def to_json(*args)
 
     def set!(key=nil, value=nil, &blk)
       if !block_given?
-        if value.is_a?(Hash) && @current_scope[key].is_a?(Hash)
-          @current_scope[key].merge!(value)
-        else
-          @current_scope[key] = value
-        end
+        assign!(key, value)
       elsif value.is_a?(Enumerable)
         array!(key, value, &blk)
       else
         object!(key, value, &blk)
       end
       self
     end
-    alias_method :method_missing, :set!
-    
+
     def object!(key=nil, value=nil, &blk)
       @current_scope, previous_scope = {}, @current_scope
       yield value
       @current_scope, new_scope = previous_scope, @current_scope
-      !key.nil? ? set!(key, new_scope) : Builder.new(new_scope)
+      !key.nil? ? assign!(key, new_scope) : Builder.new(new_scope)
     end
 
     def array!(key, collection=[], &blk)
       collection.map! { |itm| object!(nil, itm, &blk) } if block_given?
-      set!(key, collection)
+      assign!(key, collection)
+    end
+
+    def assign!(key, value=nil)
+      if value.is_a?(Hash) && @current_scope[key].is_a?(Hash)
+        @current_scope[key].merge!(value)
+      else
+        @current_scope[key] = value
+      end
+      self
+    end
+    
+    def method_missing(meth, *args, &blk)
+      if (meth.to_s =~ /\?$|!$/).nil?
+        return set!(meth, *args, &blk)
+      end
+      super
     end
   end
 end

spec/jsonit/builder_spec.rb

@@ -94,6 +94,56 @@
     end
   end
 
+
+  describe "#assign!" do
+    let(:json) { Jsonit::Builder.new }
+
+    it 'returns an instance of self' do
+      json.assign!(:foo).should be_a Jsonit::Builder
+    end
+
+    it 'creates a key value pair' do
+      json.assign!(:foo, "bar").to_json.should == %|{"foo":"bar"}|
+    end
+
+    it 'can assign an array' do
+      json.assign!(:foo, ["a", "b", "c"]).to_json.should == %|{"foo":["a","b","c"]}|
+    end
+    
+    it 'can assign an object' do
+      json.assign!(:foo, {"a" => "b"}).to_json.should == %|{"foo":{"a":"b"}}|
+    end
+
+    it 'continues an object with same key' do
+      json.assign!(:foo, {"a" => "b"})
+      json.assign!(:foo, {"c" => "d"})
+      json.to_json.should == %|{"foo":{"a":"b","c":"d"}}|
+    end
+  end
+
+  describe "ghost methods" do
+    let(:json) { Jsonit::Builder.new }
+    
+    it 'does not raise method missing for method with format /^[a-z][a-z0-9]+$/' do
+      [:a, :b, :c].each do |m|
+        expect { json.send(m) }.to_not raise_error
+      end
+    end
+
+
+    it 'raises method missing for ending with a "?"' do
+      [:a?, :b?, :c?].each do |m|
+        expect { eval("json.#{m.to_s}") }.to raise_error(NoMethodError)
+      end
+    end
+    
+    it 'raises method missing for ending with a "!"' do
+      [:a!, :b!, :c!].each do |m|
+        expect { eval("json.#{m.to_s}") }.to raise_error(NoMethodError)
+      end
+    end
+  end
+
   describe "DSL" do
     it "can nest multiple levels" do
       Jsonit::Builder.new do |json|