Skip to content

Commit 60c3728

Browse files
author
Dmitry Igoshin
committed
Guarding the console.log statements with debug mode.
Logging to the browser console from a 3rd party component such as this directive doesn't bring value to the projects using it and potentially produces noise in the logs.
1 parent dc5971e commit 60c3728

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

dist/angular-pdf.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
angular.module('pdf', []).directive('ngPdf', [ '$window', function($window) {
77
var renderTask = null;
88
var pdfLoaderTask = null;
9+
var debug = false;
910

1011
var backingScale = function(canvas) {
1112
var ctx = canvas.getContext('2d');
@@ -43,6 +44,7 @@
4344
var canvasid = attrs.canvasid || 'pdf-canvas';
4445
var canvas = document.getElementById(canvasid);
4546

47+
debug = attrs.hasOwnProperty('debug') ? attrs.debug : false;
4648
var creds = attrs.usecredentials;
4749
var ctx = canvas.getContext('2d');
4850
var windowEl = angular.element($window);
@@ -189,7 +191,9 @@
189191

190192
scope.$watch('pdfUrl', function(newVal) {
191193
if (newVal !== '') {
192-
console.log('pdfUrl value change detected: ', scope.pdfUrl);
194+
if (debug) {
195+
console.log('pdfUrl value change detected: ', scope.pdfUrl);
196+
}
193197
url = newVal;
194198
scope.pageNum = scope.pageToDisplay = pageToDisplay;
195199
if (pdfLoaderTask) {

dist/angular-pdf.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

example/js/directives/angular-pdf.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
angular.module('pdf', []).directive('ngPdf', [ '$window', function($window) {
77
var renderTask = null;
88
var pdfLoaderTask = null;
9+
var debug = false;
910

1011
var backingScale = function(canvas) {
1112
var ctx = canvas.getContext('2d');
@@ -43,6 +44,7 @@
4344
var canvasid = attrs.canvasid || 'pdf-canvas';
4445
var canvas = document.getElementById(canvasid);
4546

47+
debug = attrs.hasOwnProperty('debug') ? attrs.debug : false;
4648
var creds = attrs.usecredentials;
4749
var ctx = canvas.getContext('2d');
4850
var windowEl = angular.element($window);
@@ -189,7 +191,9 @@
189191

190192
scope.$watch('pdfUrl', function(newVal) {
191193
if (newVal !== '') {
192-
console.log('pdfUrl value change detected: ', scope.pdfUrl);
194+
if (debug) {
195+
console.log('pdfUrl value change detected: ', scope.pdfUrl);
196+
}
193197
url = newVal;
194198
scope.pageNum = scope.pageToDisplay = pageToDisplay;
195199
if (pdfLoaderTask) {

0 commit comments

Comments
 (0)