恢复 BaseModel 和 SoftDelete 的测试用例;

Author: huacnlee

app/models/concerns/base_model.rb

@@ -3,7 +3,7 @@ module BaseModel
 
   included do
     scope :recent, -> { order(id: :desc) }
-    scope :exclude_ids, ->(ids) { where(:id.nin => ids.map(&:to_i)) }
+    scope :exclude_ids, ->(ids) { where.not(id: ids.map(&:to_i)) }
     scope :by_week, -> { where("created_at > ?", 7.days.ago.utc) }
 
     delegate :url_helpers, to: 'Rails.application.routes'

app/models/concerns/soft_delete.rb

@@ -10,8 +10,7 @@ module SoftDelete
   def destroy
     run_callbacks(:destroy) do
       if persisted?
-        update_attribute(:deleted_at, Time.now.utc)
-        update_attribute(:updated_at, Time.now.utc)
+        update_attributes(deleted_at: Time.now.utc, updated_at: Time.now.utc)
       end
 
       @destroyed = true

spec/models/concerns/base_model_spec.rb

@@ -0,0 +1,48 @@
+require 'rails_helper'
+
+describe BaseModel, type: :model do
+  ActiveRecord::Base.connection.create_table(:monkeys, force: true) do |t|
+    t.string :name
+    t.timestamps null: false
+  end
+
+  class Monkey < ActiveRecord::Base
+    include BaseModel
+  end
+
+  after(:each) do
+    Monkey.delete_all
+  end
+
+  it 'should have recent scope method' do
+    monkey = Monkey.create(name: 'Caesar', id: 1)
+    ghost = Monkey.create(name: 'Wukong', id: 2)
+
+    expect(Monkey.recent.to_a).to eq([ghost, monkey])
+  end
+
+  it 'should have exclude_ids scope method' do
+    ids = Array(1..10)
+    ids.each { |i| Monkey.create(name: "entry##{i}", id: i) }
+
+    result1 = Monkey.exclude_ids(ids.to(4).map(&:to_s)).map(&:name)
+    result2 = Monkey.exclude_ids(ids.from(5)).map(&:name)
+
+    expect(result1).to eq(ids.from(5).map { |i| "entry##{i}" })
+    expect(result2).to eq(ids.to(4).map { |i| "entry##{i}" })
+  end
+
+  it 'should have find_by_id class methods' do
+    monkey = Monkey.create(name: 'monkey', id: 1)
+    expect(Monkey.find_by_id(1)).to eq(monkey)
+    expect(Monkey.find_by_id('1')).to eq(monkey)
+    expect(Monkey.find_by_id(2)).to be_nil
+  end
+
+  it 'should have by_week method' do
+    Monkey.create(name: 'Caesar', created_at: 2.weeks.ago.utc)
+    Monkey.create(name: 'Caesar1', created_at: 3.days.ago.utc)
+    Monkey.create(name: 'Caesar1', created_at: Time.now.utc)
+    expect(Monkey.by_week.count).to eq(2)
+  end
+end

spec/models/concerns/soft_delete_spec.rb

@@ -0,0 +1,59 @@
+require 'rails_helper'
+
+describe SoftDelete, type: :model do
+  ActiveRecord::Base.connection.create_table(:walking_deads, force: true) do |t|
+    t.string :name
+    t.string :tag
+    t.datetime :deleted_at
+    t.timestamps null: false
+  end
+
+  class WalkingDead < ActiveRecord::Base
+    include BaseModel
+    include SoftDelete
+
+    after_destroy do
+      self.tag = "after_destroy #{name}"
+    end
+  end
+
+  let!(:rick) { WalkingDead.create! name: 'Rick Grimes' }
+
+  it 'should affect default count' do
+    expect do
+      rick.destroy
+    end.to change(WalkingDead, :count).by(-1)
+  end
+
+  it 'should not affect unscoped count' do
+    expect do
+      rick.destroy
+    end.to_not change(WalkingDead.unscoped, :count)
+  end
+
+  it 'should update the deleted_at field' do
+    expect do
+      rick.destroy
+    end.to change { rick.deleted_at }.from(nil)
+  end
+
+  it 'should use deleted?' do
+    expect do
+      rick.destroy
+    end.to change { rick.deleted? }.from(false).to(true)
+  end
+
+  it 'should mark as destroyed and get proper query result' do
+    rick.destroy
+    expect(rick).to be_destroyed
+
+    expect(WalkingDead.where(name: rick.name).count).to eq(0)
+    expect(WalkingDead.unscoped.where(name: rick.name).first).to eq(rick)
+  end
+
+  it 'is run callback after destroy' do
+    rick.name = 'foo'
+    rick.destroy
+    expect(rick.tag).to eq('after_destroy foo')
+  end
+end