Skip to content

Commit ddaa7d2

Browse files
committed
Minor: make test output less verbose
(cherry picked from commit 919c099)
1 parent 7cb79f9 commit ddaa7d2

File tree

3 files changed

+16
-5
lines changed

3 files changed

+16
-5
lines changed

libraries/stdlib/test/ExceptionJVMTest.kt

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import test.collections.assertArrayNotSameButEquals
66
import org.junit.Test as test
77
import java.io.PrintWriter
88
import java.io.*
9+
import java.nio.charset.Charset
910

1011
class ExceptionJVMTest {
1112

@@ -24,7 +25,7 @@ class ExceptionJVMTest {
2425
val buffer = StringWriter()
2526
val writer = PrintWriter(buffer)
2627
t.printStackTrace(writer)
27-
println(buffer)
28+
comparePrintedThrowableResult(t, buffer.buffer)
2829
}
2930

3031
fun assertPrintStackTraceStream(t: Throwable) {
@@ -40,7 +41,17 @@ class ExceptionJVMTest {
4041
}
4142

4243
val bytes = assertNotNull(byteBuffer.toByteArray())
43-
assertTrue(bytes.size > 10)
44+
val content = bytes.toString(Charset.defaultCharset())
45+
comparePrintedThrowableResult(t, content)
46+
}
47+
48+
private fun comparePrintedThrowableResult(throwable: Throwable, printedThrowable: CharSequence) {
49+
val stackTrace = throwable.stackTrace
50+
val lines = printedThrowable.lines()
51+
assertEquals(throwable.toString(), lines[0])
52+
stackTrace.forEachIndexed { index, frame ->
53+
assertTrue(lines.any { frame.toString() in it }, "frame at index $index is not found in the printed message")
54+
}
4455
}
4556

4657
@test fun changeStackTrace() {

libraries/stdlib/test/concurrent/TimerTest.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@ class TimerTest {
1515

1616
val task = timer.scheduleAtFixedRate(1000, 100) {
1717
val current = counter.incrementAndGet()
18-
println("Timer fired at $current")
18+
// println("Timer fired at $current")
1919
}
2020
Thread.sleep(1500)
2121
task.cancel()
2222

2323
val value = counter.get()
24-
assertTrue(value > 4, "current counter is $value")
24+
assertTrue(value > 4, "Expected to fire at least 4 times, but was $value")
2525
}
2626
}

libraries/stdlib/test/io/Files.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ class FilesTest {
157157

158158
fun assertFailsRelativeTo(file: File, base: File) {
159159
val e = assertFailsWith<IllegalArgumentException>("file: $file, base: $base") { file.relativeTo(base) }
160-
println(e.message)
160+
// println(e.message)
161161
}
162162

163163
val allFiles = listOf(absolute, relative) + if (isBackslashSeparator) listOf(networkShare1, networkShare2) else emptyList()

0 commit comments

Comments
 (0)