Issue MikaelEliasson#47 : UpdateAll doesn't work for nvarchar(xxx)

Author: MikaelEliasson

EntityFramework.Utilities/EntityFramework.Utilities/EFBatchOperation.cs

@@ -160,7 +160,7 @@ public void UpdateAll<TEntity>(IEnumerable<TEntity> items, Action<UpdateSpecific
                     .Select(p => new ColumnMapping { 
                         NameInDatabase = p.ColumnName, 
                         NameOnObject = p.PropertyName, 
-                        DataType = p.DataType,
+                        DataType = p.DataTypeFull,
                         IsPrimaryKey = p.IsPrimaryKey
                      }).ToList();
 

EntityFramework.Utilities/EntityFramework.Utilities/MappingHelper.cs

@@ -92,6 +92,8 @@ public class PropertyMapping
         public string DataType { get; set; }
 
         public bool IsPrimaryKey { get; set; }
+
+        public string DataTypeFull { get; set; }
     }
 
     /// <summary>
@@ -172,13 +174,15 @@ public EfMapping(DbContext db)
                         {
                             ColumnName = scalar.Column.Name,
                             DataType = scalar.Column.TypeName,
+                            DataTypeFull = GetFullTypeName(scalar),
                             PropertyName = path + item.Property.Name,
                             ForEntityType = t
                         });
                     }
                 };
 
-                Func<MappingFragment, Type> getClr = m => {
+                Func<MappingFragment, Type> getClr = m =>
+                {
                     return GetClrTypeFromTypeMapping(metadata, objectItemCollection, m.TypeMapping as EntityTypeMapping);
                 };
 
@@ -188,7 +192,7 @@ public EfMapping(DbContext db)
                     tableMapping.TPHConfiguration = new TPHConfiguration
                        {
                            ColumnName = withConditions.First().Fragments[0].Conditions[0].Column.Name,
-                           Mappings = new Dictionary<Type,string>()
+                           Mappings = new Dictionary<Type, string>()
                        };
                     foreach (var item in withConditions)
                     {
@@ -221,6 +225,15 @@ public EfMapping(DbContext db)
             }
         }
 
+        private string GetFullTypeName(ScalarPropertyMapping scalar)
+        {
+            if (scalar.Column.TypeName == "nvarchar" || scalar.Column.TypeName == "varchar")
+            {
+                return string.Format("{0}({1})", scalar.Column.TypeName, scalar.Column.MaxLength);
+            }
+            return scalar.Column.TypeName;
+        }
+
         private Type GetClrTypeFromTypeMapping(MetadataWorkspace metadata, ObjectItemCollection objectItemCollection, EntityTypeMapping mapping)
         {
             return GetClrType(metadata, objectItemCollection, mapping.EntityType ?? mapping.IsOfEntityTypes.First());

EntityFramework.Utilities/Tests/FakeDomain/Context.cs

@@ -33,6 +33,8 @@ protected override void OnModelCreating(DbModelBuilder modelBuilder)
             modelBuilder.Entity<Person>()
                 .Map<Person>(m => m.Requires("Type").HasValue("Person"))
                 .Map<Contact>(m => m.Requires("Type").HasValue("Contact"));
+
+            modelBuilder.Entity<BlogPost>().Property(x => x.ShortTitle).HasMaxLength(100);
         }
 
         public static Context Sql()

EntityFramework.Utilities/Tests/Models/BlogPost.cs

@@ -9,6 +9,7 @@ public class BlogPost
     {
         public int ID { get; set; }
         public string Title { get; set; }
+        public string ShortTitle { get; set; }
         public DateTime Created { get; set; }
         public int Reads { get; set; }
         public AuthorInfo Author { get; set; }

EntityFramework.Utilities/Tests/Models/ReorderedBlogPost.cs

@@ -8,6 +8,7 @@ namespace Tests.FakeDomain.Models
     public class ReorderedBlogPost
     {
         public int ID { get; set; }
+        public string ShortTitle { get; set; }
         public DateTime Created { get; set; }
         public string Title { get; set; } //<--- Reversed order of this and created for Batch Insert testing
         public int Reads { get; set; }

EntityFramework.Utilities/Tests/UpdateBulkTests.cs

@@ -34,6 +34,30 @@ public void UpdateBulk_UpdatesAll()
             }
         }
 
+        [TestMethod]
+        public void UpdateBulk_CanUpdateNvarcharWithLength()
+        {
+            Setup();
+
+            using (var db = Context.Sql())
+            {
+                var posts = db.BlogPosts.ToList();
+                foreach (var post in posts)
+                {
+                    post.ShortTitle = post.Title.Replace("1", "4").Replace("2", "8").Replace("3", "12");
+                }
+                EFBatchOperation.For(db, db.BlogPosts).UpdateAll(posts, spec => spec.ColumnsToUpdate(p => p.ShortTitle));
+            }
+
+            using (var db = Context.Sql())
+            {
+                var posts = db.BlogPosts.OrderBy(b => b.ID).ToList();
+                Assert.AreEqual("T4", posts[0].ShortTitle);
+                Assert.AreEqual("T8", posts[1].ShortTitle);
+                Assert.AreEqual("T12", posts[2].ShortTitle);
+            }
+        }
+
         private static void Setup()
         {
             using (var db = Context.Sql())