Merge pull request django-cms#3370 from yakky/feature/generic_static_analysis

Make cms.test_utils.utils.static_analysis usable outside the CMS test su...

Author: yakky

cms/test_utils/util/static_analysis.py

@@ -5,9 +5,6 @@
 from pyflakes.checker import Checker
 from pyflakes.reporter import Reporter
 
-import cms
-import menus
-
 
 def _pyflakes_report_with_nopyflakes(self, messageClass, node, *args, **kwargs):
     with open(self.filename, 'r') as code:
@@ -35,7 +32,7 @@ def _check_recursive(paths, reporter):
     return num_warnings
 
 
-def pyflakes():
+def pyflakes(packages):
     """
     Unfortunately, pyflakes does not have a way to suppress certain errors or
     a way to configure the checker class, so we have to monkey patch it.
@@ -46,9 +43,5 @@ def pyflakes():
     Checker.__init__ = _pyflakes_no_migrations
     Checker.report = _pyflakes_report_with_nopyflakes
     reporter = Reporter(sys.stdout, sys.stderr)
-    paths = [
-        os.path.abspath(os.path.dirname(cms.__file__)),
-        os.path.abspath(os.path.dirname(menus.__file__)),
-        os.path.abspath(__file__),
-    ]
+    paths = [os.path.dirname(package.__file__) for package in packages]
     return _check_recursive(paths, reporter)

cms/tests/static_analysis.py

@@ -7,4 +7,6 @@ class AboveStaticAnalysisCodeTest(TestCase):
     Name is pretty lame, but ensure it's executed before every other test
     """
     def test_pyflakes(self):
-        self.assertEqual(pyflakes(), 0)
+        import cms
+        import menus
+        self.assertEqual(pyflakes((cms, menus)), 0)