Skip to content

Commit 295d1e2

Browse files
dhruvduttevenstensberg
authored andcommitted
cli(add): support for webpack config file (#501)
* cli(add): add support for webpack config * cli(utils): update signature for config helper * chore(deps): add log-symbols * cli: update modify-config-helper usage
1 parent 945be4b commit 295d1e2

File tree

17 files changed

+945
-521
lines changed

17 files changed

+945
-521
lines changed

package-lock.json

Lines changed: 523 additions & 201 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/add/index.js

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,23 @@
11
"use strict";
22

33
const defaultGenerator = require("@webpack-cli/generators/add-generator");
4-
const modifyHelper = require("@webpack-cli/utils/modify-config-helper");
4+
const modifyConfigHelper = require("@webpack-cli/utils/modify-config-helper");
55

66
/**
77
* Is called and returns a scaffolding instance, adding properties
88
*
9-
* @returns {Function} modifyHelper - A helper function that uses the action
9+
* @returns {Function} modifyConfigHelper - A helper function that uses the action
1010
* we're given on a generator
1111
*
1212
*/
1313

14-
module.exports = function add() {
15-
return modifyHelper("add", defaultGenerator);
14+
module.exports = function add(...args) {
15+
const DEFAULT_WEBPACK_CONFIG_FILENAME = "webpack.config.js";
16+
17+
const filePaths = args.slice(3);
18+
let configFile = DEFAULT_WEBPACK_CONFIG_FILENAME;
19+
if (filePaths.length) {
20+
configFile = filePaths[0];
21+
}
22+
return modifyConfigHelper("add", defaultGenerator, configFile);
1623
};

packages/generate-loader/package-lock.json

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/generate-plugin/package-lock.json

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/generators/package-lock.json

Lines changed: 39 additions & 32 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/info/package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/init/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
const npmPackagesExists = require("@webpack-cli/utils/npm-packages-exists");
44
const defaultGenerator = require("@webpack-cli/generators/init-generator");
5-
const modifyHelper = require("@webpack-cli/utils/modify-config-helper");
5+
const modifyConfigHelper = require("@webpack-cli/utils/modify-config-helper");
66

77
/**
88
*
@@ -19,7 +19,7 @@ module.exports = function initializeInquirer(...args) {
1919
const packages = args.slice(3);
2020

2121
if (packages.length === 0) {
22-
return modifyHelper("init", defaultGenerator);
22+
return modifyConfigHelper("init", defaultGenerator);
2323
}
2424
return npmPackagesExists(packages);
2525
};

packages/init/package-lock.json

Lines changed: 18 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)