Skip to content

Commit 1701fcc

Browse files
LarchLiuPanJiaChen
authored andcommitted
fix[Charts]: fixed charts resize mixins bug PanJiaChen#1285 (PanJiaChen#1290)
1 parent 1d684b7 commit 1701fcc

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

src/components/Charts/mixins/resize.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
import { debounce } from '@/utils'
22

33
export default {
4+
data() {
5+
return {
6+
sidebarElm: null
7+
}
8+
},
49
mounted() {
510
this.__resizeHandler = debounce(() => {
611
if (this.chart) {
@@ -9,14 +14,13 @@ export default {
914
}, 100)
1015
window.addEventListener('resize', this.__resizeHandler)
1116

12-
const sidebarElm = document.getElementsByClassName('sidebar-container')[0]
13-
sidebarElm.addEventListener('transitionend', this.sidebarResizeHandler)
17+
this.sidebarElm = document.getElementsByClassName('sidebar-container')[0]
18+
this.sidebarElm && this.sidebarElm.addEventListener('transitionend', this.sidebarResizeHandler)
1419
},
1520
beforeDestroy() {
1621
window.removeEventListener('resize', this.__resizeHandler)
1722

18-
const sidebarElm = document.getElementsByClassName('sidebar-container')[0]
19-
sidebarElm.removeEventListener('transitionend', this.sidebarResizeHandler)
23+
this.sidebarElm && this.sidebarElm.removeEventListener('transitionend', this.sidebarResizeHandler)
2024
},
2125
methods: {
2226
sidebarResizeHandler(e) {

src/views/dashboard/admin/components/LineChart.vue

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ export default {
3232
},
3333
data() {
3434
return {
35-
chart: null
35+
chart: null,
36+
sidebarElm: null
3637
}
3738
},
3839
watch: {
@@ -55,8 +56,8 @@ export default {
5556
}
5657
5758
// 监听侧边栏的变化
58-
const sidebarElm = document.getElementsByClassName('sidebar-container')[0]
59-
sidebarElm.addEventListener('transitionend', this.sidebarResizeHandler)
59+
this.sidebarElm = document.getElementsByClassName('sidebar-container')[0]
60+
this.sidebarElm && this.sidebarElm.addEventListener('transitionend', this.sidebarResizeHandler)
6061
},
6162
beforeDestroy() {
6263
if (!this.chart) {
@@ -66,8 +67,7 @@ export default {
6667
window.removeEventListener('resize', this.__resizeHandler)
6768
}
6869
69-
const sidebarElm = document.getElementsByClassName('sidebar-container')[0]
70-
sidebarElm.removeEventListener('transitionend', this.sidebarResizeHandler)
70+
this.sidebarElm && this.sidebarElm.removeEventListener('transitionend', this.sidebarResizeHandler)
7171
7272
this.chart.dispose()
7373
this.chart = null

0 commit comments

Comments
 (0)