AssertionErrorCreator: Fix TODO

PascalSchumacher · PascalSchumacher · commit f58a64ee8416 · 2019-07-28T18:59:59.000+02:00
diff --git a/src/main/java/org/assertj/core/error/AssertionErrorCreator.java b/src/main/java/org/assertj/core/error/AssertionErrorCreator.java
@@ -59,11 +59,9 @@ private Optional<AssertionError> assertionFailedError(String message, Object act
         AssertionError assertionError = (AssertionError) o;
         return Optional.of(assertionError);
       }
-      // TODO: single return
-      return Optional.empty();
-    } catch (Throwable e) {
-      return Optional.empty();
+    } catch (Throwable ignored) {
     }
+    return Optional.empty();
   }
 
   private static AssertionError assertionError(String message) {

Original file line number	Diff line number	Diff line change
`@@ -59,11 +59,9 @@ private Optional<AssertionError> assertionFailedError(String message, Object act`
`59`	`59`	`AssertionError assertionError = (AssertionError) o;`
`60`	`60`	`return Optional.of(assertionError);`
`61`	`61`	`}`
`62`		`- // TODO: single return`
`63`		`- return Optional.empty();`
`64`		`- } catch (Throwable e) {`
`65`		`- return Optional.empty();`
	`62`	`+ } catch (Throwable ignored) {`
`66`	`63`	`}`
	`64`	`+ return Optional.empty();`
`67`	`65`	`}`
`68`	`66`
`69`	`67`	`private static AssertionError assertionError(String message) {`