Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: iCamilo/ios-lead-essentials-feed-api-challenge
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: wingovers/ios-lead-essentials-feed-api-challenge
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 12 commits
  • 9 files changed
  • 3 contributors

Commits on Sep 21, 2020

  1. Update to recommended settings (Xcode 12)

    @caiozullo
    caiozullo committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    61f0cd5 View commit details
    Browse the repository at this point in the history

  2. Replace #file with the new #filePath

    @caiozullo
    caiozullo committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    f00d440 View commit details
    Browse the repository at this point in the history

  3. Update CI config to use Xcode 12

    @caiozullo
    caiozullo committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    9bdb08b View commit details
    Browse the repository at this point in the history

  4. Update README

    @caiozullo
    caiozullo committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    ac0f5c1 View commit details
    Browse the repository at this point in the history

  5. Merge pull request #35 from essentialdevelopercom/xcode12 

    Update to Xcode 12
    @mapostolakis
    mapostolakis authored Sep 21, 2020
    Configuration menu
    Copy the full SHA
    a8ca4b4 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2020

  1. Place requests to HTTPClient

    @wingovers
    wingovers committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    531b9a5 View commit details
    Browse the repository at this point in the history

  2. Return Error.connectivity on HTTPClient error

    @wingovers
    wingovers committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    afe4886 View commit details
    Browse the repository at this point in the history

  3. Return Error.invalidData on non HTTP 200

    @wingovers
    wingovers committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    bc23243 View commit details
    Browse the repository at this point in the history

  4. Return Error.invalidData on invalid JSON

    @wingovers
    wingovers committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    b81d5b2 View commit details
    Browse the repository at this point in the history

  5. Return empty FeedImages on empty response

    @wingovers
    wingovers committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    afda2e0 View commit details
    Browse the repository at this point in the history

  6. Return parsed JSON with valid response data

    @wingovers
    wingovers committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    3bacbb0 View commit details
    Browse the repository at this point in the history

  7. Ensure deallocation terminates request processing

    @wingovers
    wingovers committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    c32e5f5 View commit details
    Browse the repository at this point in the history
Loading