Ensure body is an object before checking for an error

wobrien · wobrien · commit 266e7bfc5d39 · 2017-11-07T15:02:59.000Z
diff --git a/lib/requestwrapper.js b/lib/requestwrapper.js
@@ -68,7 +68,7 @@ function formatErrorIfExists(cb) {
     }
 
     // If we have a response and it contains an error
-    if (body && (body.error || body.error_code)) {
+    if (typeof body === 'object' && (body.error || body.error_code)) {
       // visual recognition sets body.error to a json object with code/description/error_id instead of putting them top-left
       if (typeof body.error === 'object' && body.error.description) {
         const errObj = body.error; // just in case there's a body.error.error...

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ function formatErrorIfExists(cb) {`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`// If we have a response and it contains an error`
`71`		`- if (body && (body.error \|\| body.error_code)) {`
	`71`	`+ if (typeof body === 'object' && (body.error \|\| body.error_code)) {`
`72`	`72`	`// visual recognition sets body.error to a json object with code/description/error_id instead of putting them top-left`
`73`	`73`	`if (typeof body.error === 'object' && body.error.description) {`
`74`	`74`	`const errObj = body.error; // just in case there's a body.error.error...`