Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: hardbyte/python-can
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: wolfraven/python-can
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: develop
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on Mar 14, 2023

  1. Reimpl.: Extented slcan.py to use "L" command optional to "O" command. 

    Reimplement "listen-only" parameter and the extention of slcan.py to use "L" command optional to "O" command.
Until a better implementation e.g. using 'BusState' make sense.
On one hand, using "listen-only" parameter keep changes simple in 'slcan.py'.
On the other hand, using 'BusState' (active/passive) is more consistent. But for futher improvements 'BusState' should also handle internal/erternal loopback or e.g. STM32G431 restricted mode.
    @wolfraven
    wolfraven authored Mar 14, 2023
    Configuration menu
    Copy the full SHA
    751dd13 View commit details
    Browse the repository at this point in the history

  2. Modifications in 'bus.py' to avoid reader thread exceptions. 

    For a detailed description see:
Design issue: Using "notifier" inside "with can.Bus(…) as bus" statement has no sufficient clean-up for reader threats. #1526
#1526
    @wolfraven
    wolfraven authored Mar 14, 2023
    Configuration menu
    Copy the full SHA
    e8aa3aa View commit details
    Browse the repository at this point in the history

  3. Modifications in 'notifier.py' to avoid reader thread exceptions. 

    For a detailed description see:
Design issue: Using "notifier" inside "with can.Bus(…) as bus" statement has no sufficient clean-up for reader threats. #1526
#1526
    @wolfraven
    wolfraven authored Mar 14, 2023
    Configuration menu
    Copy the full SHA
    41fc42e View commit details
    Browse the repository at this point in the history
Loading