Skip to content

Commit c06ca37

Browse files
RikuojaGagaro
authored andcommitted
Add request to formfield_for_dbfield signature; fix makinacorpus#260 (makinacorpus#261)
1 parent 64bc087 commit c06ca37

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

leaflet/admin.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class LeafletGeoAdminMixin(object):
2626
display_raw = False
2727
settings_overrides = {}
2828

29-
def formfield_for_dbfield(self, db_field, **kwargs):
29+
def formfield_for_dbfield(self, db_field, request=None, **kwargs):
3030
"""
3131
Overloaded from ModelAdmin to set Leaflet widget
3232
in form field init params.
@@ -36,7 +36,6 @@ def formfield_for_dbfield(self, db_field, **kwargs):
3636
self.widget.supports_3d)
3737

3838
if is_editable:
39-
kwargs.pop('request', None) # unsupported for form field
4039
# Setting the widget with the newly defined widget.
4140
widget = self.widget
4241
if 'widget' in kwargs and issubclass(kwargs['widget'], LeafletWidget):
@@ -47,7 +46,7 @@ def formfield_for_dbfield(self, db_field, **kwargs):
4746
kwargs['widget'] = self._get_map_widget(db_field, widget)
4847
return db_field.formfield(**kwargs)
4948
else:
50-
return super(LeafletGeoAdminMixin, self).formfield_for_dbfield(db_field, **kwargs)
49+
return super(LeafletGeoAdminMixin, self).formfield_for_dbfield(db_field, request, **kwargs)
5150

5251
def _get_map_widget(self, db_field, widget):
5352
"""

leaflet/tests/tests.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ class BaseLeafletGeoAdminTest(object):
180180
def setUp(self):
181181
self.modeladmin = self.leafletgeoadmin_class(DummyModel, DummyAdminSite())
182182
self.geomfield = DummyModel._meta.get_field('geom')
183-
self.formfield = self.modeladmin.formfield_for_dbfield(self.geomfield)
183+
self.formfield = self.modeladmin.formfield_for_dbfield(self.geomfield, None)
184184

185185
def test_widget_for_field(self):
186186
widget = self.formfield.widget

0 commit comments

Comments
 (0)