Skip to content

Commit 584d7c7

Browse files
committed
do not use then in case statements, use a semicolon instead.
1 parent 6938ebe commit 584d7c7

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

lib/sql_tree/node.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -117,4 +117,4 @@ def self.[](sql, options = {})
117117

118118
require 'sql_tree/node/begin_statement'
119119
require 'sql_tree/node/commit_statement'
120-
require 'sql_tree/node/rollback_statement'
120+
require 'sql_tree/node/rollback_statement'

lib/sql_tree/node/expression.rb

+5-5
Original file line numberDiff line numberDiff line change
@@ -394,11 +394,11 @@ def initialize(value) # :nodoc:
394394
# within an SQL query
395395
def to_sql(options = {})
396396
case value
397-
when nil then 'NULL'
398-
when String then quote_str(@value)
399-
when Numeric then @value.to_s
400-
when Date then @value.strftime("'%Y-%m-%d'")
401-
when DateTime, Time then @value.strftime("'%Y-%m-%d %H:%M:%S'")
397+
when nil; 'NULL'
398+
when String; quote_str(@value)
399+
when Numeric; @value.to_s
400+
when Date; @value.strftime("'%Y-%m-%d'")
401+
when DateTime, Time; @value.strftime("'%Y-%m-%d %H:%M:%S'")
402402
else raise "Don't know how te represent this value in SQL!"
403403
end
404404
end

spec/helpers/matchers.rb

+4-4
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@ class TokenizeTo
33
def initialize(expected_tokens)
44
@expected_tokens = expected_tokens.map do |t|
55
case t
6-
when SQLTree::Token then t
7-
when String then SQLTree::Token::String.new(t)
8-
when Numeric then SQLTree::Token::Number.new(t)
9-
when Symbol then SQLTree::Token.const_get(t.to_s.upcase)
6+
when SQLTree::Token; t
7+
when String; SQLTree::Token::String.new(t)
8+
when Numeric; SQLTree::Token::Number.new(t)
9+
when Symbol; SQLTree::Token.const_get(t.to_s.upcase)
1010
else "Cannot check for this token: #{t.inspect}!"
1111
end
1212
end

0 commit comments

Comments
 (0)