quick follow-up #126 : better error message

Author: benbovy

xsimlab/tests/test_xr_accessor.py

@@ -209,6 +209,12 @@ def test_set_input_vars(self, model, in_dataset):
 
         assert ds["add__offset"].dims == ("x",)
 
+        # test implicit dimension label error
+        in_vars = {("roll", "shift"): [1, 2]}
+
+        with pytest.raises(TypeError, match=r"Could not get dimension labels.*"):
+            ds.xsimlab._set_input_vars(model, in_vars)
+
     def test_update_clocks(self, model):
         ds = xr.Dataset()
         with pytest.raises(ValueError) as excinfo:

xsimlab/xr_accessor.py

@@ -290,6 +290,7 @@ def _uniformize_clock_coords(self, dim=None, units=None, calendar=None):
 
     def _set_input_vars(self, model, input_vars):
         invalid_inputs = set(input_vars) - set(model.input_vars)
+
         if invalid_inputs:
             raise KeyError(
                 ", ".join([str(k) for k in invalid_inputs])
@@ -307,7 +308,13 @@ def _set_input_vars(self, model, input_vars):
                 # dimension labels that match the number of dimensions
                 ndims = len(np.shape(data))
                 dim_labels = {len(d): d for d in var_metadata["dims"]}
-                dims = dim_labels[ndims]
+                dims = dim_labels.get(ndims)
+
+                if dims is None:
+                    raise TypeError(
+                        "Could not get dimension labels from model "
+                        f"for variable {xr_var_name!r} with value {data}"
+                    )
 
                 xr_var = as_variable((dims, data))