Skip to content

Document the content type header for the files API #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

philkra
Copy link
Contributor

@philkra philkra commented Apr 26, 2024

closes #330

missing the TS part, pinging @SferaDev

@philkra philkra added sdk/python Python SDK (xata-py) sdk/typescript TypeScript SDK (client-ts) code-snippets Examples in code for Xata SDKs or others labels Apr 26, 2024
@philkra philkra requested a review from kostasb April 26, 2024 06:44
@xata-bot
Copy link

xata-bot commented Apr 26, 2024

Check out the preview at https://xata-docs-pr-331.vercel.app

@kostasb
Copy link
Contributor

kostasb commented Apr 26, 2024

LGTM, in JS/TS the file object itself carries the type in it which corresponds to content-type, so I believe we don't need any changes there. @SferaDev would know better though.

image

@philkra philkra merged commit 67aea15 into main Apr 26, 2024
5 checks passed
@philkra philkra deleted the issues-330-document-content-type-param branch April 26, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-snippets Examples in code for Xata SDKs or others sdk/python Python SDK (xata-py) sdk/typescript TypeScript SDK (client-ts)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document binary file content type parameter
3 participants