Skip to content

Commit 1836301

Browse files
committed
don't bother linking target dependencies
1 parent 9b4001c commit 1836301

File tree

2 files changed

+5
-26
lines changed

2 files changed

+5
-26
lines changed

Fixtures/TestProject/GeneratedProject.xcodeproj/project.pbxproj

Lines changed: 2 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,12 @@
1111
BF1462768401 = {isa = PBXBuildFile; fileRef = FR2653659501 /* TestProjectTests.xctest */; };
1212
BF1744565901 /* ViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = FR6218091901 /* ViewController.swift */; };
1313
BF1911148401 /* LaunchScreen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = VG6405436301 /* LaunchScreen.storyboard */; };
14-
BF2753556301 /* MyFramework.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = FR2993497801 /* MyFramework.framework */; };
14+
BF2753556301 = {isa = PBXBuildFile; fileRef = FR2993497801 /* MyFramework.framework */; };
1515
BF3154421201 /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = FR5980633301 /* Assets.xcassets */; };
1616
BF3515549501 /* MyFramework.h in Headers */ = {isa = PBXBuildFile; fileRef = FR7740960501 /* MyFramework.h */; settings = {ATTRIBUTES = (Public, ); }; };
1717
BF3862341101 = {isa = PBXBuildFile; fileRef = FR2993497801 /* MyFramework.framework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; };
1818
BF4946816301 /* Main.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = VG1473702401 /* Main.storyboard */; };
19-
BF5986511201 /* TestProject.app in Frameworks */ = {isa = PBXBuildFile; fileRef = FR6523263101 /* TestProject.app */; };
19+
BF5986511201 = {isa = PBXBuildFile; fileRef = FR6523263101 /* TestProject.app */; };
2020
BF9001417701 /* TestProjectTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = FR6877173101 /* TestProjectTests.swift */; };
2121
BF9155249601 /* FrameworkFile.swift in Sources */ = {isa = PBXBuildFile; fileRef = FR7078510801 /* FrameworkFile.swift */; };
2222
/* End PBXBuildFile section */
@@ -68,25 +68,6 @@
6868
FR7740960501 /* MyFramework.h */ = {isa = PBXFileReference; path = MyFramework.h; sourceTree = "<group>"; };
6969
/* End PBXFileReference section */
7070

71-
/* Begin PBXFrameworksBuildPhase section */
72-
FBP265365901 /* Frameworks */ = {
73-
isa = PBXFrameworksBuildPhase;
74-
buildActionMask = 2147483647;
75-
files = (
76-
BF5986511201 /* TestProject.app */,
77-
);
78-
runOnlyForDeploymentPostprocessing = 0;
79-
};
80-
FBP652326301 /* Frameworks */ = {
81-
isa = PBXFrameworksBuildPhase;
82-
buildActionMask = 2147483647;
83-
files = (
84-
BF2753556301 /* MyFramework.framework */,
85-
);
86-
runOnlyForDeploymentPostprocessing = 0;
87-
};
88-
/* End PBXFrameworksBuildPhase section */
89-
9071
/* Begin PBXGroup section */
9172
G26536595301 /* TestProjectTests */ = {
9273
isa = PBXGroup;
@@ -178,7 +159,6 @@
178159
SBP265365901 /* Sources */,
179160
RBP265365901 /* Resources */,
180161
HBP265365901 /* Headers */,
181-
FBP265365901 /* Frameworks */,
182162
);
183163
buildRules = (
184164
);
@@ -213,7 +193,6 @@
213193
SBP652326301 /* Sources */,
214194
RBP652326301 /* Resources */,
215195
HBP652326301 /* Headers */,
216-
FBP652326301 /* Frameworks */,
217196
CFBP50493301 /* Copy Files */,
218197
SSBP24648001 /* Run Script */,
219198
SSBP19207501 /* Run Script */,

Sources/XcodeGenKit/PBXProjGenerator.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -230,9 +230,9 @@ public class PBXProjGenerator {
230230
addObject(targetDependancy)
231231
dependancies.append(targetDependancy.reference)
232232

233-
let dependencyBuildFile = targetBuildFileReferences[dependencyTargetName]!
234-
// link
235-
targetFrameworkBuildFiles.append(dependencyBuildFile)
233+
// don't bother linking a target dependency
234+
// let dependencyBuildFile = targetBuildFileReferences[dependencyTargetName]!
235+
// targetFrameworkBuildFiles.append(dependencyBuildFile)
236236

237237
if embed {
238238
let embedSettings = dependancy.buildSettings

0 commit comments

Comments
 (0)