pgm 22.19, write dos newline as a string rather than 2 chars: this turned up a bug in clang

Author: twcamper

.gitignore

@@ -183,3 +183,4 @@ spec/parts-list-io-spec
 22/22.16-cp
 22/dos2unix
 22/unix2dos
+weird/compound-literal-string-parameter-clang-bug

22/22.19-convert-line-endings.c

@@ -109,10 +109,8 @@ static int detect_unix_newline(FILE *fp, bool *is_newline)
 
 static int write_dos_newline(FILE *fp)
 {
-  if (fputc(0x0D, fp) == EOF)
-    return EOF;
-
-  return fputc(0x0A, fp);
+  static char newline[] = {0x0D, 0x0A};
+  return fputs(newline, fp);
 }
 
 int main(int argc, char *argv[])

weird/compound-literal-string-parameter-clang-bug.c

@@ -0,0 +1,34 @@
+#include <stdio.h>
+
+/* 
+ * $ clang --version
+ * clang version 3.1 (branches/release_31)
+ * Target: x86_64-apple-darwin10.8.0
+ * Thread model: posix
+ */
+
+
+/*
+ * output without call to printf from within main:
+ *
+ * $ weird/compound-literal-string-parameter-clang-bug | xxd
+ * 0000000: 0d0a 20e7 bf5f ff7f                      .. .._..
+ * $ weird/compound-literal-string-parameter-clang-bug | wc
+ *        1       1       8
+ */
+
+/* works fine compiled with i686-apple-darwin10-gcc-4.2.1 (GCC) 4.2.1 */
+void  write_dos_newline()
+{
+  printf("%s", (char[2]){0x0D, 0x0A});
+}
+
+
+int main(void)
+{
+  /* call from main works as expected */
+  printf("%s", (char[2]){0x0D, 0x0A});
+  /* call via function appends 6 bytes of junk */
+  write_dos_newline();
+  return 0;
+}