Merge pull request kubernetes-sigs#2090 from alvaroaleman/started

🐛 Prevent manager from getting started a second time

Author: k8s-ci-robot

pkg/manager/internal.go

@@ -409,6 +409,8 @@ func (cm *controllerManager) Start(ctx context.Context) (err error) {
 		cm.Unlock()
 		return errors.New("manager already started")
 	}
+	cm.started = true
+
 	var ready bool
 	defer func() {
 		// Only unlock the manager if we haven't reached

pkg/manager/manager_test.go

@@ -1492,6 +1492,29 @@ var _ = Describe("manger.Manager", func() {
 			Expect(err).NotTo(HaveOccurred())
 			Expect(m.Add(&failRec{})).To(HaveOccurred())
 		})
+
+		It("should fail if attempted to start a second time", func() {
+			m, err := New(cfg, Options{})
+			Expect(err).NotTo(HaveOccurred())
+
+			ctx, cancel := context.WithCancel(context.Background())
+			defer cancel()
+			go func() {
+				defer GinkgoRecover()
+				Expect(m.Start(ctx)).NotTo(HaveOccurred())
+			}()
+			// Wait for the Manager to start
+			Eventually(func() bool {
+				mgr, ok := m.(*controllerManager)
+				Expect(ok).To(BeTrue())
+				return mgr.runnables.Caches.Started()
+			}).Should(BeTrue())
+
+			err = m.Start(ctx)
+			Expect(err).ToNot(BeNil())
+			Expect(err.Error()).To(Equal("manager already started"))
+
+		})
 	})
 	Describe("SetFields", func() {
 		It("should inject field values", func() {