Skip to content

Project panel: Support for drag cancel with escape #11887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
0x2CA opened this issue May 16, 2024 · 1 comment · Fixed by #30318
Closed

Project panel: Support for drag cancel with escape #11887

0x2CA opened this issue May 16, 2024 · 1 comment · Fixed by #30318
Labels
bite-size small issues project panel Feedback for files tree view

Comments

@0x2CA
Copy link
Contributor

0x2CA commented May 16, 2024 •
edited by notpeter
Loading

Summary

Support escape to cancel dragging and dropping folders in the project panel

Workaround: Dropping the file/folder into the editor/terminal are non-destructive operations.

Environment

Zed: v0.136.0 (Zed Preview)
OS: macOS 14.4.1
Memory: 32 GiB
Architecture: aarch64
@0x2CA 0x2CA added admin read bug [core label] labels May 16, 2024
@JosephTLyons JosephTLyons added project panel Feedback for files tree view and removed triage labels May 16, 2024
@github-actions github-actions bot mentioned this issue May 18, 2024
Open
@github-actions github-actions bot mentioned this issue Nov 5, 2024
Open
@notpeter
Copy link
Member

This seems super reasonable and what most users would expect.

@notpeter notpeter changed the title project panel directory Cancel drag Project panel: Support for drag cancel with escape Feb 24, 2025
@notpeter notpeter added bite-size small issues and removed bug [core label] labels Feb 24, 2025
@SomeoneToIgnore SomeoneToIgnore mentioned this issue May 8, 2025
Merged
SomeoneToIgnore added a commit that referenced this issue May 8, 2025
@SomeoneToIgnore
Use ESC to cancel dragging in Zed (#30318)
b4fbb9b 
Closes #11887

ESC is always captured in terminal due to 


https://github.com/zed-industries/zed/blob/980bfae331dd5078bbba9fe0f3993d9ad5ca6e29/crates/terminal/src/terminal.rs#L1339-L1353

so this part is not fixed.

Otherwise, all other drags are cancelled when ESC is pressed:


https://github.com/user-attachments/assets/6e70a1e5-c244-420b-9dec-ae2ac2997a59


Release Notes:

- Allowed to use ESC to cancel dragging in Zed
lj3954 pushed a commit to lj3954/zed that referenced this issue May 9, 2025
@SomeoneToIgnore @lj3954
Use ESC to cancel dragging in Zed (zed-industries#30318)
6a5af50 
Closes zed-industries#11887

ESC is always captured in terminal due to 


https://github.com/zed-industries/zed/blob/980bfae331dd5078bbba9fe0f3993d9ad5ca6e29/crates/terminal/src/terminal.rs#L1339-L1353

so this part is not fixed.

Otherwise, all other drags are cancelled when ESC is pressed:


https://github.com/user-attachments/assets/6e70a1e5-c244-420b-9dec-ae2ac2997a59


Release Notes:

- Allowed to use ESC to cancel dragging in Zed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bite-size small issues project panel Feedback for files tree view
Projects
No open projects
Quality Week Fall 2024
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use ESC to cancel dragging in Zed zed-industries/zed
3 participants
@notpeter @JosephTLyons @0x2CA