Non-existent filepath in terminal is briefly underlined when hovered #25110
Labels
terminal
Feedback for terminal integration, shell commands, etc
Comments
mgsloan
added
the
terminal
1 task
SomeoneToIgnore
added a commit
that referenced
this issue
May 7, 2025
Closes #25110 https://github.com/user-attachments/assets/4624c256-8dfb-48eb-a726-6cf130d946da Terminal may update its hovered word way before reporting it to the terminal view, and that processing the file check later. Hence, store the terminal hover data in the terminal view and avoid highlights when it's different from what the terminal has (as the source of truth here). In addition, now only does hover refreshes when the terminal hover actually changes, not on every event report. Release Notes: - Fixed underline flicker when switching cmd-hovered words in terminal
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this issue
May 8, 2025
Closes #25110 https://github.com/user-attachments/assets/4624c256-8dfb-48eb-a726-6cf130d946da Terminal may update its hovered word way before reporting it to the terminal view, and that processing the file check later. Hence, store the terminal hover data in the terminal view and avoid highlights when it's different from what the terminal has (as the source of truth here). In addition, now only does hover refreshes when the terminal hover actually changes, not on every event report. Release Notes: - Fixed underline flicker when switching cmd-hovered words in terminal
SomeoneToIgnore
added a commit
that referenced
this issue
May 8, 2025
…ick #30098) (#30206) Cherry-picked Do not flicker when switching cmd-hovered words in terminal (#30098) Closes #25110 https://github.com/user-attachments/assets/4624c256-8dfb-48eb-a726-6cf130d946da Terminal may update its hovered word way before reporting it to the terminal view, and that processing the file check later. Hence, store the terminal hover data in the terminal view and avoid highlights when it's different from what the terminal has (as the source of truth here). In addition, now only does hover refreshes when the terminal hover actually changes, not on every event report. Release Notes: - Fixed underline flicker when switching cmd-hovered words in terminal Co-authored-by: Kirill Bulatov <[email protected]>
lj3954
pushed a commit
to lj3954/zed
that referenced
this issue
May 9, 2025
…stries#30098) Closes zed-industries#25110 https://github.com/user-attachments/assets/4624c256-8dfb-48eb-a726-6cf130d946da Terminal may update its hovered word way before reporting it to the terminal view, and that processing the file check later. Hence, store the terminal hover data in the terminal view and avoid highlights when it's different from what the terminal has (as the source of truth here). In addition, now only does hover refreshes when the terminal hover actually changes, not on every event report. Release Notes: - Fixed underline flicker when switching cmd-hovered words in terminal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
@notpeter 's video from #19106 (comment)
Screen.Recording.2025-02-18.at.9.17.40.mov
For me the most reliable repro has been
echo Cargo.toml ../Cargo.tomland move my cursor between the twoZed Version and System Specs
N/A
The text was updated successfully, but these errors were encountered: