Skip to content

GatewayZEVM: Add a check for max gas limit in withdraw functions #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lumtis opened this issue Mar 14, 2025 · 1 comment
Open

GatewayZEVM: Add a check for max gas limit in withdraw functions #478

lumtis opened this issue Mar 14, 2025 · 1 comment
Labels
zevm Related to zevm smart contract module

Comments

@lumtis
Copy link
Member

lumtis commented Mar 14, 2025

There is max gas limit set at the ZetaClient side for the withdraw to avoid for example a bug that could deplete the TSS: https://github.com/zeta-chain/node/blob/e8cd199f562342ca63d4a3c877afdca71599d6c9/zetaclient/chains/evm/signer/gas.go#L70

If the user set a high gas limit, then they would pay more than what is used for signing the tx.

This limit should move set in the smart contract as well to make withdraw using this limit revert.

@kingpinXD
Copy link

Note : The gas limit should be on a per chain basis (based on the outbound chain )

@kingpinXD kingpinXD added the zevm Related to zevm smart contract module label Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
zevm Related to zevm smart contract module
Projects
None yet
Development

No branches or pull requests

2 participants