ft: allow async callbacks with Page.on calls (microsoft#353)

Author: Mattwmaster58

playwright/connection.py

@@ -18,14 +18,14 @@
 from typing import Any, Callable, Dict, Optional, Union
 
 from greenlet import greenlet
-from pyee import EventEmitter
+from pyee import AsyncIOEventEmitter
 
 from playwright.helper import ParsedMessagePayload, parse_error
 from playwright.sync_base import dispatcher_fiber
 from playwright.transport import Transport
 
 
-class Channel(EventEmitter):
+class Channel(AsyncIOEventEmitter):
     def __init__(self, connection: "Connection", guid: str) -> None:
         super().__init__()
         self._connection: Connection = connection
@@ -64,15 +64,15 @@ def send_no_reply(self, method: str, params: Dict = None) -> None:
         self._connection._send_message_to_server(self._guid, method, params)
 
 
-class ChannelOwner(EventEmitter):
+class ChannelOwner(AsyncIOEventEmitter):
     def __init__(
         self,
         parent: Union["ChannelOwner", "Connection"],
         type: str,
         guid: str,
         initializer: Dict,
     ) -> None:
-        super().__init__()
+        super().__init__(loop=parent._loop)
         self._loop: asyncio.AbstractEventLoop = parent._loop
         self._type = type
         self._guid = guid

tests/async/test_browsercontext.py

@@ -728,7 +728,7 @@ def handle_page(page):
         events.append("CREATED: " + page.url)
         page.on("close", lambda: events.append("DESTROYED: " + page.url))
 
-    context.on("page", lambda page: handle_page(page))
+    context.on("page", handle_page)
 
     page = await context.newPage()
     await page.goto(server.EMPTY_PAGE)

tests/async/test_dialog.py

@@ -22,12 +22,12 @@
 async def test_should_fire(page: Page, server):
     result = []
 
-    def on_dialog(dialog: Dialog):
+    async def on_dialog(dialog: Dialog):
         result.append(True)
         assert dialog.type == "alert"
         assert dialog.defaultValue == ""
         assert dialog.message == "yo"
-        asyncio.create_task(dialog.accept())
+        await dialog.accept()
 
     page.on("dialog", on_dialog)
     await page.evaluate("alert('yo')")
@@ -37,12 +37,12 @@ def on_dialog(dialog: Dialog):
 async def test_should_allow_accepting_prompts(page: Page, server):
     result = []
 
-    def on_dialog(dialog: Dialog):
+    async def on_dialog(dialog: Dialog):
         result.append(True)
         assert dialog.type == "prompt"
         assert dialog.defaultValue == "yes."
         assert dialog.message == "question?"
-        asyncio.create_task(dialog.accept("answer!"))
+        await dialog.accept("answer!")
 
     page.on("dialog", on_dialog)
     assert await page.evaluate("prompt('question?', 'yes.')") == "answer!"
@@ -52,9 +52,9 @@ def on_dialog(dialog: Dialog):
 async def test_should_dismiss_the_prompt(page: Page, server):
     result = []
 
-    def on_dialog(dialog: Dialog):
+    async def on_dialog(dialog: Dialog):
         result.append(True)
-        asyncio.create_task(dialog.dismiss())
+        await dialog.dismiss()
 
     page.on("dialog", on_dialog)
     assert await page.evaluate("prompt('question?')") is None
@@ -64,9 +64,9 @@ def on_dialog(dialog: Dialog):
 async def test_should_accept_the_confirm_prompt(page: Page, server):
     result = []
 
-    def on_dialog(dialog: Dialog):
+    async def on_dialog(dialog: Dialog):
         result.append(True)
-        asyncio.create_task(dialog.accept())
+        await dialog.accept()
 
     page.on("dialog", on_dialog)
     assert await page.evaluate("confirm('boolean?')") is True
@@ -76,9 +76,9 @@ def on_dialog(dialog: Dialog):
 async def test_should_dismiss_the_confirm_prompt(page: Page, server):
     result = []
 
-    def on_dialog(dialog: Dialog):
+    async def on_dialog(dialog: Dialog):
         result.append(True)
-        asyncio.create_task(dialog.dismiss())
+        await dialog.dismiss()
 
     page.on("dialog", on_dialog)
     assert await page.evaluate("confirm('boolean?')") is False