Version 2.9.0-15.0.dev

Merge commit '391d3bcdd861efde45bd77e9cbdce814cbda3762' into dev

Author: athomas

DEPS

@@ -44,11 +44,11 @@ vars = {
   # co19 is a cipd package. Use update.sh in tests/co19[_2] to update these
   # hashes. It requires access to the dart-build-access group, which EngProd
   # has.
-  "co19_rev": "9dacb12cf963ce92fb056b7f2fb87096fd576e9a",
+  "co19_rev": "c6adf63baea76b1f7e7833482eec023fd244fc33",
   "co19_2_rev": "620c1148c8b7a3d7f74afacf348c46f109eb64f2",
 
   # The internal benchmarks to use. See go/dart-benchmarks-internal
-  "benchmarks_internal_rev": "4f5285d3711ed4225d0bf5673379e7afdc6cb8e5",
+  "benchmarks_internal_rev": "6c5cf5ca4f29f0e498a9ad51146ccb2ad3bbd2b4",
   "checkout_benchmarks_internal": False,
 
   # As Flutter does, we use Fuchsia's GN and Clang toolchain. These revision
@@ -122,14 +122,14 @@ vars = {
   "mustache_rev": "664737ecad027e6b96d0d1e627257efa0e46fcb1",
   "oauth2_tag": "1.6.0",
   "package_config_rev": "9c586d04bd26fef01215fd10e7ab96a3050cfa64",
-  "path_rev": "4b8c83cd5ccfcc8101acd2940ffb5a44d24ec57e",
+  "path_rev": "4f3bb71843fe5493ba490828a1721821d7b33746",
   "pedantic_tag": "v1.9.0",
   "ply_rev": "604b32590ffad5cbb82e4afef1d305512d06ae93",
   "pool_rev": "86fbb2cde9bbc66c8d159909d2f65a5981ea5b50",
   "protobuf_rev": "3746c8fd3f2b0147623a8e3db89c3ff4330de760",
   "pub_rev": "6178cdf284baf2345d1ea578b7176a754aa576fe",
   "pub_semver_tag": "v1.4.4",
-  "quiver-dart_tag": "2.0.0+1",
+  "quiver-dart_tag": "246e754fe45cecb6aa5f3f13b4ed61037ff0d784",
   "resource_rev": "f8e37558a1c4f54550aa463b88a6a831e3e33cd6",
   "root_certificates_rev": "16ef64be64c7dfdff2b9f4b910726e635ccc519e",
   "rust_revision": "60960a260f7b5c695fd0717311d72ce62dd4eb43",
@@ -501,7 +501,7 @@ deps = {
       ],
       "dep_type": "cipd",
   },
-  Var("dart_root") + "/benchmarks/FfiCall/dart/native/out/": {
+  Var("dart_root") + "/benchmarks/FfiCall/native/out/": {
       "packages": [
           {
               "package": "dart/benchmarks/fficall",
@@ -559,21 +559,21 @@ hooks = [
     ],
   },
   {
-    # Pull Debian wheezy sysroot for i386 Linux
+    # Pull Debian sysroot for i386 Linux
     'name': 'sysroot_i386',
     'pattern': '.',
     'action': ['python', 'sdk/build/linux/sysroot_scripts/install-sysroot.py',
                '--arch', 'i386'],
   },
   {
-    # Pull Debian wheezy sysroot for amd64 Linux
+    # Pull Debian sysroot for amd64 Linux
     'name': 'sysroot_amd64',
     'pattern': '.',
     'action': ['python', 'sdk/build/linux/sysroot_scripts/install-sysroot.py',
                '--arch', 'amd64'],
   },
   {
-    # Pull Debian wheezy sysroot for arm Linux
+    # Pull Debian sysroot for arm Linux
     'name': 'sysroot_amd64',
     'pattern': '.',
     'action': ['python', 'sdk/build/linux/sysroot_scripts/install-sysroot.py',

PRESUBMIT.py

@@ -67,16 +67,19 @@ def _CheckNnbdTestSync(input_api, output_api):
     a test, the test's counterpart (if it exists at all) should be in the CL
     too.
     """
-    DIRS = ["co19", "corelib", "ffi", "language", "lib", "standalone"]
+    DIRS = [
+        "tests/co19", "tests/corelib", "tests/ffi", "tests/language",
+        "tests/lib", "tests/standalone", "runtime/tests/vm/dart"
+    ]
 
     files = [git_file.LocalPath() for git_file in input_api.AffectedTextFiles()]
     unsynchronized = []
     for file in files:
         if file.endswith('.status'): continue
 
         for dir in DIRS:
-            legacy_dir = "tests/{}_2/".format(dir)
-            nnbd_dir = "tests/{}/".format(dir)
+            legacy_dir = "{}_2/".format(dir)
+            nnbd_dir = "{}/".format(dir)
 
             counterpart = None
             if file.startswith(legacy_dir):

benchmarks/BigIntParsePrint/dart/BigIntParsePrint.dart

@@ -2,6 +2,8 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+// ignore_for_file: avoid_function_literals_in_foreach_calls
+
 import 'package:benchmark_harness/benchmark_harness.dart';
 import 'package:fixnum/fixnum.dart';
 
@@ -38,23 +40,25 @@ class ParseBigIntBenchmark extends BenchmarkBase {
       : seed = (BigInt.one << bits) - BigInt.one,
         super(name);
 
+  @override
   void setup() {
-    BigInt b = seed;
-    int totalLength = 0;
+    var b = seed;
+    var totalLength = 0;
     while (totalLength < requiredDigits) {
       if (b.bitLength < bits) {
         b = seed;
       }
-      String string = b.toString();
+      final string = b.toString();
       strings.add(string);
       totalLength += string.length;
       b = b - (b >> 8);
     }
   }
 
+  @override
   void run() {
-    for (String s in strings) {
-      BigInt b = BigInt.parse(s);
+    for (final s in strings) {
+      final b = BigInt.parse(s);
       sink1 = s;
       sink2 = b;
     }
@@ -73,23 +77,25 @@ class ParseInt64Benchmark extends BenchmarkBase {
       : seed = (Int64.ONE << bits) - Int64.ONE,
         super(name);
 
+  @override
   void setup() {
-    Int64 b = seed;
-    int totalLength = 0;
+    var b = seed;
+    var totalLength = 0;
     while (totalLength < requiredDigits) {
       if (int64UnsignedBitLength(b) < bits) {
         b = seed;
       }
-      String string = b.toStringUnsigned();
+      final string = b.toStringUnsigned();
       strings.add(string);
       totalLength += string.length;
       b = b - b.shiftRightUnsigned(8);
     }
   }
 
+  @override
   void run() {
-    for (String s in strings) {
-      Int64 b = Int64.parseInt(s);
+    for (final s in strings) {
+      final b = Int64.parseInt(s);
       sink1 = s;
       sink2 = b;
     }
@@ -109,24 +115,26 @@ class ParseJsBigIntBenchmark extends BenchmarkBase {
             nativeBigInt.one),
         super(name);
 
+  @override
   void setup() {
-    Object b = seed;
-    int totalLength = 0;
+    var b = seed;
+    var totalLength = 0;
     while (totalLength < requiredDigits) {
       if (nativeBigInt.bitLength(b) < bits) {
         b = seed;
       }
-      String string = nativeBigInt.toStringMethod(b);
+      final string = nativeBigInt.toStringMethod(b);
       strings.add(string);
       totalLength += string.length;
       b = nativeBigInt.subtract(
           b, nativeBigInt.shiftRight(b, nativeBigInt.eight));
     }
   }
 
+  @override
   void run() {
-    for (String s in strings) {
-      Object b = nativeBigInt.parse(s);
+    for (final s in strings) {
+      final b = nativeBigInt.parse(s);
       sink1 = s;
       sink2 = b;
     }
@@ -143,26 +151,28 @@ class FormatBigIntBenchmark extends BenchmarkBase {
       : seed = (BigInt.one << bits) - BigInt.one,
         super(name);
 
+  @override
   void setup() {
-    BigInt b = seed;
-    int totalLength = 0;
+    var b = seed;
+    var totalLength = 0;
     while (totalLength < requiredDigits) {
       if (b.bitLength < bits) {
         b = seed;
       }
-      String string = b.toString();
+      final string = b.toString();
       values.add(b - BigInt.one); // We add 'one' back later.
       totalLength += string.length;
       b = b - (b >> 8);
     }
   }
 
+  @override
   void run() {
-    for (BigInt b0 in values) {
+    for (final b0 in values) {
       // Instances might cache `toString()`, so use arithmetic to create a new
       // instance to try to protect against measuring a cached string.
-      BigInt b = b0 + BigInt.one;
-      String s = b.toString();
+      final b = b0 + BigInt.one;
+      final s = b.toString();
       sink1 = s;
       sink2 = b;
     }
@@ -179,26 +189,28 @@ class FormatInt64Benchmark extends BenchmarkBase {
       : seed = (Int64.ONE << bits) - Int64.ONE,
         super(name);
 
+  @override
   void setup() {
-    Int64 b = seed;
-    int totalLength = 0;
+    var b = seed;
+    var totalLength = 0;
     while (totalLength < requiredDigits) {
       if (int64UnsignedBitLength(b) < bits) {
         b = seed;
       }
-      String string = b.toStringUnsigned();
+      final string = b.toStringUnsigned();
       values.add(b - Int64.ONE);
       totalLength += string.length;
       b = b - b.shiftRightUnsigned(8);
     }
   }
 
+  @override
   void run() {
-    for (Int64 b0 in values) {
+    for (final b0 in values) {
       // Instances might cache `toString()`, so use arithmetic to create a new
       // instance to try to protect against measuring a cached string.
-      Int64 b = b0 + Int64.ONE;
-      String s = b.toStringUnsigned();
+      final b = b0 + Int64.ONE;
+      final s = b.toStringUnsigned();
       sink1 = s;
       sink2 = b;
     }
@@ -218,29 +230,31 @@ class FormatJsBigIntBenchmark extends BenchmarkBase {
             nativeBigInt.one),
         super(name);
 
+  @override
   void setup() {
     final one = nativeBigInt.one;
-    Object b = seed;
-    int totalLength = 0;
+    var b = seed;
+    var totalLength = 0;
     while (totalLength < requiredDigits) {
       if (nativeBigInt.bitLength(b) < bits) {
         b = seed;
       }
-      String string = nativeBigInt.toStringMethod(b);
+      final string = nativeBigInt.toStringMethod(b);
       values.add(nativeBigInt.subtract(b, one)); // We add 'one' back later.
       totalLength += string.length;
       b = nativeBigInt.subtract(
           b, nativeBigInt.shiftRight(b, nativeBigInt.eight));
     }
   }
 
+  @override
   void run() {
     final one = nativeBigInt.one;
-    for (Object b0 in values) {
+    for (final b0 in values) {
       // Instances might cache `toString()`, so use arithmetic to create a new
       // instance to try to protect against measuring a cached string.
-      Object b = nativeBigInt.add(b0, one);
-      String s = nativeBigInt.toStringMethod(b);
+      final b = nativeBigInt.add(b0, one);
+      final s = nativeBigInt.toStringMethod(b);
       sink1 = s;
       sink2 = b;
     }
@@ -251,6 +265,7 @@ class FormatJsBigIntBenchmark extends BenchmarkBase {
 /// [DummyBenchmark] instantly returns a fixed 'slow' result.
 class DummyBenchmark extends BenchmarkBase {
   DummyBenchmark(String name) : super(name);
+  @override
   double measure() => 2000 * 1000 * 1.0; // A rate of one run per 2s.
 }
 
@@ -274,7 +289,7 @@ BenchmarkBase Function() selectFormatNativeBigIntBenchmark(
       : () => DummyBenchmark(name);
 }
 
-main() {
+void main() {
   final benchmarks = [
     () => ParseInt64Benchmark('Int64.parse.0009.bits', 9),
     () => ParseInt64Benchmark('Int64.parse.0032.bits', 32),

benchmarks/BigIntParsePrint/dart/native_version_dummy.dart

@@ -9,23 +9,41 @@ const NativeBigIntMethods nativeBigInt = _DummyMethods();
 class _DummyMethods implements NativeBigIntMethods {
   const _DummyMethods();
 
+  @override
   bool get enabled => false;
 
   static Object bad(String message) => UnimplementedError(message);
 
+  @override
   Object parse(String string) => throw bad('parse');
+
+  @override
   String toStringMethod(Object value) => throw bad('toStringMethod');
 
+  @override
   Object fromInt(int i) => throw bad('fromInt');
 
+  @override
   Object get one => throw bad('one');
+
+  @override
   Object get eight => throw bad('eight');
 
+  @override
   int bitLength(Object value) => throw bad('bitLength');
+
+  @override
   bool isEven(Object value) => throw bad('isEven');
 
+  @override
   Object add(Object left, Object right) => throw bad('add');
+
+  @override
   Object shiftLeft(Object value, Object count) => throw bad('shiftLeft');
+
+  @override
   Object shiftRight(Object value, Object count) => throw bad('shiftRight');
+
+  @override
   Object subtract(Object left, Object right) => throw bad('subtract');
 }