Skip to content

Commit 692e497

Browse files
committed
chore: bump version of spring-cloud-xxxx. Remove obsolete zipkin module.
1 parent d1790e5 commit 692e497

File tree

12 files changed

+6
-334
lines changed

12 files changed

+6
-334
lines changed

README.md

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
- [Transparency](#transparency) *(it is transparent whether the code runs in or outside of Kubernetes)*
1717
- [Kubernetes Profile Autoconfiguration](#kubernetes-profile-autoconfiguration)
1818
- [Ribbon discovery in Kubernetes](#ribbon-discovery-in-kubernetes)
19-
- [Zipkin discovery in Kubernetes](#zipkin-discovery-in-kubernetes)
2019
- [ConfigMap Archaius Bridge](#configmap-archaius-bridge)
2120

2221
---
@@ -527,33 +526,6 @@ Examples that are using this module for ribbon discovery are:
527526
Remark : The Ribbon discovery client can be disabled by setting this key within the application properties file
528527
`spring.cloud.kubernetes.ribbon.enabled=false`.
529528

530-
531-
### Zipkin discovery in Kubernetes
532-
533-
[![Maven Central](https://maven-badges.herokuapp.com/maven-central/org.springframework.cloud/spring-cloud-starter-kubernetes-zipkin/badge.svg?style=flat-square)](https://maven-badges.herokuapp.com/maven-central/org.springframework.cloud/spring-cloud-starter-kubernetes-zipkin/)
534-
[![Javadocs](http://www.javadoc.io/badge/org.springframework.cloud/spring-cloud-starter-kubernetes-zipkin.svg?color=blue)](http://www.javadoc.io/doc/org.springframework.cloud/spring-cloud-starter-kubernetes-zipkin)
535-
[![Dependency Status](https://www.versioneye.com/java/org.springframework.cloud:spring-cloud-starter-kubernetes-zipkin/badge?style=flat)](https://www.versioneye.com/java/org.springframework.cloud:spring-cloud-starter-kubernetes-zipkin/)
536-
537-
[Zipkin](https://github.com/openzipkin/zipkin) is a distributed tracing system which is supported by the project
538-
[Spring Cloud Sleuth](https://github.com/spring-cloud/spring-cloud-sleuth) which allows
539-
to collect traces or spans from microservice applications.
540-
541-
A Discovery client has been implemented top of Kubernetes in order to fetch the Zipkin service (e.g. `zipkin`). This
542-
client is provided by the [spring-cloud-kubernetes-zipkin](spring-cloud-kubernetes-zipkin/pom.xml) project that you
543-
can use by adding this starter to your maven pom file:
544-
545-
```xml
546-
<dependency>
547-
<groupId>org.springframework.cloud</groupId>
548-
<artifactId>spring-cloud-starter-kubernetes-zipkin</artifactId>
549-
<version>${latest.version}</version>
550-
</dependency>
551-
```
552-
553-
This works as an extension of the [spring-cloud-sleuth-zipkin](https://github.com/spring-cloud/spring-cloud-sleuth/tree/master/spring-cloud-sleuth-zipkin) project.
554-
The name of the Zipkin service and the target Kubernetes namespace/project where the service runs can be specified
555-
using the following `application.properties` properties:
556-
557529
```bash
558530
spring.cloud.kubernetes.zipkin.discovery.serviceName=my-zipkin
559531
spring.cloud.kubernetes.zipkin.discovery.serviceNamespace=tracing

pom.xml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,9 @@
5959

6060
<properties>
6161
<!-- Dependency Versions -->
62-
<spring-cloud-commons.version>1.2.3.RELEASE</spring-cloud-commons.version>
63-
<spring-cloud-netflix.version>1.3.2.RELEASE</spring-cloud-netflix.version>
64-
<spring-cloud-sleuth.version>1.2.2.RELEASE</spring-cloud-sleuth.version>
62+
<spring-cloud-commons.version>1.3.5.RELEASE</spring-cloud-commons.version>
63+
<spring-cloud-netflix.version>1.4.6.RELEASE</spring-cloud-netflix.version>
64+
<spring-cloud-sleuth.version>1.3.5.RELEASE</spring-cloud-sleuth.version>
6565

6666
<!-- Maven Plugin Versions -->
6767
<maven-compiler-plugin.version>3.5</maven-compiler-plugin.version>
@@ -78,13 +78,11 @@
7878
<module>spring-cloud-kubernetes-config</module>
7979
<module>spring-cloud-kubernetes-discovery</module>
8080
<module>spring-cloud-kubernetes-ribbon</module>
81-
<module>spring-cloud-kubernetes-zipkin</module>
8281
<module>spring-cloud-kubernetes-hystrix</module>
8382
<module>spring-cloud-kubernetes-archaius</module>
8483
<module>spring-cloud-starter-kubernetes</module>
8584
<module>spring-cloud-starter-kubernetes-config</module>
8685
<module>spring-cloud-starter-kubernetes-netflix</module>
87-
<module>spring-cloud-starter-kubernetes-zipkin</module>
8886
<module>spring-cloud-starter-kubernetes-ribbon</module>
8987
<module>spring-cloud-starter-kubernetes-all</module>
9088
<module>spring-cloud-kubernetes-examples</module>

spring-cloud-kubernetes-examples/kubernetes-zipkin-example/pom.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,10 +87,6 @@
8787
</dependency>
8888

8989
<!-- Zipkin -->
90-
<dependency>
91-
<groupId>org.springframework.cloud</groupId>
92-
<artifactId>spring-cloud-kubernetes-zipkin</artifactId>
93-
</dependency>
9490
<dependency>
9591
<groupId>org.springframework.cloud</groupId>
9692
<artifactId>spring-cloud-sleuth-zipkin</artifactId>

spring-cloud-kubernetes-examples/kubernetes-zipkin-example/src/main/java/org/springframework/cloud/kubernetes/examples/ZipkinApplication.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@
2121
import org.apache.commons.logging.LogFactory;
2222
import org.springframework.boot.SpringApplication;
2323
import org.springframework.boot.autoconfigure.SpringBootApplication;
24-
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
25-
import org.springframework.cloud.sleuth.zipkin.ZipkinSpanReporter;
2624
import org.springframework.context.annotation.Bean;
2725
import org.springframework.context.annotation.EnableAspectJAutoProxy;
2826
import org.springframework.scheduling.annotation.EnableAsync;

spring-cloud-kubernetes-examples/kubernetes-zipkin-example/src/main/resources/application.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ spring:
55
sleuth:
66
sampler:
77
percentage: 1.0
8+
zipkin:
9+
# Assuming that zipkinserver is the service name of zipkin server.
10+
baseUrl: http://zipkinserver
811

912
sample:
1013
zipkin:

spring-cloud-kubernetes-zipkin/.jdk8

Whitespace-only changes.

spring-cloud-kubernetes-zipkin/pom.xml

Lines changed: 0 additions & 67 deletions
This file was deleted.

spring-cloud-kubernetes-zipkin/src/main/java/org/springframework/cloud/kubernetes/zipkin/KubernetesZipkinDiscoveryProperties.java

Lines changed: 0 additions & 53 deletions
This file was deleted.

spring-cloud-kubernetes-zipkin/src/main/java/org/springframework/cloud/kubernetes/zipkin/ZipkinKubernetesAutoConfiguration.java

Lines changed: 0 additions & 97 deletions
This file was deleted.

spring-cloud-kubernetes-zipkin/src/main/resources/META-INF/spring.factories

Lines changed: 0 additions & 2 deletions
This file was deleted.

spring-cloud-starter-kubernetes-all/pom.xml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -61,16 +61,6 @@
6161
<artifactId>spring-cloud-kubernetes-hystrix</artifactId>
6262
</dependency>
6363

64-
<dependency>
65-
<groupId>org.springframework.cloud</groupId>
66-
<artifactId>spring-cloud-kubernetes-zipkin</artifactId>
67-
</dependency>
68-
69-
<dependency>
70-
<groupId>org.springframework.cloud</groupId>
71-
<artifactId>spring-cloud-sleuth-zipkin</artifactId>
72-
</dependency>
73-
7464
<dependency>
7565
<groupId>org.aspectj</groupId>
7666
<artifactId>aspectjweaver</artifactId>

0 commit comments

Comments
 (0)