Project

General

Profile

Activity

From 04/01/2011 to 04/07/2011

04/07/2011

10:23 PM Bug #4558: TestSocket#test_closed_read fails after r31230
=begin
> ----------------------------------------
> Bug #4558: TestSocket#test_closed_read fails after r31230
> http://redmine.ruby-lang.org/issues/4558

I think current rb_io_close() is broken. We have to call rb_thread_fd_clos...
kosaki (Motohiro KOSAKI)
12:53 AM Bug #4558 (Closed): TestSocket#test_closed_read fails after r31230
=begin
After r31230, make test-all reports a failure in test_socket.rb @Mac OS X 10.6.6
% make test-all TESTS=../ruby/test/socket/test_socket.rb
./miniruby -I../ruby/lib -I. -I.ext/common ../ruby/tool/runruby.rb --extout=.ext --...
nagachika (Tomoyuki Chikanaga)
03:27 PM Bug #4561 (Assigned): 1.9.2 requires parentheses around argument of method call in an array, where 1.8.7 did not
=begin
=end
naruse (Yui NARUSE)
01:47 PM Bug #4561: 1.9.2 requires parentheses around argument of method call in an array, where 1.8.7 did not
=begin
Same thing with pre formatting:

[dave hladik:~] cat method_call_without_parens_in_array.rb
def method_name(arg)
end
[ method_name 'value' ]
[dave hladik:~] rvm system
[dave hladik:~] ruby -v
ruby 1.8.7 (2011-02-18 patc...
dschweisguth (Dave Schweisguth)
01:41 PM Bug #4561 (Closed): 1.9.2 requires parentheses around argument of method call in an array, where 1.8.7 did not
[dave hladik:~] cat method_call_without_parens_in_array.rb
def method_name(arg)
end
[ method_name 'value' ]
[dave hladik:~] ruby -v
ruby 1.8.7 (2011-02-18 patchlevel 334) [i686-darwin10]
[dave hladik:~] ruby method_call_without_...
dschweisguth (Dave Schweisguth)
11:48 AM Feature #4560 (Closed): [PATCH] lib/net/protocol.rb: avoid exceptions in rbuf_fill
Blindly hitting IO#read_nonblock() and raising is expensive due
to two factors:
1) method cache being scanned/cleared when the IO::WaitReadable
extended class is GC-ed
2) backtrace generation
This reduces the likelyhood of an IO...
normalperson (Eric Wong)
11:44 AM Bug #4289: Timeouts in threads cause SEGV
=begin
0002-error.c-rb_mod_sys_fail-use-subclass-and-cache.patch breaks
existing test cases that use assert_raise/assert_raises. This
may be a dealbreaker for the patch, unfortunately...
Actual code that uses "rescue Errno::EAGAIN"...
normalperson (Eric Wong)
10:55 AM Bug #4289: Timeouts in threads cause SEGV
=begin
I noticed 0002-error.c-rb_mod_sys_fail-use-subclass-and-cache.patch breaks on latest trunk, actually.
=end
normalperson (Eric Wong)
08:45 AM Bug #4289: Timeouts in threads cause SEGV
=begin
Attached are patches to revert r29673 and instate the rb_mod_sys_fail class cache I proposed in [ruby-core:32508]
=end
normalperson (Eric Wong)
11:04 AM Revision 4ca9e7d0 (git): * 2011-04-07
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31247 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
11:04 AM Revision e6ef26ae (git): * include/ruby/io.h: parenthesize macro arguments.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31246 b2dd03c8-39d4-4d8f-98ff-823fe69b080e akr (Akira Tanaka)
05:07 AM Bug #4559 (Closed): Proc#== does not match the documented behaviour
=begin
To see a paste concisely showing the problem, see https://gist.github.com/899026/ba84d66b02727675320dc4f031637d753a41c209
Code is shown below for 1.9.2p180.
The documented behaviour (and my own expectation for (({#==}))) is...
aprescott (Adam Prescott)

04/06/2011

09:07 PM Bug #4473: Calling return within begin still executes else
=begin
I can see the same issue happening on Windows also.
=end
mayank.kohaley (Mayank Kohaley)
07:56 PM Bug #4549: Can't start class names with non us-ascii chars
=begin
I beg the differ! ÅÄÖ are all uppercase letters, as oppose to åäö, in the Swedish alphabet.
The problem this is occurring for us is that we can't the name the objects in your domain model correctly. We don't wan't to translate i...
carl.hoerberg (Carl Hörberg)
04:48 PM Bug #4549 (Rejected): Can't start class names with non us-ascii chars
=begin
It is because Å is not a uppercase letter.
=end
naruse (Yui NARUSE)
02:21 PM Feature #4551: uri.set_scheme should downcase schemes
=begin
Your point is reasonable, but it breaks some cases like
s = 'HTTP://example.com/'
URI(s).to_s == s
=end
naruse (Yui NARUSE)
01:12 PM Feature #4556: Please add option which enable SSLv2 support
=begin
Sorry, The first patch is broken.
I attched new patch.
=end
iwamatsu (Nobuhiro Iwamatsu)
12:58 PM Feature #4556 (Closed): Please add option which enable SSLv2 support
=begin
SSLv2 becomes disabled in much environment, because this has several vulnerabilities.
This patch disable SSLv2 in Ruby.
If user want to use SSLv2 in ruby, you need config with --enable-opensslv2.
The SSLv2 support is disable b...
iwamatsu (Nobuhiro Iwamatsu)
01:03 PM Bug #4550 (Closed): Loading an RSA public key during an HTTPS connection corrupts the connection
=begin
This issue was solved with changeset r31242.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
=end
naruse (Yui NARUSE)
12:08 PM Revision d55cf835 (git): * include/ruby/intern.h: parenthesize macro arguments.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31245 b2dd03c8-39d4-4d8f-98ff-823fe69b080e akr (Akira Tanaka)
09:23 AM Bug #4289: Timeouts in threads cause SEGV
=begin
Motohiro KOSAKI wrote:
> Running deadlock_test.rb in [Bug#4266] on trunk makes segfault. git bisect indicate
> first bad commit is below.
>
> --------------------------------------------------------------------------...
normalperson (Eric Wong)
09:18 AM Bug #4289: Timeouts in threads cause SEGV
=begin
also see
((<[ruby-core:35622]|URL:http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/35622>))
(redmine doesn't seem to handle mail replies correctly)
=end
normalperson (Eric Wong)
07:36 AM Bug #4289: Timeouts in threads cause SEGV
=begin
Hiding, but not fixing the issue is the attached patch:
[PATCH] timeout.rb: avoid introducing new class for every timeout
This is expensive because of clearing the method cache upon GC.
As a side effect, it also seems to ...
normalperson (Eric Wong)
08:13 AM Bug #4555 (Closed): [PATCH] ext/socket/init.c: rsock_connect retries on interrupt
=begin
Otherwise I get the following error in test/openssl/test_ssl.rb:
test_verify_result(OpenSSL::TestSSL):
Errno::EINTR: Interrupted system call - connect(2)
/tmp/ruby/test/openssl/test_ssl.rb:338:in `initialize'
...
normalperson (Eric Wong)
07:42 AM Bug #4266: Timeouts in threads cause "ThreadError: deadlock; recursive locking"
=begin
I have a short-term fix for the related issue in Bug #4289
http://redmine.ruby-lang.org/attachments/1572/0001-timeout.rb-avoid-introducing-new-class-for-every-tim.patch
It works both with and without the mutex-synchronize-use-...
normalperson (Eric Wong)
06:14 AM Revision d5b1fde5 (git): * ext/openssl/ossl_pkey_dh.c (ossl_dh_initialize):
pop pushed error after each try of reading. fixes #4550
* ext/openssl/ossl_pkey_dsa.c (ossl_dsa_initialize): ditto.
* ext/openssl/ossl_pkey_ec.c (ossl_ec_initialize): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31244 b2dd...
naruse (Yui NARUSE)
02:44 AM Revision 6fc7c377 (git): * 2011-04-06
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31243 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
02:44 AM Revision e61d269f (git): * ext/openssl/ossl_pkey_rsa.c (ossl_rsa_initialize):
pop pushed error after each try of reading. fixes #4550
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31242 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
naruse (Yui NARUSE)

04/05/2011

08:23 PM Feature #4539: Array#zip_with
> http://redmine.ruby-lang.org/issues/4539
> ...
Hello,
I'm answering here since redmine won't answer to my requests (even got a 500).
I think this new method would be redundant with `Array#zip`.
But I agree doing `c.zip(d).map {...
Eregon (Benoit Daloze)
03:55 PM Feature #4539 (Assigned): Array#zip_with
naruse (Yui NARUSE)
04:04 PM Feature #4541 (Assigned): Inconsistent Array.slice()
The fix may be following but it can be a spec...
```diff
diff --git a/array.c b/array.c
index bdeb768..4721387 100644
--- a/array.c
+++ b/array.c
@@ -948,7 +948,7 @@ rb_ary_subseq(VALUE ary, long beg, long len)
{
VALUE kl...
naruse (Yui NARUSE)
03:56 PM Bug #4530 (Rejected): trunk "make check" gives "cannot load such file -- zlib" and "cannot load such file -- openssl"
=begin
You seem don't install zlib-dev/readline-dev or something.
=end
naruse (Yui NARUSE)
02:33 PM Bug #4554 (Closed): test_set_errors in test_x509store.rb fails on CentOS 5.5
=begin
On CentOS 5.5, test_set_errors in test_x509store.rb fails as follows:
1.9.2 p180
1) Failure:
test_set_errors(OpenSSL::TestX509Store) [/var/home/yhara/ruby-1.9.2-p180/test/openssl/test_x509store.rb:212]:
OpenSSL::X509...
yhara (Yutaka HARA)
11:34 AM Revision a63105a4 (git): * include/ruby/encoding.h: parenthesize macro arguments.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31241 b2dd03c8-39d4-4d8f-98ff-823fe69b080e akr (Akira Tanaka)
08:10 AM Feature #4553 (Rejected): Add Set#pick and Set#pop
=begin
A very common operation on sets is to take an arbitrary element from them at O(1) cost. I know typically
it's suggested that library additions go out as a gem to see community review. However, to me it seems
to be a glaring omi...
adgar (Michael Edgar)
05:07 AM Bug #4501: 1.9.2-p180 fails to compile on OSX 10.7
=begin
First, make sure you’ve installed XCode 4.1 DP 2 (you can download it through Apple if you are enrolled in their developer program)
Next, add the following to your ~/.bash_profile with your favorite editor
export CC=/Develope...
baldwin (Stephen Baldwin)
04:23 AM Bug #4527: [PATCH] IO#close releases GVL if possible
Motohiro KOSAKI <[email protected]> wrote:
> Eric, I commited slightly modified version because your patch couldn't
> ...

Thanks, looks like you missed the following hunk in rb_io_reopen():
~~~diff
diff --git a/io.c b/i...
normalperson (Eric Wong)
04:05 AM Revision 42caa6dd (git): * 2011-04-05
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31240 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
04:05 AM Revision 257f7859 (git): fix a typo
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31239 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
03:23 AM Feature #4538: [PATCH (cleanup)] avoid unnecessary select() calls before doing I/O
=begin
Charles Oliver Nutter <[email protected]> wrote:
> On Fri, Apr 1, 2011 at 4:57 PM, Eric Wong <[email protected]> wrote:
> > Charles Nutter <[email protected]> wrote:
> >> I wonder, though, if depending on this behav...
normalperson (Eric Wong)

04/04/2011

10:58 PM Bug #4509: Net::IMAP::ResponseParseError: unexpected token CRLF (expected NUMBER)
=begin
=== Better steps to repro
I created a free account on yahoo to reproduce this error. Now, you can repro with these steps:
require 'net/imap'
conn = Net::IMAP.new('imap.mail.yahoo.com', 143, false)
conn.instance_eval { se...
digger69 (Mark Nadig)
10:40 PM Bug #4509: Net::IMAP::ResponseParseError: unexpected token CRLF (expected NUMBER)
=begin
(({def a # test - why "Error: file empty." in bug report}))
=end
digger69 (Mark Nadig)
10:34 PM Bug #4509: Net::IMAP::ResponseParseError: unexpected token CRLF (expected NUMBER)
=begin
=== Better steps to repro
I created a free account on yahoo to reproduce this error. Now, you can repro with these steps:
(({require 'net/imap'
conn = Net::IMAP.new('imap.mail.yahoo.com', 143, false)
conn.instance_...
digger69 (Mark Nadig)
07:12 PM Feature #4532 (Assigned): [PATCH] add IO#pread and IO#pwrite methods
Hi
I personally still dislike pread/pwrite method name, but I give up to argue it because I'm worry about making endless discussion. Let's assign this ticket to matz and hear his opinions. :)
kosaki (Motohiro KOSAKI)
07:07 PM Bug #4500 (Closed): warning: implicit declaration of function 'fdatasync' for OS X
=begin
=end
kosaki (Motohiro KOSAKI)
01:11 PM Revision 78ea7afe (git): * ext/io/nonblock/nonblock.c (io_nonblock_set): Avoid F_SETFL if
we're not changing the O_NONBLOCK bit. F_SETFL is an expensive
operation since it needs to affect all processes with the same
file object.
The patch is written by Eric Wong. [ruby-core:35556]
git-svn-id: svn+ssh://ci.ruby-lang.o...
kosaki (Motohiro KOSAKI)
12:43 PM Revision 3ba502d5 (git): * io.c (rb_io_syswrite): While local FS writes are usually
buffered, the buffers can be full or the file opened with
O_SYNC. IO#syswrite can also be used on blocking IOs
(pipe/socket) just like IO#write.
The patch is written by Eric Wong. [ruby-core:35554]
git-svn-id: svn+ssh://ci.ruby-...
kosaki (Motohiro KOSAKI)
07:35 AM Feature #4551 (Closed): uri.set_scheme should downcase schemes
=begin
From RFC 2396 section 3.1:
"For resiliency, programs interpreting URI should treat upper case letters as equivalent to lower case in scheme names (e.g., allow 'HTTP' as well as 'http')."
Currently programs using URI for HTT...
drbrain (Eric Hodel)
05:20 AM Bug #4550 (Closed): Loading an RSA public key during an HTTPS connection corrupts the connection
=begin
The attached file creates an HTTPS connection to gmail.com then loads an RSA public key.
If a private key is loaded the error does not reproduce.
Loading of the public key corrupts the HTTPS connection resulting in the follo...
drbrain (Eric Hodel)
02:51 AM Revision b36f8e6e (git): * 2011-04-04
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31236 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
02:51 AM Revision 8eb92a67 (git): * test/test_tempfile.rb: simply ignore platform depedent testcases
instead of skipping.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31235 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
U.Nakamura

04/03/2011

11:36 PM Bug #4545 (Closed): [PATCH] syslog extension documentation improvements and fixes
=begin
I've committed in r31234.
=end
nagachika (Tomoyuki Chikanaga)
10:45 PM Bug #4545: [PATCH] syslog extension documentation improvements and fixes
=begin
Thank you for your patch. It seems good for me.
But I've found a typo: "a shotcut method" -> "a shortcut method". right?
I'll check in it later with fix a typo.
Thnaks again.
=end
nagachika (Tomoyuki Chikanaga)
09:33 PM Bug #4500 (Assigned): warning: implicit declaration of function 'fdatasync' for OS X
=begin
To be honest, I'm not sure Apple's system function support policy. But I'm sure your suggestions were right in past. Then, I'll commit this proposal as is.
Thanks.
=end
kosaki (Motohiro KOSAKI)
09:25 PM Bug #4527 (Closed): [PATCH] IO#close releases GVL if possible
Eric, I commited slightly modified version because your patch couldn't apply for latest trunk. Could you please confirm it?
kosaki (Motohiro KOSAKI)
01:58 PM Revision 6a06e940 (git): * ext/syslog/syslog.c: improve rdoc.
a patch by Jonas Pfenniger. [ruby-core:35592] fixes #4545
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31234 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nagachika (Tomoyuki Chikanaga)
01:10 PM Revision 11b1f4ff (git): * ext/zlib/zlib.c: parenthesize macro arguments.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31233 b2dd03c8-39d4-4d8f-98ff-823fe69b080e akr (Akira Tanaka)
12:35 PM Revision f4755f21 (git): * configure.in: disable fdatasync again on Mac OS X.
[ruby-core:35493][Bug #4500]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31232 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
kosaki (Motohiro KOSAKI)
12:24 PM Revision 34c46a67 (git): * 2011-04-03
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31231 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
12:23 PM Revision f35a7770 (git): * io.c (io_reopen): IO#close releases GVL if possible.
close() may block for certain file types (NFS, SO_LINGER
sockets, inotify), so let other threads run. The patch was
created by Eric Wong [ruby-core:35555][Bug #4527]
* io.c (fptr_finalize): ditto.
* io.c (maygvl_fclose): new.
* io....
kosaki (Motohiro KOSAKI)
07:23 AM Feature #4538: [PATCH (cleanup)] avoid unnecessary select() calls before doing I/O
=begin
On Fri, Apr 1, 2011 at 4:57 PM, Eric Wong <[email protected]> wrote:
> Charles Nutter <[email protected]> wrote:
>> I wonder, though, if depending on this behavior is leading Ruby more
>> and more down the GVL path. The ...
headius (Charles Nutter)

04/02/2011

05:34 PM Bug #4549: Can't start class names with non us-ascii chars
=begin
irb(main):003:0> #encoding: UTF-8
irb(main):004:0* class Åäö; end
SyntaxError: (irb):4: class/module name must be CONSTANT
class Åäö; end
^
from /usr/local/bin/irb:12:in `<main>'
...
carl.hoerberg (Carl Hörberg)
05:33 PM Bug #4549 (Rejected): Can't start class names with non us-ascii chars
=begin
irb(main):003:0> #encoding: UTF-8
irb(main):004:0* class Åäö; end
SyntaxError: (irb):4: class/module name must be CONSTANT
class Åäö; end
^
from /usr/local/bin/irb:12:in `<main>'
=end
carl.hoerberg (Carl Hörberg)
07:23 AM Feature #4538: [PATCH (cleanup)] avoid unnecessary select() calls before doing I/O
=begin
Charles Nutter <[email protected]> wrote:
> I wonder, though, if depending on this behavior is leading Ruby more
> and more down the GVL path. The designers of the JVM's core IO
> libraries, for example, were unable to re...
normalperson (Eric Wong)

04/01/2011

07:01 PM Feature #4538: [PATCH (cleanup)] avoid unnecessary select() calls before doing I/O
=begin
Understood. I read through a bit more code and saw that Ruby uses pthread signalling and RUBY_VM_CHECK_INTS after blocking regions to interrupt blocking operations.
I wonder, though, if depending on this behavior is leading Rub...
headius (Charles Nutter)
07:29 AM Feature #4538: [PATCH (cleanup)] avoid unnecessary select() calls before doing I/O
=begin
Charles Nutter <[email protected]> wrote:
> Is it possible to interrupt/wakeup a thread that's doing a direct
> blocking IO call? I always understood that as the primary reason for
> doing the select logic.

Yes for n...
normalperson (Eric Wong)
05:46 PM Bug #4547 (Closed): RUBY_HEAP_MIN_SLOTS is not reflected
=begin
nariです。
環境変数RUBY_HEAP_MIN_SLOTSから値を取得して、一番最初のヒープサイズを指定できる機能(rb_gc_set_params())が r31044 にて追加されています。
ですが、ヒープを最初に作成するInit_heap()がrb_gc_set_params()よりも前に呼び出されてしまうため、環境変数RUBY_HEAP_MIN_SLOTSの値がヒープサイズに反映されません。
そこで、rb_gc_set_para...
authorNari (Narihiro Nakamura)
02:15 PM Bug #4476: [PATCH] URI('http://hoge/b/').route_to('http://hoge/b') wrongly returns './'
=begin
I confirmed. Could you please commit your patch?
=end
akira (akira yamada)
01:29 PM Bug #4534: ri does not open $PAGER with program name only
=begin
(('+1'))

=end
Cezary (Cezary Baginski)
01:26 PM Revision 8a6e9ec0 (git): * ext/syslog/syslog.c: parenthesize macro arguments.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31229 b2dd03c8-39d4-4d8f-98ff-823fe69b080e akr (Akira Tanaka)
10:08 AM Bug #4546: ruby-indent-beg-re の値が壊れている
=begin
新しい Redmine に慣れてなくて、patch が崩れてしまいました。
以下に再掲します。

diff --git a/misc/ruby-mode.el b/misc/ruby-mode.el
index c799d8c..9023b77 100644
--- a/misc/ruby-mode.el
+++ b/misc/ruby-mode.el
@@ -72,7 +72,7 @@
"Regexp to match")
...
mrkn (Kenta Murata)
10:06 AM Bug #4546 (Closed): ruby-indent-beg-re の値が壊れている
vim-ruby の indent/ruby.vim を修正しようと思い ruby-mode.el を読んでいたところ
ruby-indent-beg-re の値が壊れているような気がしたので報告します。
r19205 で regexp-opt を使って正規表現を最適化するよう改善されていますが、
そのときに \\| が抜けてしまっています。
r19204 の 場合:
"\\(\\s *\\(class\\|module\\|def\\)\\)\\|i...
mrkn (Kenta Murata)
10:02 AM Revision cc8bc6b7 (git): Fri Apr 1 18:53:06 2011 NAKAMURA, Hiroshi <[email protected]>
* lib/webrick/cookie.rb (WEBrick::Cookie.parse): 'white space is
permitted between tokens' according to RFC2965. Though 'Netscape
spec' does not define the syntax clearly, make it tolerant as a
server. As a ...
Hiroshi Nakamura
04:19 AM Revision 9d0fbe23 (git): * vm_core.h (RUBY_VM_CHECK_INTS_TH): merge a patch by ko1
in [ruby-dev:43373].
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31227 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
nobu (Nobuyoshi Nakada)
 

Also available in: Atom