Activity
From 04/05/2011 to 04/11/2011
04/11/2011
-
11:08 PM Bug #4555: [PATCH] ext/socket/init.c: rsock_connect retries on interrupt
- =begin
Hi
I'm not convinced why we can safely call select() when we get EINTR. IOW,
Why don't you choose following patch?
Index: ext/socket/init.c
===================================================================
--- ext/soc... -
- =begin
> Subject: [PATCH] io.c (rb_io_close): ensure IOError for cross-thread closes
>
> We need to inform threads to stop operations on the FD before
> closing it and also invalidate the fd member of the rb_io_t
> struct for other ... -
- =begin
r31230 was revered by r31261.
=end
-
- =begin
Committed by r31237.
=end
-
- The patch reverted because it made a regression (see [Bug #4558])
-
- =begin
Commited by r31259.
=end
-
05:23 PM Feature #4568: [PATCH] file.c (rb_group_member): kill 256K of stack usage
- =begin
Lowering RUBY_STACK_MIN_LIMIT to 64KB across the board in
thread_pthread.c seems to work fine for check, test-rubyspec,
benchmark-each.
No real code, though, and I also don't know what outside C extensions
do, but 64KB... -
- =begin
It was using 256K stack on my x86_64 machine.
Found with scripts/checkstack.pl in the Linux kernel source:
objdump -D ./ruby | ~/linux-2.6/scripts/checkstack.pl x86_64
Also pushed to my repo: git pull git://bogomips.... - 04:38 PM Revision ace092cb (git): * 2011-04-12
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31263 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:38 PM Revision c2bfeaa2 (git): Evaluate truncate, ftruncate and ftello existence
- This corrects mingw-w64 compilation.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31262 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31261 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- and TestIO#test_cross_thread_close_fd.
The patch was written by Eric Wong. [ruby-core:35669]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31260 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- the patch was written by Eric Wong. [ruby-core:35699]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31259 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:24 AM Bug #4566: followup of [ruby-core:32747]
- =begin
The patch seems wrong: first is the way check the gcc version,
and the condition also wrong.
Additional to say, I doubt that this bug is reproduced only on mingw32.
=end
-
- =begin
=end
-
09:25 AM Bug #4564 (Assigned): mingw-w64, truncate, ftruncate and ftello -- properly evalute it's existence
- =begin
It seems good.
Check in, please.
=end
-
- =begin
[email protected] wrote:
> On JRuby master, I've made a change that does not generate backtraces
> for EAGAIN, to avoid the overhead of generating it for the expected
> case of read_nonblock having nothing available. Bu... -
07:46 AM Feature #4560: [PATCH] lib/net/protocol.rb: avoid exceptions in rbuf_fill
- =begin
This is an interesting one. JRuby recently changed how we generate backtraces to using the Java backtrace as the master. This means our backtraces are as expensive to generate as a full Java backtrace for the full stack (think gen... -
07:23 AM Feature #4539: Array#zip_with
- =begin
Hi,
On 2011年4月10日日曜日 at 11:56, Marc-Andre Lafortune wrote:
> On Sat, Apr 9, 2011 at 4:29 AM, Kenta Murata <[email protected]> wrote:
> > I implemented the features in C, and wrote tests for them.
> > Please see the fol... -
- =begin
=end
-
02:36 AM Bug #4567 (Closed): BigDecimal::ROUND_HALF_DOWN
- =begin
SImilar to the issue here [[http://redmine.ruby-lang.org/issues/3803]], BigDecimal::ROUND_HALF_DOWN does not respect all the digits involved in the rounding of a number. For example:
(({BigDecimal("1.51").round(0, BigDecimal::...
04/10/2011
- 10:24 PM Revision 2934feb9 (git): * 2011-04-11
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31258 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:24 PM Revision 091ea0ed (git): * ext/openssl/ossl.c: Fix typo, document version constants.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31257 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:23 PM Feature #4539: Array#zip_with
- =begin
On Sat, Apr 9, 2011 at 2:13 PM, Yukihiro Matsumoto <[email protected]> wrote:
>
> I am not sure whether adding new zip_with or adding zip with symbol at
> last would be better. Any opinion?
>
> ... -
12:29 PM Feature #4539: Array#zip_with
- =begin
Hi,
2011/4/9 Yukihiro Matsumoto <[email protected]>:
> I am not sure whether adding new zip_with or adding zip with symbol at
> last would be better. Â Any opinion?
I'm neutral for adding zip with symbol at last, but I
... -
12:23 PM Feature #4539: Array#zip_with
- =begin
HI,
On Sat, Apr 9, 2011 at 10:13 PM, Yukihiro Matsumoto <[email protected]> wrote:
> I am not sure whether adding new zip_with or adding zip with symbol at
> last would be better. Â Any opinion?
I vote to adding zip with... -
12:23 AM Feature #4539: Array#zip_with
- =begin
Hello,
On 9 April 2011 15:13, Yukihiro Matsumoto <[email protected]> wrote:
| Hi,
|
| I am not sure whether adding new zip_with or adding zip with symbol at
| last would be better. Â Any opinion?
|
| Â Â Â Â Â Â Â ... -
- =begin
Tomoyuki Chikanaga <[email protected]> wrote:
> These patches seem good and after applying them, make test-all passes
> all tests except a test for parallel_test in my environment. thanks!
Thanks for reporting and he... -
01:41 PM Bug #4566 (Third Party's Issue): followup of [ruby-core:32747]
- =begin
[ruby-core:32747]
Index: vm_exec.c
===================================================================
--- vm_exec.c (revision 31234)
+++ vm_exec.c (working copy)
@@ -11,7 +11,7 @@
#include <math.h>
-#if... -
01:24 PM Revision 4db93c3f (git): * include/ruby/ruby.h: parenthesize macro arguments.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31256 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:29 AM Bug #4565 (Closed): incompatible change at rev.31169 about autoload
- =begin
After rev.31169, const_defined? about a pre-autoloading constant on a included module returns true.
# Ruby/Tk cannot work on rev.31169 or later.
On ruby1.8 and before rev.31169, returns false.
For example, the following ... -
- =begin
Hello,
I'm using latest mingw-w64 builds that target in a experimental way GCC 4.7.0 codebase (gcc trunk)
mingw-w64 also combines improved CRT and headers support, which in this case included truncate, ftruncate and ftello ...
04/09/2011
-
- =begin
Hi,
On 9 April 2011 10:29, Kenta Murata <[email protected]> wrote:
> Hi,
>
> I implemented the features in C, and wrote tests for them.
> Please see the following diffs:
> https://github.com/mrkn/ruby/commit/9c7ead0e3... -
10:23 PM Feature #4539: Array#zip_with
- =begin
Hi,
In message "Re: [ruby-core:35673] Re: [Ruby 1.9 - Feature #4539][Assigned] Array#zip_with"
on Sat, 9 Apr 2011 17:29:28 +0900, Kenta Murata <[email protected]> writes:
|I implemented the features in C, and wrot... -
- =begin
Hi,
On 2011年4月5日火曜日 at 19:50, Benoit Daloze wrote:
> Here is a gist with a Ruby implementation of the modifications for
> Array#zip: https://gist.github.com/903388
> I'm wishing to do a C implementation if this feels r... -
06:14 PM Bug #4558: TestSocket#test_closed_read fails after r31230
- =begin
Hi Eric,
These patches seem good and after applying them, make test-all passes all tests except a test for parallel_test in my environment. thanks!
=end
-
- =begin
Eric Wong <[email protected]> wrote:
> Thanks for testing, think I have a better fix below (supercedes my
> original fix)
>
> Also pushed to the "io-close-fixes" branch of git://bogomips.org/ruby.git
Oops, I br... -
- =begin
KOSAKI Motohiro <[email protected]> wrote:
> After while thinking, I conclude I was wrong. If rb_io_fptr_cleanup()
> raise a exception, We don't have to kill other threads. So, now I'm
> incline to revert r31230. Hm... -
- =begin
Tomoyuki Chikanaga <[email protected]> wrote:
> ruby -v changed from - to ruby 1.9.3dev (2011-04-05 trunk 31241) [x86_64-darwin10.6.0]
>
> Hi,
>
> I applied Eric's patch, but TestSocket#test_closed_read still repo... -
- =begin
Hi,
I applied Eric's patch, but TestSocket#test_closed_read still report same failure.
I can reproduce EBADF with following script.
r, w = IO.pipe
read_thread = Thread.new{ r.read(1) }
sleep(0.1) until read_thread.st... -
- =begin
2011/4/8 Eric Wong <[email protected]>:
> KOSAKI Motohiro <[email protected]> wrote:
>> > ----------------------------------------
>> > Bug #4558: TestSocket#test_closed_read fails after r31230
>> > http://redmine... -
- =begin
I found a way to fix the issue without breaking user-facing code and still keep
performance :D
I just use a flag to mark a singleton class as ephemeral and have the method
cache bypass caching (and expiry) of short-lived ephe... - 03:10 PM Revision 2350bd94 (git): * 2011-04-10
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31255 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Use `NUM2LONG` instead of `FIX2INT`. Fixes [ruby-dev:43395].
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31254 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Fix exception message and don't raise immediately if block is not given.
Fixes [ruby-dev:43394].
* test/stringio/test_stringio.rb (test_each_line_limit_0):
Fix test for above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31253... -
- limit must not be zero. Fixes [ruby-dev:43392].
* test/stringio/test_stringio.rb: Add tests for above.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31252 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 09:02 AM Revision 699c3de1 (git): * 2011-04-09
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31251 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31250 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
04/08/2011
-
- =begin
Use decomposed string. In this case,
class A\u030Aa\u0308o\u0308
end
Ruby considers it is begin with ASCII uppercased character: constant.
=end
-
- =begin
Bug #1823 と #3827 もよろしう
=end
-
- =begin
=end
-
10:30 AM Feature #3375: --disable-libedit to disable libedit
- =begin
Shyouhei Urabe wrote:
> ext/readlineのメンテナの高尾さん:
> ...
すみません、確認できておりませんでした。
今日中に動作確認して問題がないようであればコミットします。
=end
-
01:29 AM Feature #3375: --disable-libedit to disable libedit
- =begin
ext/readlineのメンテナの高尾さん:
本件の進捗状況についてうかがいたいです。
=end
-
- =begin
r31147 and r31151.
=end
-
- =begin
=end
-
- =begin
Iwamatsu さんに ext/openssl のメンテナになってもらって、
なひさんや Martin さんと合議してもらえばいいんじゃないかと思い始めていたりはします。
=end
-
08:52 AM Bug #4562: [pull requested] ./config no-ssl2で作ったopensslとext/opensslが混ざらない
- =begin
こんにちは。
同じ問題を issues/4556 でレポートしています。
=end
-
- =begin
ext/opensslにpull requestがきているので誰か判断してほしいんですが、誰に振るべきですかね。
https://github.com/ruby/ruby/pull/12
なおパッチを(私が)見た感じによると(私には)問題ない気がしてはいます。
=end
-
- =begin
Other patches exist.
https://github.com/spk/ruby/commit/dbe76bb2c83ed393c2aee09d6419b3d3062bbda3
=end
- 07:50 AM Revision 8999a9d4 (git): * 2011-04-08
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31249 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- a string when str and lim are given.
https://twitter.com/watson1978/status/56225052152168449
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31248 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- =begin
KOSAKI Motohiro <[email protected]> wrote:
> > ----------------------------------------
> > Bug #4558: TestSocket#test_closed_read fails after r31230
> > http://redmine.ruby-lang.org/issues/4558
>
> I think cur... -
03:40 AM Feature #4553: Add Set#pick and Set#pop
- =begin
Hi.
There is no difference between your `Set#pick` and the existing `Set#first`. As such, there is no need for `pick`.
One can get the effect of `Set#pop` by calling the existing `Set#delete` with the result of `Set#first` (... -
- Hi,
On Tue, Apr 5, 2011 at 3:04 AM, Yui NARUSE <[email protected]> wrote:
>
> ...
With all due respect, I am strongly opposed to that change. There is no way that the following results should change:
```ruby
array[0...3] # =... -
- =begin
That has bitten me a few times too, but I accepted it as it is probably clearer in a long expression.
I'm curious to see why this changed.
=end
04/07/2011
-
- =begin
> ----------------------------------------
> Bug #4558: TestSocket#test_closed_read fails after r31230
> http://redmine.ruby-lang.org/issues/4558
I think current rb_io_close() is broken. We have to call rb_thread_fd_clos... -
- =begin
After r31230, make test-all reports a failure in test_socket.rb @Mac OS X 10.6.6
% make test-all TESTS=../ruby/test/socket/test_socket.rb
./miniruby -I../ruby/lib -I. -I.ext/common ../ruby/tool/runruby.rb --extout=.ext --... -
- =begin
=end
-
01:47 PM Bug #4561: 1.9.2 requires parentheses around argument of method call in an array, where 1.8.7 did not
- =begin
Same thing with pre formatting:
[dave hladik:~] cat method_call_without_parens_in_array.rb
def method_name(arg)
end
[ method_name 'value' ]
[dave hladik:~] rvm system
[dave hladik:~] ruby -v
ruby 1.8.7 (2011-02-18 patc... -
- [dave hladik:~] cat method_call_without_parens_in_array.rb
def method_name(arg)
end
[ method_name 'value' ]
[dave hladik:~] ruby -v
ruby 1.8.7 (2011-02-18 patchlevel 334) [i686-darwin10]
[dave hladik:~] ruby method_call_without_... -
- Blindly hitting IO#read_nonblock() and raising is expensive due
to two factors:
1) method cache being scanned/cleared when the IO::WaitReadable
extended class is GC-ed
2) backtrace generation
This reduces the likelyhood of an IO... -
- =begin
0002-error.c-rb_mod_sys_fail-use-subclass-and-cache.patch breaks
existing test cases that use assert_raise/assert_raises. This
may be a dealbreaker for the patch, unfortunately...
Actual code that uses "rescue Errno::EAGAIN"... -
- =begin
I noticed 0002-error.c-rb_mod_sys_fail-use-subclass-and-cache.patch breaks on latest trunk, actually.
=end
-
- =begin
Attached are patches to revert r29673 and instate the rb_mod_sys_fail class cache I proposed in [ruby-core:32508]
=end
- 11:04 AM Revision 4ca9e7d0 (git): * 2011-04-07
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31247 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31246 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- =begin
To see a paste concisely showing the problem, see https://gist.github.com/899026/ba84d66b02727675320dc4f031637d753a41c209
Code is shown below for 1.9.2p180.
The documented behaviour (and my own expectation for (({#==}))) is...
04/06/2011
-
09:07 PM Bug #4473: Calling return within begin still executes else
- =begin
I can see the same issue happening on Windows also.
=end
-
07:56 PM Bug #4549: Can't start class names with non us-ascii chars
- =begin
I beg the differ! ÅÄÖ are all uppercase letters, as oppose to åäö, in the Swedish alphabet.
The problem this is occurring for us is that we can't the name the objects in your domain model correctly. We don't wan't to translate i... -
- =begin
It is because Å is not a uppercase letter.
=end
-
- =begin
Your point is reasonable, but it breaks some cases like
s = 'HTTP://example.com/'
URI(s).to_s == s
=end
-
- =begin
Sorry, The first patch is broken.
I attched new patch.
=end
-
- =begin
SSLv2 becomes disabled in much environment, because this has several vulnerabilities.
This patch disable SSLv2 in Ruby.
If user want to use SSLv2 in ruby, you need config with --enable-opensslv2.
The SSLv2 support is disable b... -
- =begin
This issue was solved with changeset r31242.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
=end
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31245 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- =begin
Motohiro KOSAKI wrote:
> Running deadlock_test.rb in [Bug#4266] on trunk makes segfault. git bisect indicate
> first bad commit is below.
>
> --------------------------------------------------------------------------... -
- =begin
also see
((<[ruby-core:35622]|URL:http://blade.nagaokaut.ac.jp/cgi-bin/scat.rb/ruby/ruby-core/35622>))
(redmine doesn't seem to handle mail replies correctly)
=end
-
- =begin
Hiding, but not fixing the issue is the attached patch:
[PATCH] timeout.rb: avoid introducing new class for every timeout
This is expensive because of clearing the method cache upon GC.
As a side effect, it also seems to ... -
- =begin
Otherwise I get the following error in test/openssl/test_ssl.rb:
test_verify_result(OpenSSL::TestSSL):
Errno::EINTR: Interrupted system call - connect(2)
/tmp/ruby/test/openssl/test_ssl.rb:338:in `initialize'
... -
- =begin
I have a short-term fix for the related issue in Bug #4289
http://redmine.ruby-lang.org/attachments/1572/0001-timeout.rb-avoid-introducing-new-class-for-every-tim.patch
It works both with and without the mutex-synchronize-use-... -
- pop pushed error after each try of reading. fixes #4550
* ext/openssl/ossl_pkey_dsa.c (ossl_dsa_initialize): ditto.
* ext/openssl/ossl_pkey_ec.c (ossl_ec_initialize): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31244 b2dd... - 02:44 AM Revision 6fc7c377 (git): * 2011-04-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31243 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- pop pushed error after each try of reading. fixes #4550
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31242 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
04/05/2011
-
- > http://redmine.ruby-lang.org/issues/4539
> ...
Hello,
I'm answering here since redmine won't answer to my requests (even got a 500).
I think this new method would be redundant with `Array#zip`.
But I agree doing `c.zip(d).map {... -
-
- The fix may be following but it can be a spec...
```diff
diff --git a/array.c b/array.c
index bdeb768..4721387 100644
--- a/array.c
+++ b/array.c
@@ -948,7 +948,7 @@ rb_ary_subseq(VALUE ary, long beg, long len)
{
VALUE kl... -
- =begin
You seem don't install zlib-dev/readline-dev or something.
=end
-
02:33 PM Bug #4554 (Closed): test_set_errors in test_x509store.rb fails on CentOS 5.5
- =begin
On CentOS 5.5, test_set_errors in test_x509store.rb fails as follows:
1.9.2 p180
1) Failure:
test_set_errors(OpenSSL::TestX509Store) [/var/home/yhara/ruby-1.9.2-p180/test/openssl/test_x509store.rb:212]:
OpenSSL::X509... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31241 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:10 AM Feature #4553 (Rejected): Add Set#pick and Set#pop
- =begin
A very common operation on sets is to take an arbitrary element from them at O(1) cost. I know typically
it's suggested that library additions go out as a gem to see community review. However, to me it seems
to be a glaring omi... -
05:07 AM Bug #4501: 1.9.2-p180 fails to compile on OSX 10.7
- =begin
First, make sure you’ve installed XCode 4.1 DP 2 (you can download it through Apple if you are enrolled in their developer program)
Next, add the following to your ~/.bash_profile with your favorite editor
export CC=/Develope... -
- Motohiro KOSAKI <[email protected]> wrote:
> Eric, I commited slightly modified version because your patch couldn't
> ...
Thanks, looks like you missed the following hunk in rb_io_reopen():
~~~diff
diff --git a/io.c b/i... - 04:05 AM Revision 42caa6dd (git): * 2011-04-05
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31240 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:05 AM Revision 257f7859 (git): fix a typo
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31239 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- =begin
Charles Oliver Nutter <[email protected]> wrote:
> On Fri, Apr 1, 2011 at 4:57 PM, Eric Wong <[email protected]> wrote:
> > Charles Nutter <[email protected]> wrote:
> >> I wonder, though, if depending on this behav...