Activity
From 12/06/2015 to 12/12/2015
12/12/2015
-
11:32 PM Bug #11807 (Closed): Build failure of Ruby 2.3.0 preview1 and 2
-
10:53 PM Bug #11807: Build failure of Ruby 2.3.0 preview1 and 2
- I've verified that the rbenv regression fix (https://github.com/rbenv/rbenv/pull/836) does indeed fix this issue for OS X: https://github.com/rbenv/ruby-build/issues/848#issuecomment-164200034
As soon as the user from https://github.c... -
- I got some related files.
https://gist.github.com/todd/e7ce9f282a934ca3f8a5 -
10:29 PM Bug #11811: Chaining lazy enumerators causes duplicate ouput
- Ouch.
Very odd. With `p` instead of `puts`, the output is not doubled. -
05:45 PM Bug #11811 (Closed): Chaining lazy enumerators causes duplicate ouput
- In Ruby 2.3.0-preview2, I'm seeing a change in behavior using lazy enumerators with select/reject and the & operator:
irb(main):037:0> %w(1 2 3).lazy.reject(&:empty?).each { |x| puts x }
1
1
2
2
3
3
Note that the output is do... -
10:19 PM Bug #11762: Array#dig can raise TypeError: no implicit conversion of Symbol/String into Integer
- As described by Matz, it sounds like the implementation would be equivalent to
~~~
def dig(key, *keys)
value = self[key] # may raise TypeError
if keys.empty? || value.nil?
value
else
value.respond_to?(:dig) ... -
- Yukihiro Matsumoto wrote:
> Hmm,
> ...
Thanks Matz
I don't understand why it's would be a `TypeError`. I thought it would be a `NoMethodError` (or alternatively an `ArgumentError`, as reducing the number of arguments could make that... -
09:52 AM Bug #11762 (Closed): Array#dig can raise TypeError: no implicit conversion of Symbol/String into Integer
- Applied in changeset r53058.
----------
object.c: raise TypeError
* object.c (rb_obj_dig): raise TypeError if an element does not
have #dig method. [ruby-core:71798] [Bug #11762] -
01:40 AM Bug #11762: Array#dig can raise TypeError: no implicit conversion of Symbol/String into Integer
- Hmm,
`{a: 'hello'}.dig(:a, :b)` should raise TypeError since a string do not have method `dig`.
Matz.
-
- Matz, please confirm we should change `{a: 'hello'}.dig(:a, :b)` from returning `nil` to raising an error, since you said only `nil` should be protected against.
- 09:40 PM Revision 13d8bb03 (git): * lib/ostruct.rb: Have OpenStruct#dig raise if argument is not a symbol
- nor a string. See [#11762]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53063 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_insnhelper.c (vm_call_method_missing): remove spaces just
before a tab to adjust indent.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53062 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:24 PM Bug #11812 (Closed): Lack of space between colon and % literal causes syntax error
- The following snippet
~~~
{tags:%w(a)}
~~~
executes fine in ruby 2.2.3, but raises "syntax error, unexpected '%" when run under ruby 2.3.0preview2. When it is changed to
~~~
{tags: %w(a)}
~~~
Then it parses with ruby 2.3... -
05:34 PM Bug #11810 (Closed): [PATCH] OpenSSL::SSL::SSLcontext#{alpn,npn}_select_cb= does not work properly
- The protocol list passed to the callback function (set by `SSL_CTX_set_alpn_select_cb`, `SSL_CTX_set_next_proto_select_cb`) is not null-terminated string.
This issue seems to have been existing since first NPN was supported (r36871).
... -
04:30 PM Feature #8544: OpenURI should open 'file://' URIs
- I think the difference in #relative? #absolute? behaviour also points that absolute URI with "file://" should be "open"-able
~~~
> URI.parse('file:///root').absolute?
=> true
> ...
=> false
~~~ -
03:09 PM Bug #11809 (Closed): method_missing should not be refined
- Applied in changeset r53060.
----------
* vm_insnhelper.c (vm_call_method_missing): method_missing should
not be refined.
[ruby-core:72080] [Bug #11809] -
- The following code prints `[:Refinement, :abc]`, but `method_missing` should not be refined because it's indirect call.
```ruby
class Foo
end
module Bar
refine Foo do
def method_missing(mid, *args)
p [:Refinement,... - 03:09 PM Revision e3d297ba (git): * 2015-12-13
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53061 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- not be refined.
[ruby-core:72080] [Bug #11809]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53060 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:01 PM Revision 7fe3c266 (git): * ext/nkf/nkf-utf8/nkf.c: Merge nkf 2.1.4.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53059 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:29 PM Feature #10130: String format with nested hash
- Now that we have `Hash#dig` and `Array#dig` coming for Ruby 2.3, I think that this proposal of mine from the past makes more sense.
Regarding Matz' point (2), this proposal should parallel the feature of `dig`. It doesn't add extra c... -
- * object.c (rb_obj_dig): raise TypeError if an element does not
have #dig method. [ruby-core:71798] [Bug #11762]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53058 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * vm_eval.c (rb_check_funcall_with_hook): call hook after
method_missing call when missing.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53057 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:29 AM Revision c0c73379 (git): * test/ruby/test_regexp.rb: Add test cases for `$KCODE` and `$=` warning
- [Misc #11770][ruby-dev:49398]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53056 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
09:05 AM Feature #11405: [PATCH] hash.c: minor speedups to int/fixnum keys
- > Yes, it will solve the issue. But I'm unsure if we need to fix this issue. Accessing elements takes just some nano seconds. Is it a bottleneck in a real-life use-case?
It gave ~4% performance improvement for 1.9.3 in realworld appli... -
07:08 AM Feature #11405: [PATCH] hash.c: minor speedups to int/fixnum keys
- 2015-12-12 12:21 GMT+09:00 Eric Wong <[email protected]>:
> But wasn't the goal of adding rehash in r53031 to improve speed and relax the inequality?
I don't think so. It just tries to "hide" the inequality from users.
It won'... -
03:28 AM Feature #11405: [PATCH] hash.c: minor speedups to int/fixnum keys
- [email protected] wrote:
> Eric Wong wrote:
> > Perhaps teach developers to rehash explicitly. Maybe Hash#freeze
> > can imply rehash, too. But yes, I worry about memory increase more
> > than speed nowadays.
>
> I'm not su... -
- Eric Wong wrote:
> Perhaps teach developers to rehash explicitly. Maybe Hash#freeze
> ...
I'm not sure if explicit/implicit rehasing will solve any issue.
The problem is that the linked lists are too(?) long. Long linked lists de... -
- * test/ruby/test_thread.rb (test_thread_name): the target
thread needs to stay alive till the end of this test, so that
inspected result would not change.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53055 b2dd03c8-39d4-4d8f-98... -
- * vm.c (ruby_vm_destruct): free loading_table and fronzen_strings
tables at destruction.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53054 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * common.mk (help): mention `exam` target.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53053 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * common.mk (help): separate TESTOPTS and TESTS.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53052 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
08:26 AM Bug #11501: About priority of a hash element when using {**hash1, **hash2} literal
- Add description to NEWS about this on `ruby_2_2` branch (I committed in doc/NEWS-2.2.0 on trunk and backport it) at r53051.
-
- Applied in changeset r53050.
----------
* doc/NEWS-0.2.2: add description about incompatible change in Hash
duplicated key overriding policy. [Bug #10315] [Bug #11501] -
- * doc/NEWS-0.2.2: add description about incompatible change in Hash
duplicated key overriding policy. [Bug #10315] [Bug #11501]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@53051 b2dd03c8-39d4-4d8f-98ff-823fe... -
- I figured out how to fix it.
I manually deleted the following directories on Ubuntu linux that were created when I installed Ruby 2.3.0 preview 1:
/usr/local/lib/ruby/2.3.0
/usr/local/lib/ruby/gems/2.3.0
/usr/local/li... -
- Can you try with clean install with Ruby 2.3.0 preview2?
It's caused by overwrite install probably. -
- duplicated key overriding policy. [Bug #10315] [Bug #11501]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53050 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- see also https://bugs.ruby-lang.org/projects/ruby/wiki/DeveloperHowto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53049 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * iseq.c (rb_iseq_load_iseq): use rb_check_funcall instead of
repeating method search.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53048 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Shugo Maeda wrote:
> As I stated before, it might be better to introduce Kernel#using, which ignores module_eval blocks as constant lookup do.
Or it might be better to prohibit using in blocks. -
- bug hit wrote:
> > Perhaps, perhaps not. I depends on what the phrase "whatever the class body can do" mean.
> ...
As I stated before, it might be better to introduce Kernel#using, which ignores module_eval blocks as constant lookup ... -
04:37 AM Feature #11688: Struct and OpenStruct will be able to chain the Hash#dig Array#dig
- Nobuyoshi Nakada wrote:
> As those two classes were not parts of [Feature #11643], they are not rejected nor discussed.
> ...
Sorry for the late reply!
>nobu
Thanks for your improvemets!
And I'm sorry to bother you, I forgot to ... -
-
12/11/2015
-
11:53 PM Bug #11808 (Assigned): Different behavior between Enumerable#grep and Array#grep
- Regex special global variables are available within the block for `Array#grep`, but are nil within the block for `Enumerable#grep`.
Here is an example that explains it better:
~~~ruby
class Test
include Enumerable
def each
... -
10:49 PM
Feature #11806 (Closed): [PATCH] IO#advise should not raise Errno::ENOSYS
- Applied in changeset r53047.
----------
IO#advise should not raise Errno::ENOSYS
As it is just a hint the kernel is free to ignore,
IO#advise already succeeds when posix_fadvise is not
available build time at all. Following that, if p... -
- OK, agreed.
-
- [email protected] wrote:
> Or `rb_sys_fail` should map `ESYS` to `NotImplementedError`?
I don't think that's a good idea. We are already silent on
systems without HAVE_POSIX_FADVISE at build time.
IO#advise is only a hint to m... -
- Or `rb_sys_fail` should map `ESYS` to `NotImplementedError`?
-
- Not raising `NotImplementedError`?
-
- As it is just a hint the kernel is free to ignore,
IO#advise already succeeds when posix_fadvise is not
available build time at all. Following that, if posix_fadvise
was available at build time but not implemented in the running
ker... - 10:49 PM Revision fae14441 (git): IO#advise should not raise Errno::ENOSYS
- As it is just a hint the kernel is free to ignore,
IO#advise already succeeds when posix_fadvise is not
available build time at all. Following that, if posix_fadvise
was available at build time but not implemented in the running
kernel,... -
- I got build failure reports for Ruby 2.3.0 preview 1 and 2.
* https://github.com/rbenv/ruby-build/issues/833
* https://github.com/rbenv/ruby-build/issues/848
* https://gist.github.com/kurotaky/726a442fc8812fb2e142
-
- Applied in changeset r53046.
----------
enc/windows_1252.c: new
* enc/windows_1252.c: separate from ISO-8859-1 to fix 0x80..0x9e
range. [ruby-core:64049] [Bug #10097] -
08:04 AM Bug #10097: Case-insensitive Regexp matching for Windows-1252 not working for ŠšŽžŒœÿŸ
- Nobuyoshi Nakada wrote:
> Is this correct?
> ...
Sorry for the very slow response. Please commit. Thanks! -
- * enc/windows_1252.c: separate from ISO-8859-1 to fix 0x80..0x9e
range. [ruby-core:64049] [Bug #10097]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53046 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Yusuke Endoh <[email protected]> wrote:
> > I'm curious, how did you notice this?
>
> In short, I was studying hash conflicts for another reason.
>
> The detailed context is off topic, but you might be interested.
<snip>
>... -
- > The cause was a dense cdhash in opt_case_dispatch. Both programs
> ...
Why not decrease rehashing threshold?
1 is very good choice :)
Yeah, it will increase memory consumption a bit.
ok, let it be 2 -
- > I'm curious, how did you notice this?
In short, I was studying hash conflicts for another reason.
The detailed context is off topic, but you might be interested.
I encountered an interesting behavior of case statement:
100... -
08:24 AM
Feature #11405 (Closed): [PATCH] hash.c: minor speedups to int/fixnum keys
- Applied in changeset r53037.
----------
hash.c (rb_num_hash_start): avoid pathological behavior
The OR-ing itself is bad for a hash function, and shifting 3 bits
left was not enough to undo the damage done by shifting
(RUBY_SPECIAL_SHI... -
06:42 PM Feature #9451: Refinements and unary & (to_proc)
- Sorry, just saw that [issue 9786](https://bugs.ruby-lang.org/issues/9786) is equivalent to this one and was marked as rejected. Thanks!
- 04:34 PM Revision df96064c (git): * 2015-12-12
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53045 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
04:31 PM Revision ead37757 (git): NEWS: sort alphabetically
- * NEWS (Stdlib compatibility issues): sort classes/modules in
alphabetical order.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53044 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Thanks for your patch (Eric) :)
-
- Backported into `ruby_2_2` branch at r53040.
-
09:15 AM
Bug #11804 (Closed): 52931 以降、caseでInfinityを使用するとFloatDomainErrorが発生する
- Applied in changeset r53039.
----------
insns.def (opt_case_dispatch): avoid converting Infinity
Infinity cannot be written as an optimizable literal,
so it can never match a key in a CDHASH.
Avoid converting it to prevent FloatDomainE... -
- Not a new bug, actually; just easier to find since r52931
(Sorry I don't know Japanese, but was able to understand the Ruby at least).
This will need to be backported.
~~~
inf = 1.0/0.0
result = case inf
when 1 then 1
... -
- 以下のようなケースです。
```ruby
def test_infinity
inf = 1.0/0.0
result = case inf
when true then 1
when false then 0
else
inf.to_i rescue nil
end
asser... - 02:38 PM Revision 96f50503 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53043 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 02:37 PM Revision 4a1a7499 (git): * append newline at EOF.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53042 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- See https://github.com/tric/trick2015 for the contest outline.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53041 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * insns.def (opt_case_dispatch): avoid converting Infinity
* test/ruby/test_optimization.rb (test_opt_case_dispatch_inf): new
[ruby-dev:49423] [Bug #11804]'
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2... -
- I installed the new Ruby, and tried to run Ruby, but it raises the following error.
(Since I installed Ruby 2.3.0preview1, it had a bug, and I had not been able to run Ruby, and now, after having waited for a month, I installed the ne... -
- It may be a good idea if somebody could provide some actual data/examples for the claim "However, a lot of Ruby developers use arrays for situations where it would be more reasonable to use a set.". E.g. how frequent are sets when compar...
- 09:15 AM Revision d65bc80d (git): insns.def (opt_case_dispatch): avoid converting Infinity
- Infinity cannot be written as an optimizable literal,
so it can never match a key in a CDHASH.
Avoid converting it to prevent FloatDomainError.
* insns.def (opt_case_dispatch): avoid converting Infinity
* test/ruby/test_optimization.rb ... -
08:28 AM Feature #11788: New ISeq serialize binary format
- On 2015/12/11 17:15, Vít Ondruch wrote:
> Dne 8.12.2015 v 11:56 [email protected] napsal(a):
>> The goal of this project is to provide "machine dependent" binary file to achieve:
>
> Could you please elaborate more about this? For exam... - 08:25 AM Revision 89288e30 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53038 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 08:23 AM Revision e52b3a0e (git): hash.c (rb_num_hash_start): avoid pathological behavior
- The OR-ing itself is bad for a hash function, and shifting 3 bits
left was not enough to undo the damage done by shifting
(RUBY_SPECIAL_SHIFT+3) bits right. Experimentally, shifting 16-17
bits seemed to work well in preparing the number... - 07:43 AM Revision a26d09da (git): NEWS: add note about Fiddle GVL release
- * NEWS: note Fiddle GVL release [Feature #11607]
* ext/fiddle/function.c (Init_fiddle_function): document above, too
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53036 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
06:20 AM Bug #11803: NoMethodError when calling String#gsub
- first i dont think its a good idea in a to_s method to change the value of the object.
otherwise you need to use @instance variables then it works:
~~~ruby
class TestFail
def initialize(word)
@word = word
end
def to_... -
- ~~~ruby
def to_s
return unless word
word = word.gsub(/a/, "")
~~~
You make a new local variable here, and call `gsub` on it before assignment. -
12:37 AM
Bug #11803 (Rejected): NoMethodError when calling String#gsub
- Assigning the result of a call to String#gsub throws a NoMethodError. It seems to have to do with assigning the return value to a variable with the same name as the method returning the string gsub is called on. I've included short scrip...
-
- * test/openssl/test_ssl.rb (test_setting_twice): ignore fixed
flags. some flags like SSL_OP_NO_SSL_MASK cannot change.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53035 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_io.rb (test_advise, test_advise_pipe): fadvise on
aarch64-linux returns ESYS.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53034 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53033 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * test/rubygems: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53032 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * compile.c (iseq_compile_each, ibf_load_object_hash): rehash
case-dispatch hash to reduce collisions.
http://d.hatena.ne.jp/ku-ma-me/20151210
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53031 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * common.mk: add dependencies of compile.o for r52949.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53030 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53029 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/10/2015
-
11:35 PM Feature #11100: Permit multiple captures with String[Regexp, ...]
- I support allowing multiple captures. I think the [1,2] syntax is the most intuitive.
-
10:00 PM Feature #11547: remove top-level constant lookup
- Hi Shugo. Just as it does now, it doesn't perform any magic (fallback to some other scope) and doesn't emit any warning. How is it related to my bug report/ feature request? Cheers, Corin.
-
- [email protected] wrote:
> This caused a lot of trivial hash conflicts of Fixnums that is >= 16384.
Thanks for noticing, I will investigate.
I'm curious, how did you notice this?
I'll probably integrate some well-known hashin... -
- i did a little check:
~~~ruby
16384.upto(65535).group_by(&:hash).select {|k,v| v.size == 1} #=> {}
~~~
means from 16384 to 65535 all numbers have duplicated hash values
Edit:
i did scan for more and i found this: four followi... -
- This caused a lot of trivial hash conflicts of Fixnums that is >= 16384.
~~~~
$ ./miniruby -ve 'p 16384.hash; p 16385.hash'
ruby 2.3.0dev (2015-12-10 master 52945) [x86_64-linux]
1104801043349207800
1104801043349207800
~~~~
Ot... -
-
- `p {}` is parsed as `p() { }`
you see it when you try:
~~~ruby
p { :key => "value"} #which does raise a Syntax Error
~~~
you need `()`
~~~ruby
p({ :key => "value"}) # => {:key=>"value"}
~~~ -
03:39 PM Bug #11802: Hash.new and {} have different behaviour
- It looks like a block, but:
irb(main):001:0> {}.class
=> Hash
irb(main):002:0> {}
=> {} -
- It looks that {} is not recognized as a variable sometimes.
irb(main):001:0> p Hash.new
{}
=> {}
irb(main):002:0> p {}
=> nil
Similar in rspec test:
expect(subject.something).to eq {} # fails on not given argument for eq
ex... -
- Applied in changeset r53027.
----------
* object.c (rb_inspect): dump inspected result with rb_str_escape()
instead of raising Encoding::CompatibilityError. [Feature #11801]
* string.c (rb_str_escape): added to dump given string like... -
- Current rb_inspect raises Encoding::Compatibility error if obj.inspect returns a string
whose encoding is not compatible with resulted string's encoding.
But the behavior is not useful on inspecting an array or a hash containing such s... -
- instead of raising Encoding::CompatibilityError. [Feature #11801]
* string.c (rb_str_escape): added to dump given string like
rb_str_inspect without quotes and always dump in US-ASCII
like rb_str_dump.
git-svn-id: svn+ssh://ci.ruby... -
06:05 PM Feature #10617: Change multiple assignment in conditional from parse error to warning
- Why hasn't this been accepted? There is no good reason that an expression that could be nil should not be testable.
-
04:26 PM Feature #11578: Add a method to check if a number is probably prime or composite (Patch included)
- NagaChaitanya Vellanki wrote:
> Yui NARUSE wrote:
> ...
-
- Yui NARUSE wrote:
> Use OpenSSL::BN.
Rehearsal ---------------------------------------------------------------
Probably prime 11.990000 0.060000 12.050000 ( 12.054223)
OpenSSL::BN.prime_fasttest? 0.020000 0.000... -
- Use OpenSSL::BN.
-
- Shugo Maeda wrote:
> bug hit wrote:
> ...
Of course I don't mean in the same exact way, meta-programming is different than native syntax. However the question of "how" does not apply here, because you are arguing that it should be for... -
- bug hit wrote:
> > > ruby is too dynamic a language to have a clear distinction between what you're calling "static" and "dynamic" You are labeling class bodies as "static" and methods "dynamic" but a class body is executable ruby and ... -
- Shugo Maeda wrote:
> bug hit wrote:
> ...
Did you see the example in my previous post? Effectively there is no prohibition against module_eval with #using in methods, because you can open a class in a method and call module_eval from ... -
- bug hit wrote:
> Shugo Maeda wrote:
> ...
Methods are expected to be invoked more than once, so there's a significant difference from class bodies.
That's why static features like constant assignments are prohibited in method definiti... -
- Shugo Maeda wrote:
> ...
> ...
ruby is too dynamic a language to have a clear distinction between what you're calling "static" and "dynamic" You are labeling class bodies as "static" and methods "dynamic" but a class body is executabl... -
- bug hit wrote:
> so a #using in module_eval is only useful if you want the refinement confined to the block. There might be uses for that, not sure.
Yes, it's the current intended behavior.
> ...
Such dynamic extension of refinem... - 04:11 PM Revision 9e0d92a4 (git): * 2015-12-11
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53026 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53025 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:53 PM Feature #5478: Add syntax to import Set into core
- Another syntax idea:
```ruby
{|1,2,3|}
``` -
12:26 PM Feature #11690: Update Hash during multiple assignment
- I made a gem for this. [gem assign](https://github.com/danielpclark/assign)
I figure Kernel#assign is the best method name for this and the object it returns is an Assignable object. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53024 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I applied only 0002-cont.c-it-must-be-not-it-must-be-be.patch. 0001-proc.c-be-a-kind_of-not-be-be-a-kind_of.patch is already fixed another commit.
-
- Applied in changeset r53023.
----------
* cont.c: fix a double word typo.
[Bug #11313][ruby-core:69749] -
- [Bug #11313][ruby-core:69749]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53023 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r53022.
----------
* ext/tk/lib/multi-tk.rb: fix typos.
[Bug #11764][ruby-core:71800] -
- [Bug #11764][ruby-core:71800]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53022 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:35 AM Revision 7c41f093 (git): compile.c (iseq_compile_each): reduce needless rb_str_dup
- There is no need to dup the fstring unless we want to set the
debug ivar for it.
[ruby-core:72018] <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53021 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
12:51 AM Bug #11799: Object allocation during garbage collection phase terminates the Ruby process
- Koichi Sasada wrote:
> https://github.com/rdp/google_hash/blob/master/ext/template/google_hash.cpp.erb#L170
> ...
**Thanks for the prompt attention and feedback. It's greatly appreciated.**
google_hash will be removed (unfortunatel... -
-
- https://github.com/rdp/google_hash/blob/master/ext/template/google_hash.cpp.erb#L170
I'm not sure the implementation details, but
> for(<%= type %>_hash_map< <%= key_type %>, <%= value_type %> <%= extra_hash_params %> >::iterator ... -
- Thank you for your log.
This is a reason.
```
(gdb) thread 12
[Switching to thread 12 (Thread 0x7fffe5fc4700 (LWP 27808))]#0 0x00007ffff772463c in pthread_cond_wait@@GLIBC_2.3.2 () from /lib64/libpthread.so.0
(gdb) bt
#0 0x00... -
- [email protected] wrote:
> * If this is a problem due to usage of certain gems that aren't 'well-behaved', it would be good to know which ones to avoid.
Fwiw, I took a quick look at the dmark/dfree callbacks registered with
*Da... -
- Applied in changeset r53020.
----------
disable frozen-string-literal
* lib/mkmf.rb, lib/shellwords.rb: disable frozen-string-literal.
[ruby-core:72011] [Bug #11800] -
- * lib/mkmf.rb, lib/shellwords.rb: disable frozen-string-literal.
[ruby-core:72011] [Bug #11800]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53020 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- `RbConfig.expand` has to modify the argument destructively.
12/09/2015
-
10:48 PM Bug #11800 (Closed): MakeMakefile breaks with frozen strings
- It seems MkConfig(RbConfig) breaks frozen strings mode
~~~
/Users/deepj/.rubies/ruby-2.3.0-dev/lib/ruby/2.3.0/mkmf.rb:1292:in `<module:MakeMakefile>': can't modify frozen object (RuntimeError)
from /Users/deepj/.rubies/ruby-2.3.0-d... -
- Supplied correct edition of file ruby_bug-gdb.txt
-
- Resurrection of Bug #11549 that was apparently inadvertently deleted.
Also note the similarity to Bug #10868.
**Summary:** Multi-Threaded Ruby apps are often problematic; especially so when utilizing thread pools, and scheduling work... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53019 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:34 PM Revision 328205c5 (git): marshal.c: remove NULL checks for *_memsize
- This follows r52986, NULL checks in rb_data_type_t.function.dsize
callbacks are unnecessary.
* marshal.c (memsize_dump_arg): remove NULL check
(memsize_load_arg): ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53018 b2dd03c8... -
- Hi Nobu, I offer this alternative patch. What do you think?
-
- Applied in changeset r53017.
----------
mkconfig.rb: must not be frozen
* tool/mkconfig.rb: rbconfig must not be fronzen-string-literal to
expand CONFIG hash. [ruby-core:72006] [Bug #11798] -
- It seems MkConfig(RbConfig) breaks frozen strings mode
~~~
/Users/deepj/.rubies/ruby-2.3.0-dev/lib/ruby/2.3.0/x86_64-darwin15/rbconfig.rb:249:in `replace': can't modify frozen String, created at /Users/deepj/.rubies/ruby-2.3.0-dev/li... -
- * tool/mkconfig.rb: rbconfig must not be fronzen-string-literal to
expand CONFIG hash. [ruby-core:72006] [Bug #11798]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53017 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- gcc/clang optimize away that `memcpy`, at least.
-
02:35 PM Misc #11795: [PATCH] get rid of breaking strict alias for XL compiler
- Please cancel this, I see I already submitted the changes in bug 11790. Sorry about that.
-
- Related to bug 11790. Thank you for adding the changeset.
It may be better to add a IBM XL specific instruction for this:
in line 70 of regparse.h
~~~c
#ifdef __ibmxl__
#define SET_NTYPE(node, ntype) {int value = ntype; memcp... - 08:07 PM Revision 10735e2d (git): ext/socket/ifaddr.c: remove empty ifaddr_mark
- We do not need to maintain empty functions for GC,
gc_mark_children will not attempt to dereference NULL
dmark callbacks.
* ext/socket/ifaddr.c (ifaddr_mark): remove empty function
(ifaddr_type): pass zero to rb_data_type_t.function.d... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53015 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 07:58 PM Revision 06d1660e (git): proc.c: remove bm_free, use default
- bm_free no longer has special handling of unlinked method
entries since r50728 when method entries were made VALUEs
for GC safety.
* proc.c (bm_free): remove, use default free
(method_data_type): use RUBY_TYPED_DEFAULT_FREE
git-svn-i... -
- http://rubyci.s3.amazonaws.com/osx1011/ruby-trunk/log/20151209T174501Z.fail.html.gz
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53013 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * dir.c (dir_initialize): rb_id_encoding() returns same ID with
caching.
* io.c (Init_IO): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53012 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/ruby/test_rubyoptions.rb (test_frozen_string_literal_debug):
test --debug option too.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53011 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/openssl/test_ssl.rb (test_setting_twice): ignore fixed
falgs. some flags like SSL_OP_NO_SSL_MASK cannot change.
* test/openssl/test_ssl.rb (test_options_setting_nil_means_all):
ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/... -
- Applied in changeset r53009.
----------
* compile.c (iseq_compile_each): do not add debug information
without --debug or --debug=frozen-string-literal option
because String#dup slows down with debug information.
[Feature #11725]
... -
- We found performance regression with this feature.
"foo".dup with frozen literal also copy location information.
Quoted from https://bugs.ruby-lang.org/issues/11782#change-55313
```
# frozen-string-literal: true
user ... -
- without --debug or --debug=frozen-string-literal option
because String#dup slows down with debug information.
[Feature #11725]
* NEWS: apply about it.
* test/ruby/test_rubyoptions.rb: catch up this fix with refactoring.
git-svn... -
- Shugo Maeda wrote:
> bug hit wrote:
> ...
Perhaps, since you can apply the refinement outside the module_eval block which will also affect the block:
```ruby
module Refinement
refine String do
def refined?
true
... -
- bug hit wrote:
> > Nobu didn't explain that Module#using should work in methods.
> ...
Because refinement activation should be as static as possible.
It might be better to prohibit Module#using in module_eval.
-
- Shugo Maeda wrote:
> bug hit wrote:
> ...
Note that when #using is called in a module_eval block, its effect is confined to the body of the block. So why should it matter if module_eval is called from a method or top level or from ano... -
- bug hit wrote:
> Shugo Maeda wrote:
> ...
Nobu didn't explain that Module#using should work in methods.
Module#using is designed not for such dynamic use.
-
- Shugo Maeda wrote:
> bug hit wrote:
> ...
This wasn't really my expectation, it was nobu's explanation (It is not a noop, just you don't use the refined method there), which I confirmed.
"using" called from a module_eval block activ... -
- bug hit wrote:
> so if `using` inside module_eval is intended to work, then invoking such a module_eval from a method should also work (it raises Module#using is not permitted in methods):
Module#using is not intented to work as you ... -
- bug hit wrote:
> bug hit wrote:
> ...
so if `using` inside module_eval is intended to work, then invoking such a module_eval from a method should also work (it raises Module#using is not permitted in methods):
```Ruby
module Refine... -
- bug hit wrote:
> Nobuyoshi Nakada wrote:
> ...
ok got it, thanks
```ruby
module Refinement
refine String do
def refined?
true
end
end
end
module Foo
def self.refined?
''.refined? rescue false
e... -
- Nobuyoshi Nakada wrote:
> It is not a noop, just you don't use the refined method there.
Where "there"? Where should I use the refined method to see the effect of that using call? -
- It is not a noop, just you don't use the refined method there.
-
- Please explain the following behavior of `using`:
```ruby
module Refinement
refine String do
def refined?
true
end
end
end
module Foo
def self.refined?
''.refined? rescue false
end
end
Foo.mo... -
- Yukihiro Matsumoto wrote:
> Providing a feature by a method does not imply dynamic scoping, for example, Module#private etc. work in lexical scope.
However, it might be better to provide Kernel#using instead of main.using and Module#... -
- The StackOverflow question link was wrong. It should be: http://stackoverflow.com/questions/34181231.
-
- Sometimes, when working with `Enumerator#with_object`, I want to keep some additional temporary objects besides the one to return. A use case is as follows (I got this from this StackOverflow question: http://stackoverflow.com/questions/...
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53008 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Backported into `ruby_2_2` branch at r53007.
-
- * configure.in: pthread_getattr_np is broken on AIX.
More specifically, the stack address and size returned are
not correct.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@53007 b2dd03c8-39d4-4d8f-98f... -
- Backported into `ruby_2_2` branch at r53006.
-
06:17 AM Bug #11794 (Closed): backport r51808
- 毎回mswinのCIでエラーなので。
-
- * common.mk (update-gems): use BASERUBY instead of RUNRUBY.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@53006 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:12 PM Revision 4089e737 (git): * 2015-12-10
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53005 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- RubyVM::InstructionSequence#to_binary_format -> #to_binary
RubyVM::InstructionSequence.from_binary_format -> .load_from_binary
RubyVM::InstructionSequence.from_binary_format_extra_data ->
.load_from_binar... -
02:33 PM Feature #11796 (Open): [PATCH] Refactor reduce call get_stat()
- I fix to reduce call get_stat() as much as possible.
But sorry, I don't have every environment for testing. -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53003 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53002 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
12:46 PM Feature #11781: Would it be possible to alias .prepend() towards .unshift() for class Array by default?
- I too would expect `Array#prepend` to be the opposite of `Array#concat`, taking `other_ary` as a parameter, because that seems to more closely match the relationship between `String#prepend` and `String#concat`.
It sounds potentially ... -
- `String#prepend` and `String#concat` are a pair that work similarly (with just the difference on where the new substring is inserted). And since there is already `Array#concat`, introducing `Array#prepend` would suggest that they should ...
-
- Their arities differ.
Let `String#prepend` take any number of arguments?
~~~diff
diff --git i/array.c w/array.c
index dd14837..b98142d 100644
--- i/array.c
+++ w/array.c
@@ -5832,6 +5832,7 @@ Init_Array(void)
rb_define_met... -
- I prefer we avoid introducing needless aliases.
It increases human cognitive overhead for reviewing/auditing
code and also wastes machine memory + CPU cycles at startup. -
- It sounds nice. Since it is right before 2.3 release, it may be too late for it.
Matz.
-
12:29 PM Bug #11764: ext/tk/lib/multi-tk.rb: fix three typos.
- Maybe you should set to another guy, because the last connection of Hidetoshi Nagai is 07/19/2015.
https://bugs.ruby-lang.org/users/122 -
- * test/io/console/test_io_console.rb (test_getpass): skip for the
time being.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53001 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
-
- This patch was aleady applied.
Close? -
- * test/io/console/test_io_console.rb (test_getpass): wait for the
child process to read the input, not to read it by the master
itself.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@53000 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- On 2015/12/09 18:25, Eric Wong wrote:
>> > (Sorry if I overlooked marking)
> Wait, putobject calls (and TS_VALUE operands) do not go away when
> opt_case_dispatch insn is emitted, so marking keys in literal hash is
> redundant. sinc... -
- SASADA Koichi <[email protected]> wrote:
> On 2015/12/08 13:53, Eric Wong wrote:
> >> > how to mark literal objects?
> > Take ideas from nobu (r52708 :)
>
> I meant marking, not for freeing a table.
>
> For example, bignum objects ... -
- Applied in changeset r52999.
----------
regparse.h: ANSI alias rule fix
* regparse.h (SET_NTYPE): get rid of breaking strict aliasing.
patch by Zarko Todorovski in [ruby-core:71953]. [Bug #11790] -
- * regparse.h (SET_NTYPE): get rid of breaking strict aliasing.
patch by Zarko Todorovski in [ruby-core:71953]. [Bug #11790]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52999 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/io/console/test_io_console.rb (test_getpass): ignore echo
back of input from the master side. some systems seem echo back
but other may not.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52998 b2dd03c8-39d4-4d8f-98ff-823... -
- revert slow atomic operations.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52997 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r52996.
----------
* vm.c (rb_vm_cref_in_context): Module#define_method in non-class
expression should be public.
[Bug #11754]
* test/ruby/test_method.rb: add a test. -
- expression should be public.
[Bug #11754]
* test/ruby/test_method.rb: add a test.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52996 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * regcomp.c (onig_chain_link_add): use atomic operation instead of
mutex.
* regint.h (ONIG_STATE_{INC,DEC}_THREAD): ditto.
* regparse.c (PopFreeNode, node_recycle): ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52995 b2dd03... -
- The document states "It may contain back-references", `\+` is one of them.
Note: preformated text requires a preceding blank line. -
06:26 AM Bug #11793: puts 'ab'.gsub('a', '\\+') - unexpected output
- I should have used this example:
~~~
puts 'ab'.gsub('a', "\x5C\x5C\x2B")
\+b
~~~ -
- Substitution parameters work in string-string mode:
~~~
irb> puts 'ab'.gsub('a', %q(\`))
b
irb> puts 'ab'.gsub('a', %q(\&))
ab
irb> puts 'ab'.gsub('a', %q(\'))
bb
irb> puts 'ab'.gsub('a', %q(\0))
ab
irb> puts 'ab'.gsub('a', %... -
-
- its because how `gsub` works you need to escape the `\`
~~~ruby
puts 'ab'.gsub('a', '\\\+') #=> \+b
~~~ -
05:31 AM Bug #11793 (Rejected): puts 'ab'.gsub('a', '\\+') - unexpected output
- Test case:
~~~ruby
puts 'ab'.gsub('a', '\\+')
~~~
Expected output:
~~~
\+b
~~~
Actual output:
~~~
b
~~~
The way I understand `gsub(pattern, replacement)` when used with two string arguments is that it will perform... -
- Applied in changeset r52994.
----------
* gc.c (gc_mark_stacked_objects): fix typo.
reported by XIE Zhibang. [Bug #11763] -
- reported by XIE Zhibang. [Bug #11763]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52994 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52993 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Koichi Sasada wrote:
> Updated.
Thanks.
> ...
I'm not sure, too.
But I can say that if a feature introduces a known security risk, users must be informed with documentations.
-
- On 2015/12/09 13:41, [email protected] wrote:
> You should mention it at NEWS.
Updated.
I'm not sure how detail description is needed on an entry.
--
// SASADA Koichi at atdot dot net -
- Koichi Sasada wrote:
> Note that current implementation lacks error checking and verification,
> ...
(snip)
> It will be a security risk if malicious person can pass modified binary data to MRI.
You should mention it at NEWS. -
- Note that current implementation lacks error checking and verification,
so that broken binary data cause SEGV (or access overflow) easily.
This is another reason why I wrote it is not for "migration" purpose.
(malicious binary data... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52992 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/stringio/stringio.c (strio_memsize): remove a variable which
is no longer used.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52991 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52990 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:34 AM Revision a422462a (git): compile.c (ibf_dump_object_unsupported): fix spelling error
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52989 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52988 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52987 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- You didn't explain why we should extend. Extending quote characters can cause confusion.
We cannot accept it without concrete use-case or benefit description.
Matz.
-
- NULL checking is finished Before call of memsize functions.
See r52979.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52986 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- without rubygems and rdoc.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52985 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52984 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/08/2015
-
- * test/uri/test_generic.rb (test_to_s): use assert_not_predicate.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52983 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:48 PM Bug #11792 (Closed): Backport r52199 (pthread_getattr_np is broken on AIX)
- This is a ticket to manage back-porting r52199 to 2.1 and 2.2.
-
- * string.c (rb_str_init): rb_id_encoding() returns same ID with
caching.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52982 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Does CAS work?
~~~c
/* THREAD_ATOMIC_START; */
{
FreeNode *n = FreeNodeList, *n0;
while (IS_NOT_NULL(n) && (n0 = ATOMIC_PTR_CAS(FreeNodeList, n, n->next)) != n)
n = n0;
if (IS_NOT_NULL(n)) return (Node* )n;... -
- line 70 in file regparse.h:
~~~c
#define SET_NTYPE(node, ntype) (node)->u.base.type = (ntype)
~~~
needs to be changed to conform with ANSI alias rules
Line 70 as it is can lead to errors in compiling in regparse.c
~~~c
... -
09:55 PM Feature #11791 (Feedback): The literal quotes should accept more quote characters (aka more unicode characters)
- I frequently use literal quoting, aka %q[], %w[], %i[]
I'd like to suggest that the set of quoting characters should be extended.
I believe that some pairs of unicode character should also be allowed as paired quoting characters.
... -
- [email protected] wrote:
> > I prefer String.new() to "".dup because the former describes intention (of creating a buffer).
>
> Ok. I've attached a rev3 patch that uses `String.new` instead of `''.dup`.
Thanks. Committed as ... -
09:30 PM
Bug #11759 (Closed): URI breaks with frozen strings
- Applied in changeset r52981.
----------
lib/uri/generic.rb: enable frozen_string_literal
* lib/uri/generic.rb: enable frozen_string_literal
(split_userinfo): remove explicit .freeze for string literals
(check_path): ditto
(query)... - 09:28 PM Revision f2b9563b (git): lib/uri/generic.rb: enable frozen_string_literal
- * lib/uri/generic.rb: enable frozen_string_literal
(split_userinfo): remove explicit .freeze for string literals
(check_path): ditto
(query): ditto
(fragment): ditto
(to_s): ditto
[ruby-core:71910] [Bug #11759]
Patch-by: Col... - 09:27 PM Revision 0df938d5 (git): test/uri/test_generic.rb (to_s): new test
- Ensure URI::Generic#to_s continues to return mutable strings to
prevent breakage when we enable frozen string literals in future
commits.
[ruby-core:71820]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52980 b2dd03c8-39d4-4d8f-98ff... -
05:38 PM Feature #11782: String#+@ and String#-@
- how about splitting strings like this?
~~~
long_string = 'first part ' +
'second part ' +
'last part'
~~~
Should long_string be optimized by the compiler to generate 'first part second part last part' as a frozen string, or... -
- Quoted from DevelopersMeeting20151021Japan log:
https://bugs.ruby-lang.org/projects/ruby/wiki/DevelopersMeeting20151021Japan https://docs.google.com/document/d/1axnQv1A2SdRExw--_RzXXJAPrRyvN7MCIB0WrKcZaSE/pub
> matz: i have another i... -
- * gc.c (rb_objspace_data_type_memsize): consider NULL data uses no
memory without calling dsize function as well as other functions.
fix SEGV in test/objspace with RUBY_ISEQ_DUMP_DEBUG=to_binary.
git-svn-id: svn+ssh://ci.ruby-lang.o... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52978 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Backported into `ruy_2_2` branch at r52977.
-
- * insns.def (opt_case_dispatch): check Float#=== redefinition
* test/ruby/test_optimization.rb (test_opt_case_dispatch): new
[ruby-core:71920] [Bug #11784]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_... -
- Applied in changeset r52976.
----------
* string.c (rb_str_init): now accepts new option parameter `encoding'.
[Feature #11785] -
- Agreed. I prefer `String.new("", encoding: 'utf-8')`.
Matz.
-
- Another idea, `Encoding#string`, came in my mind.
~~~diff
diff --git a/encoding.c b/encoding.c
index eb777c9..f0001b3 100644
--- a/encoding.c
+++ b/encoding.c
@@ -1171,6 +1171,38 @@ enc_names(VALUE self)
/*
* call-seq:
+... -
- I propose to add `encoding:` optional argument to `String.new`.
Ruby doesn't have the syntax to specify the encoding of a string literal.
So we're using `String#force_encoding` for the purpose when writing m17n script, just like:
... - 04:48 PM Revision 4466d4ba (git): * string.c (rb_str_init): now accepts new option parameter `encoding'.
- [Feature #11785]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52976 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Backported into `ruby_2_2` branch at r52975.
-
- ruby_2_1 r52934 merged revision(s) 52892.
-
- * ruby_atomic.h (ATOMIC_SIZE_CAS): fix the argument order of
InterlockedCompareExchange64. new value and then old value is
the last.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@52975 b2dd03c8-39d4... -
- Backported into `ruby_2_2` branch at r52974.
-
- ruby_2_1 r52933 merged revision(s) 52856,52906.
-
- * encoding.c (enc_m_loader): defer finding encoding object not to
be infected by marshal source. [ruby-core:71793] [Bug #11760]
* marshal.c (r_object0): enable compatible loader on USERDEF
class. the loader... -
- Backported into `ruby_2_2` branch at r52973.
-
- * ext/-test-/file/fs.c: need to include sys/statvfs.h
to use statvfs().
* ext/-test-/file/extconf.rb: check the existence of
sys/statvfs.h
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_2@52973... -
- * test/lib/envutil.rb (assert_ruby_status): show also outputs at
normal exit.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52972 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * compile.c (ibf_dump_overwrite): cast to unsigned long to
suppress sign-compare warning.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52971 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * file.c (rb_stat_wr, rb_stat_ww): call get_stat only once and
reduce checking struct. patch by Yuki Kurihara in
[ruby-core:71949]. [Misc #11789]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52970 b2dd03c8-39d4-4d8f-98ff-823f... -
- Yes, this method is only for did_you_mean gem.
-
- NEWS does not mention about this feature.
Is it intended? -
- Applied in changeset r52942.
----------
error.c: name_err_local_variables
* error.c (name_err_local_variables): new method
NameError#local_variables for internal use only.
[Feature #11777] -
- * sample/iseq_loader.rb: add using
RubyVM::InstructionSequence.from_binary_format_extra_data method
(commented out).
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52969 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * compile.c (iseq_ibf_load_extra_data): fix offset and
length of extra_str, which is not NUL-terminated.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52968 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:23 PM Revision 3ba62bde (git): gems/bundled_gems: Upgrade the did_you_mean gem to 1.0.0.rc1
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52967 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52966 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * compile.c (iseq_load_setup): check binary format.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52965 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Thank you all!
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52964 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- I fix to call **get_stat()** only once.
- 03:05 PM Revision bd7e04e4 (git): * 2015-12-09
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52963 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52962 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52961 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * compile.c (iseq_ibf_dump): wrap ibf_dump to free tables at
exception.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52960 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52959 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * compile.c (iseq_ibf_dump): rb_check_string_type() returns nil if
the object does not have to_str method.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52958 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:33 PM Revision d573666e (git): * test/io/console/test_io_console.rb (run_pty): Avoid waiting twice
- for a process. Fix Errno::ECHILD in TestIO_Console#test_close and
TestIO_Console#test_sync.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52957 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52956 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * compile.c (iseq_ibf_dump): check lenght overflow.
* vm_core.h (rb_iseq_check): suppress unused-value warnings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52955 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52954 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52953 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52952 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:59 PM Revision d0f29abb (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52951 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 01:59 PM Revision c49cb7fe (git): * remove trailing spaces.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52950 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Applied in changeset r52949.
----------
* introduce new ISeq binary format serializer/de-serializer
and a pre-compilation/runtime loader sample.
[Feature #11788]
* iseq.c: add new methods:
* RubyVM::InstructionSequence#to_binary_... -
- Good question. I never take notice about that.
Try resolv.rb with use to_a/load_iseq.
```
user system total real
compile 10.590000 0.270000 10.860000 ( 11.452102)
compile 10.580000 0... -
- [email protected] wrote:
> * RubyVM::InstructionSequence#to_binary_format returns binary format data as String object.
> * RubyVM::InstructionSequence.from_binary_format(data) de-serialize it.
Why a new custom binary format instead of ... -
- # Abstract
I wrote a new RubyVM::InstructionSequence (ISeq) object serializer and de-serializer binary format.
Matz had approved to introduce this feature to Ruby 2.3 as *experimental* feature.
So I'll commit them.
There are two ... -
- and a pre-compilation/runtime loader sample.
[Feature #11788]
* iseq.c: add new methods:
* RubyVM::InstructionSequence#to_binary_format(extra_data = nil)
* RubyVM::InstructionSequence.from_binary_format(binary)
* RubyVM::Instruc... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52948 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:20 PM Bug #10398: Server Name Indication support broken when reusing a (dead) session
- #11401 solves this issue.
-
- * NEWS: mention about Enumerator::Lazy#grep_v.
[ruby-core:71845] [Feature #11773]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52947 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52946 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Martin Dürst wrote:
> > I should note that mswin CI will be given up just after Ruby 2.3 release because I can never keep its cost.
> ...
The former. It costs about $130 per month. -
- Usaku NAKAMURA wrote:
> I should note that mswin CI will be given up just after Ruby 2.3 release because I can never keep its cost.
Does this mean cost of infrastructure (which can be paid for) or cost of your work (which may be ve... -
- Reject IO::Console#getpass because it can't test portablly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52945 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52944 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- SASADA Koichi <[email protected]> wrote:
> On 2015/12/08 13:53, Eric Wong wrote:
> >> > how to mark literal objects?
> > Take ideas from nobu (r52708 :)
>
> I meant marking, not for freeing a table.
Oops :x I added rb_mark_set to... -
- On 2015/12/08 13:53, Eric Wong wrote:
>> > how to mark literal objects?
> Take ideas from nobu (r52708 :)
I meant marking, not for freeing a table.
For example, bignum objects should mark from this table.
```ruby
case nil
w... -
- Full v2 patch including leak fix with wrapper object:
http://80x24.org/spew/20151208050811.6803-1-e%4080x24.org/t/raw
Slightly smaller improvements with leak fix, but it could be noise
for the small cases.
2015-12-08 05:06:17 ... -
- SASADA Koichi <[email protected]> wrote:
> On 2015/12/08 12:43, Eric Wong wrote:
> > Oops, I forgot to free the table when iseq is destroyed :x
> > Update coming...
>
> how to mark literal objects?
Take ideas from nobu (r52708 :)
... -
- On 2015/12/08 12:43, Eric Wong wrote:
> Oops, I forgot to free the table when iseq is destroyed :x
> Update coming...
>
how to mark literal objects?
BTW, I'm writing new iseq dumper and loader.
it is some tough timing such ... -
- Oops, I forgot to free the table when iseq is destroyed :x
Update coming... -
- I noticed these optimizations while working on r52931.
By using a bare hash table, we avoid the overhead of rb_hash_*
functions as well as the cost of translating FIX2INT for jump
labels.
This also reduces GC overhead, as the ise... -
- Shugo Maeda wrote:
> Encoding.default_internal should be check instead.
I've attached a patch.
-
- rb_inspect() checks Encoding.default_external even if Encoding.default_internal is specified.
```
$ cat t.rb
puts "\u3042"
p "\u3042"
$ ruby -E windows-31j:utf-8 t.rb
あ
t.rb:2:in `p': inspected result must be ASCII only or use t... -
- Applied in changeset r52943.
----------
enumerator.c: lazy_grep_v
* enumerator.c (lazy_grep_v): add Enumerator::Lazy#grep_v as well
as Enumerable, to enumerate lazily.
[ruby-core:71845] [Feature #11773] -
- * enumerator.c (lazy_grep_v): add Enumerator::Lazy#grep_v as well
as Enumerable, to enumerate lazily.
[ruby-core:71845] [Feature #11773]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52943 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- @Koichi: good that you classify it, for a moment i thought that might be an feature ;P
-
- * error.c (name_err_local_variables): new method
NameError#local_variables for internal use only.
[Feature #11777]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52942 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 05:21 AM Revision cb3b463a (git): * array.c: Improve and fix documentation for Array#dig
- [#11776]
* hash.c: ditto
* struct.c: ditto
* test_hash.rb: Add basic test for user defined `dig`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52941 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * marshal.c (w_objivar): skip internal instance variables in
T_OBJECT too.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52940 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * test/io/console/test_io_console.rb (test_getpass): separate
master side and slave side in each threads. r52937 deadlocked
on OS X. [Bug #11780] [ruby-dev:49412]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52939 b2dd03c8-39... - 04:32 AM Revision f2a7ca74 (git): compile.c (iseq_build_from_ary_body): avoid rb_ary_dup for CDHASH
- This reverts r16587
("compile.c (iseq_build_body): remove side effect from
VM::InstructionSequence.load."
as that change was obsoleted by r48705 ("mostly fix rb_iseq_load")
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52938 b2dd0... -
- Applied in changeset r52937.
----------
* test/io/console/test_io_console.rb (test_getpass): s.getpass
should be tested. Narrow ensure block. This reverts r52911.
[Bug #11780] [ruby-dev:49412] -
- should be tested. Narrow ensure block. This reverts r52911.
[Bug #11780] [ruby-dev:49412]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52937 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Here is my suggested documentation on how `Hash#dig` should behave as part of a general `dig` protocol. The patch includes equivalent changes to the documentation for `Array#dig`.
~~~
* Extracts a nested value by navigating the giv... -
- The current doc also gives examples that should return raise an error, if I understand correctly:
a = [[1, [2, 3]]]
a.dig(0, 0, 0) #=> nil
Since `1.dig(0)` is invalid (and 1 is not `nil`), that should r... -
- > I'd guess, like Colin, that returning nil is probably the best. Makes debugging harder when writing new code, but makes backward compatibility easier, since old code using dig wouldn't bomb if the data layout changes in the future.
... -
- Reopening, since \the following should raise an error:
{a: 'hello'}.dig(:a, :b) # => nil, should raise an Error
Right? -
- This change actually introduces a syntactic incompatibility. Is this okay? I have not seen any real-life use-case that suffers from this incompatibility, though.
~~~
def foo
42
end
BAR = -10
p foo <<~BAR
~~~
~~~
$ ruby -... -
- Hey, nobu, write NEWS!!
- 03:20 AM Revision be801955 (git): * tool/merger.rb: get user's attention by using colored message when requiring operation.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52936 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- 2.0/2.1 use different code about r51816.
So they don't have this problem, I think. -
- * NEWS: mention about indented here document. [Feature #9098]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52935 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 02:54 AM Revision 682e86be (git): merge revision(s) 52892: [Backport #11775]
- * ruby_atomic.h (ATOMIC_SIZE_CAS): fix the argument order of
InterlockedCompareExchange64. new value and then old value is
the last.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@52934 b2dd03c8-39d4... - 02:51 AM Revision f0680bde (git): merge revision(s) 52856,52906: [Backport #11760]
- * encoding.c (enc_m_loader): defer finding encoding object not to
be infected by marshal source. [ruby-core:71793] [Bug #11760]
* marshal.c (r_object0): enable compatible loader on USERDEF
class. the loader... - 01:47 AM Revision 45a6f637 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52932 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:47 AM
Feature #11769 (Closed): optimize case / when for `nil`
- Applied in changeset r52931.
----------
compile optimized case dispatch for nil/true/false
nil/true/false are special literals just like floats, integers,
literal strings, and symbols. Optimize when statements with
them by using a jum... -
- Eric Wong <[email protected]> wrote:
> Cool. Might be worth it to do the same for `true` and `false`,
> too, since we have space for them.
Sythetic benchmark shows a 3x speedup on top of r52928:
http://80x24.org/spew/201512... - 01:46 AM Revision 4ebab10b (git): compile optimized case dispatch for nil/true/false
- nil/true/false are special literals just like floats, integers,
literal strings, and symbols. Optimize when statements with
them by using a jump table, too.
target 0: a (ruby 2.3.0dev (2015-12-08 trunk 52928) [x86_64-linux]) at "/home/... -
- * lib/optparse.rb: fix double word typo in the document.
[Misc #10608] [Fix GH-1126]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52930 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/date/date_core.c (d_lite_lshift): should check the argument
before negation.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52929 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/07/2015
-
11:57 PM
Bug #11784 (Closed): [PATCH] insns.def (opt_case_dispatch): check Float#=== redefinition
- Applied in changeset r52928.
----------
insns.def (opt_case_dispatch): check Float#=== redefinition
The missing check for Float#=== redefinition was noticed while
working on enhancing optimized case dispatch for nil/true/false
in [ruby... -
- insns.def (opt_case_dispatch): check Float#=== redefinition
The missing check for Float#=== redefinition was noticed while
working on enhancing optimized case dispatch for nil/true/false
in [ruby-core:71818] https://bugs.ruby-lang.o... - 11:56 PM Revision 4d2ce0cb (git): insns.def (opt_case_dispatch): check Float#=== redefinition
- The missing check for Float#=== redefinition was noticed while
working on enhancing optimized case dispatch for nil/true/false
in [ruby-core:71818] https://bugs.ruby-lang.org/issues/11769
So no, I don't normally redefine core classes li... -
- r50423 will be soon back-ported to the 2.2 branch.
In the meantime, I believe you can avoid the compile error by the following patch.
~~~diff
--- ruby-2.2.3/ext/-test-/file/fs.c 2015-05-23 10:15:12.000000000 -0700
+++ ../Cont... -
- 07:01 PM Revision d0ea0389 (git): * properties.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52927 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- If you enable this checker (remove `#' in test/runner.rb),
you can see comparison results between an original iseq disassembed
result and dumped and loaded iseq disassembed result.
There are several bugs around there, because of i... - 06:49 PM Revision b401937c (git): doc/extension.rdoc: warn about kwargs performance in C [ci skip]
- This existing API seems doomed performance-wise, and writing
things in Ruby is nicer anyways. So discourage folks from
using it.
[Feature #11339]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52925 b2dd03c8-39d4-4d8f-98ff-823fe69b... -
- because apply it multiple times change the sequence.
(iseq != peephole_optimize(load(iseq.to_a)))
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52924 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- if table_size is 0.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52923 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:39 PM Revision 889f5022 (git): socket: expand docs+tests for recv_io/send_io
- * ext/socket/unixsocket.c (unix_send_io): document args
(unix_recv_io): ditto
* test/socket/test_unix.rb (test_fd_passing_class_mode): added
I was working on these when I encountered the problem in
with BasicSocket.for_fd not handling... -
- Yukihiro Matsumoto wrote:
> Providing a feature by a method does not imply dynamic scoping, for example, Module#private etc. work in lexical scope.
> ...
actually `private` is more dynamic than `using`, here's an example of private wor... -
- Yukihiro Matsumoto wrote:
> Providing a feature by a method does not imply dynamic scoping, for example, Module#private etc. work in lexical scope.
> ...
Well, since it's an established pattern, one has to just accept it. It does seem... -
- Providing a feature by a method does not imply dynamic scoping, for example, Module#private etc. work in lexical scope.
Matz.
-
- Yukihiro Matsumoto wrote:
> Can elaborate what do you want if `using` should not be a method.
> ...
I don't know what possibilities there are, it just struck me that it was not behaving at all as a method, methods affect their dynamica... -
- Can elaborate what do you want if `using` should not be a method.
Considering a new keyword would break existing code, I don't think it's a good idea.
Matz.
-
- call RubyVM::InstructionSequence.translate(iseq) if this method
is defined. If the return value is also an object of
RubyVM::InstructionSequence, then use it instead of created one.
For example, this method is useful to test iseq ... -
- I don't say anything about 3.0 for now.
But things are more complicated than you imagine.
Matz.
-
- Yukihiro Matsumoto wrote:
> Pending, for several reasons:
> ...
`def []=(k,opt={},v)` feels wrong because you're taking a dependency on incorrect behavior (method dispatch that puts a positional arg after the keyargs) Why not correct ... -
- Pending, for several reasons:
(1) compatibility. `a[a,foo:1]=v` is valid code. changing behavior may crash existing code.
(2) you can delegate to other method e.g.
```ruby
def opt_aset(k,v,option:nil)
...
end
def []=(k,opt... -
04:58 PM Revision a34e45fd (git): * ext/psych/*: update psych to 2.0.16
- * test/psych/*: ditto
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52920 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52919 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- > I prefer String.new() to "".dup because the former describes intention (of creating a buffer).
Ok. I've attached a rev3 patch that uses `String.new` instead of `''.dup`.
> ...
I had a question about that but I saw it answered els... -
- I prefer `String.new()` to `"".dup` because the former describes intention (of creating a buffer).
In fact, my best choice is introducing `String#+` that returns a mutable copy of a string.
For the size of byte code and performance, ... -
- The purpose of this proposal is to encourage frozen string literals and provide better way than `"foo".dup`. So that `String#-@` can be redundancy.
-
- Endo-san pointed out that `+foo.upcase!` is evaluated as `+(foo.upcase!)`.
It can be problem. But any practical examples?
Mutate operations such as `str = +'foo' << bar << baz` works (because +@ is stronger than <<).
Evaluation wi... -
- Applied in changeset r52917.
----------
* string.c: introduce String#+@ and String#-@ to control
String mutability.
[Feature #11782] -
- +1
--
Yusuke Endoh <[email protected]> -
- It's OK if we don't have strong objection.
Matz.
-
- Matz said
> In fact, my best choice is introducing `String#+` that returns a mutable copy of a string.
[ruby-core:71879] [Ruby trunk - Bug #11759]
So that this is a ticket for that.
I'll commit it ASAP to check this methods bef... -
03:19 PM Feature #9098: Indent heredoc against the left margin by default when "indented closing identifier" is turned on.
- Ah, for some reason I was under the impression that the plan was to use the indentation from the first non-blank line to determine how much to dedent the entire string.
If the plan instead is to use the least-indented non-blank line f... -
- Applied in changeset r52916.
----------
parse.y: indented hereoc
* parse.y: add heredoc <<~ syntax. [Feature #9098] -
- Alternative 2 looks good to me.
Matz.
- 03:10 PM Revision 59c3a2f8 (git): * 2015-12-08
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52918 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- String mutability.
[Feature #11782]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52917 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * parse.y: add heredoc <<~ syntax. [Feature #9098]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52916 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:19 PM Feature #11735: Porting String#squish and String#squish! from Ruby on Rails' Active Support
- nobu's patch seems to be the better way to implement this feature without having to use regular expression. Much more efficient.
I guess I should try to think outside the box the next time I try to write something in C.
+1 to nobu'... -
- https://github.com/ruby/ruby/compare/trunk...nobu:feature/11735-squish
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52915 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
02:08 PM
Bug #11730 (Closed): read_nonblock's call-seq missing options
- Applied in changeset r52914.
----------
add missing options to call-seq of IO#read_nonblock
* prelude.rb (IO#read_nonblock): [DOC] add missing options to
call-seq. [ruby-core:71627] [Bug #11730] -
- * prelude.rb (IO#read_nonblock): [DOC] add missing options to
call-seq. [ruby-core:71627] [Bug #11730]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52914 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Koichi Sasada wrote:
> > nurse: VPS severs for CI are welcome. Especially for Azure.
I should note that mswin CI will be given up just after Ruby 2.3 release because I can never keep its cost. -
- Do you have any idea about Ruby interpreter implementation to do with budgets?
# Background
Now, we are summarizing many contributions from many people, organizations and companies.
https://docs.google.com/document/d/1y1sQc40qeu... -
- Thank you. I appreciate your consideration.
-
- It's not worth adding special expression or variable for retrieving the when value.
Just use assignment.
Matz.
-
- `prepend` is already a keyword in the Ruby language for prepending a module in the ancestry chain: http://ruby-doc.org/core-2.2.3/Module.html#method-i-prepend
-
10:12 AM Feature #11781 (Open): Would it be possible to alias .prepend() towards .unshift() for class Array by default?
- Hello.
For Strings we can do:
abc = 'world!'
abc[0,0] = 'Hello '
abc # => "Hello world!"
For Arrays we can do:
abc = ['world!']
abc[0,0] = 'Hello '
abc # => ["Hello ", "world!"]
This is nice.
... -
- yuzo san が担当者一覧に見つかんなかったので、nahi さんにとりあえず振っておきます。
すみませんが、適切な方に delegate して頂けると。 -
- * This is a bug, so that anyone should not rely on this behavior.
* This is a bug, so that this bug should be fixed
* But not critical, so 2.3 can remain this behavior. It should be fix in a future. -
- Solaris 10 にて、TestIO_Console#test_getpass が以下のエラーで失敗します。
~~~
1) Error:
TestIO_Console#test_getpass:
Errno::EINVAL: Invalid argument
/XXXXX/test/io/console/test_io_console.rb:190:in `getpass'
/XXXXX/test/io/console/test_... -
- ありがとうございます:)
-
- OK.
Matz.
-
- ご自分でコミットなさるのがよいのではないでしょうか。
よいですよね＞matz
redmineのruby-coreグループには追加したので、その他の手続きお願いします＞しばたさん
-
-
- Document is wrong.
Zack, could you fix it? -
- I'll fix it.
-
- It's not clear to generate either Hash, Array, or Struct (or whatever) to bury a value.
So it's better to reject now.
Matz.
-
-
- discuss for 2.4 and later
-
- Use `tap`. Methods with side-effect should be handled with care. Making it chainable has little benefit.
Matz.
-
- I believe `dig` should only ignore nil receiver as its description.
Hiding argument/type error is not a good idea, I think.
Matz.
-
-
- Confirmed. ;-)
Matz.
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52913 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
-
- It's OK to add. But I think we should mark it as 'internal use' in the reference.
Matz.
-
- Agreed. the patch LGTM.
Matz. - 03:12 AM Revision 52439760 (git): * 2015-12-07
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52912 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52911 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
12/06/2015
-
- 1. it can't be called from another method
2. the receiver must be self
3. since refinements are lexically scoped the self receiver must match the currently open class
#3 is particularly curious
```ruby
module Refinement
refin... -
08:48 PM Feature #11588: Implement structured warnings
- #3 is a big deal IMHO. Having finer-grained control over which warnings are
shown is long overdue.
On Tue, Oct 13, 2015 at 11:25 AM <[email protected]> wrote:
> Issue #11588 has been reported by Daniel Berger.
>
> ------------... -
- Matz, warnings may not affect control flow, but I've seen enough real world application logs filled with warnings we couldn't control to dispute your assertion that they don't need to be handled by machines. And right now they can't real...
-
- Following test show the failure in the second recv_io call.
I was writing additional tests for FD passing when I noticed this.
I'm not sure if BasicSocket.for_fd should do with the mode flag if
we change its arity...
~~~
--- a/t... -
- [email protected] wrote:
> I don't think there is good enough reason to deprecate `rb_autoload`.
Who uses rb_autoload from C extensions?
It is not performance-critical.
I'd like to make the C API smaller so we can have less to ... -
- I don't think there is good enough reason to deprecate `rb_autoload`.
-
12:28 PM
Feature #11664 (Closed): [PATCH] introduce rb_autoload_value to replace rb_autoload
- Applied in changeset r52909.
----------
introduce rb_autoload_str to replace rb_autoload
rb_autoload_str may be safer by preventing premature GC. It
can also be more efficient by passing a pre-frozen string that
can be deduped using r... -
- Do you want to **add** `NameError#local_variables`?
-
06:15 AM Feature #11777 (Closed): Change NameError#local_variables to return the list of local variables where the method is raised
- Sasada-san and I talked about this briefly a few weeks ago, but I also wanted to let others know about this.
This change will make it possible to pull out the list of local variables where the exception is raised without TracePoint. T... -
- * test/io/console/test_io_console.rb (test_getpass): wait slave
thread.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52910 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:28 PM Revision a2e025a7 (git): introduce rb_autoload_str to replace rb_autoload
- rb_autoload_str may be safer by preventing premature GC. It
can also be more efficient by passing a pre-frozen string that
can be deduped using rb_fstring. Common autoload callers (e.g.
rubygems, rdoc) already use string literals as th... -
- * hash.c (env_fetch): yield coerced string.
* hash.c (env_assoc): return coerced string.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52908 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
11:53 AM Bug #11776: dig and custom objects
- There is already a spec for this behavior though :)
https://github.com/ruby/rubyspec/blob/master/core/hash/dig_spec.rb -
- Although currently undocumented and untested, it is possible to `dig` objects of any class that implements `dig`:
class Foo
def dig(x, *)
40 + x
end
end
{hello: Foo.new}.dig(:hello, 2) # => 42
... -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52907 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52906 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 09:28 AM Revision 52047a14 (git): * test/webrick/test_cgi.rb (TestWEBrickCGI#test_cgi): gave up the test
- of binary path info test on Windows because the test had passed
occasionally as the comment said.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52905 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 07:22 AM Revision 9fc965ee (git): * test/fileutils/test_fileutils.rb: add debug output to investigate the error that occur at random on Windows CI.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52904 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/io/console/console.c (console_getpass): print prompt to
stderr when reading from stdin.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52903 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/io/console/console.c (console_getpass): add IO#getpass
method.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52902 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Seems that OpenSSL doesn't tell what kind failure happened.
-
- I feel that either `dig` should be safe only against `nil` somewhere in the digging path (a bit like `&.`), or it's should always safe, even when digging through unexpected objects or indices.
Currently:
{a: 'hello'}.dig(:a, :b... -
- ~~~ruby
class A
undef :to_s
def to_str
"hello world"
end
end
"#{A.new}"
#NoMethodError: undefined method `to_s' for #<A:0x00000000dbea70>
"" + A.new
# => "hello world"
~~~
Using `+` to call `to_str` feels like... -
- Is there any update on this feature? In Ruby 2.2.3 I still run into a problem where the unary & can not be used when the method was added with a refinement, such as the following:
```ruby
module Example
refine String do
def p... -
- * test/ruby/test_env.rb (TestEnv#test_utf8): escape non-ASCII
string with \u explicitly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52901 b2dd03c8-39d4-4d8f-98ff-823fe69b080e