Activity
From 11/17/2019 to 11/23/2019
11/23/2019
-
08:20 PM Bug #16361: TestEnv#test_fetch failure
- mame (Yusuke Endoh) wrote:
> How did you run the test?
I am using the snapshot to execute the test suite. Therefore I assume that did_you_mean gem is available and the test suite should pass in this configuration. -
12:34 AM Bug #16361: TestEnv#test_fetch failure
- How did you run the test? Currently, bundled gems should be unavailable in `make test-all`, and some tests don't assume that bundled gems are loaded.
Currently, did_you_mean is a bundled gem, so should not be loaded in `make test-all... -
07:06 AM Revision b5634392 (git): Show include directive differences only when under git
- When building from tarballs, the source directory is not a git
repository. -
02:41 AM Revision 9318e1ff (git): Use realpath to try to fix failures with symlinks
-
- Closing as per OP's request. Thanks.
11/22/2019
-
10:22 PM Revision 818708ed (git): Stop using undefined matrix.os for macOS
- and use github.workflow instead. Applied a similar change to MJIT too.
-
08:44 PM Revision b0614a0f (git): Tracer.set_get_line_procs should support block and Proc object
- Original Tracer.set_get_line_procs is implemented by
"def set_get_line_procs(p = proc)". It means that original
Tracer.set_get_line_procs supports block and Proc object. -
- Original Tracer.add_filter is implemented by "def add_filter(p = proc)". It
means that original Tracer.add_filter supports block and Proc object. -
08:42 PM Revision 8e743fad (git): Count pinned slots using only bitmap
- This is significantly faster than checking BUILTIN_TYPEs because we
access significantly less memory. We also use popcount to count entire
words at a time.
The only functional difference from the previous implementation is that
T_ZOMBIE... -
- Previously we would count the pinned objects on each comparison. Since
sorting is O(N log N) and we calculated this on both left and right
pages on each comparison this resulted in a extra iterations over the
slots. -
-
08:04 PM Bug #16362: Unable to build Ruby 2.6.5 on Manjaro Linux 18.1.3
- Sorry, I discovered that something was resetting my CFLAGS. Please close this.
-
- Steps to reproduce:
```
$ curl -OL https://cache.ruby-lang.org/pub/ruby/2.6/ruby-2.6.5.tar.gz
$ tar xvf ruby-2.6.5.tar.gz
$ cd ruby-2.6.5
$ ./configure
$ make
```
`./configure` summary:
```
* Installation prefix: /usr/... - 04:58 PM Revision 144bff43 (git): * 2019-11-23 [ci skip]
-
- `fatal: not a git repository (or any of the parent directories): .git`
-
- `git --version` failed as expected when git is not installed,
but unexpectedly pass when git installed and pwd is not in git working directory.
So use `git rev-parse` instead, and it failed when git installed too. -
- emscripten fails to compile ruby due to lack of this.
-
- I am facing following test suite error:
~~~
1) Failure:
TestEnv#test_fetch [/builddir/build/BUILD/ruby-2.7.0-f9d20a1bf1/test/ruby/test_env.rb:123]:
[ruby-core:56062] [Feature #8649].
Expected Exception(KeyError) was raised, but ... -
01:43 PM
Bug #16359 (Closed): Psych cannot build against system libyaml.
- Applied in changeset commit:git|994435d0efa9931d0475de923c4e6c227d03e398.
----------
Revert "Update dependencies"
This reverts commit e1b234148829f65bea9f5ecc7018beb782ea6023.
This allows to build Psych against system libyaml again on... -
- The attached patch which reverts the Psych part of [1] appears to fix the issue for me.
[1]: https://github.com/ruby/ruby/commit/e1b234148829f65bea9f5ecc7018beb782ea6023 -
- Just to be sure that we are building Ruby in Fedora against system libyaml library, the first step is to remove bundled libyaml contained in Psych [1]. Now the build started to fail:
~~~
make[2]: Entering directory '/builddir/build/B... - 01:42 PM Revision 994435d0 (git): Revert "Update dependencies"
- This reverts commit e1b234148829f65bea9f5ecc7018beb782ea6023.
This allows to build Psych against system libyaml again on Fedora.
[Bug #16359] -
12:37 PM Misc #16360 (Closed): Enabling IBM PowerPC/Z cases in Travis CI
- We added `arm64-linux` and `arm32-linux` cases to Travis CI by [the ticket](https://bugs.ruby-lang.org/issues/16234).
The `arm32-linux` case is going to be stable after [this pull-request](https://github.com/ruby/ruby/pull/2686) will be... -
10:05 AM Revision 35608760 (git): Add github repo to remove_tag
-
- 04:58 AM Revision f9d20a1b (git): * 2019-11-22 [ci skip]
-
- Try to fix download error on Solaris CI
https://rubyci.org/logs/rubyci.s3.amazonaws.com/unstable11x/ruby-master/log/20191121T162422Z.fail.html.gz
```
tool/downloader.rb:243:in `rescue in download': failed to download config.guess (Runti...
11/21/2019
-
04:21 PM Bug #16358 (Third Party's Issue): rails 6.0.1 db:migrate failure on Mac OS 10.13.6 using mysql2 gem
- This appears to be a bug in the mysql2 gem, please report it to their bug tracker: https://github.com/brianmario/mysql2/issues
```
/usr/lib/system/libsystem_platform.dylib(_sigtramp+0x1a) [0x7fff6241cf5a]
/Users/nukeguy5/.rbenv/vers... -
11:27 AM Bug #16358 (Third Party's Issue): rails 6.0.1 db:migrate failure on Mac OS 10.13.6 using mysql2 gem
- Hello,
I got a segmentation fault while trying to do a migration to a mysql database. I've tried versions 0.4.10 and 0.5.1 of the mysql2 gem. I have included my Gemfile, console output, and Diagnostic Reports file regarding the issue.... -
- > There is one issue on the Travis arm32 environment. I added it as allow_failures.
I sent a PR to fix the issue on the Travis arm32 environment.
https://github.com/ruby/ruby/pull/2686
Let me explain about the issue and why this h... -
-
01:59 PM Feature #16352: Modify Marshal to dump objects larger than 2 GiB
- > I don't understand the motivation of this limit and has a great impact in libraries that need to serialize large objects as numeric matrix.
> ...
Shyouhei already pointed out the historic reason. I believe you can quite easily convinc... -
- > But names (e.g. literal :* and :&) should be excluded from parameters output anyways, right?
I am not matz, nor among the core team, but I think that the general intention is that the
information displayed here (e. g. via #inspect)... -
-
- note: GNU make only.
-
01:32 AM Bug #14241 (Closed): Time.strptime() doesn't support the directive "%W".
- Applied in changeset commit:git|a9d4f2d03c847ec1c89dc03a5076a9fa29ffa61f.
----------
Support %U/%u/%W/%w/%V/%g/%G formats in Time.strptime
Most of these formats were documented as supported, but were not
actually supported. Document th... -
- Applied in changeset commit:git|a9d4f2d03c847ec1c89dc03a5076a9fa29ffa61f.
----------
Support %U/%u/%W/%w/%V/%g/%G formats in Time.strptime
Most of these formats were documented as supported, but were not
actually supported. Document th... -
- Most of these formats were documented as supported, but were not
actually supported. Document that %g and %G are supported.
If %U/%W is specified without yday and mon/mday are not specified,
then Date.strptime is used to get the appropr...
11/20/2019
-
-
- https://github.com/ruby/reline/commit/09d370bdc19e62f0a27c2240e19b07963afd922f
-
-
-
-
08:58 PM Feature #16356: Method#inspect of argument forwarding
- @jeremyevans0 thanks for the explanation, I suspected there is something important about missing `:keyrest` there :)
But names (e.g. literal `:*` and `:&`) should be excluded from `parameters` output anyways, right?.. -
- zverok (Victor Shepelev) wrote:
> `#inspect` just follows whatever `#parameters` say.
> ...
That's not how `...` is implemented, though. It is implemented so that:
```ruby
def a(...)
b(...)
end
```
means
```ruby
ruby2... -
- `#inspect` just follows whatever `#parameters` say.
But I indeed find that `#parameters` return value is kinda weird for this case:
```
./ruby --disable-gems -e "def m(...); end; p method(:m).parameters"
[[:rest, :*], [:block, :... -
- Current behavior includes `(**, &&)`.
Is this intentional?
```
% ruby -e 'def mf(...);end;p method(:mf)'
#<Method: main.mf(**, &&) -e:1>
```
I added tests of current behavior at https://github.com/ruby/ruby/commit/777973084e599... -
08:07 PM Feature #16355: Raise NoMatchingPatternError when `expr in pat` doesn't match
- Agree, that it could save users from unexpected behavior.
On the other hand, raising an exception drastically limits the application of online pattern matching: it won't be possible to use it with `if ... else ...` or in `select/filte... -
12:58 AM Feature #16355 (Closed): Raise NoMatchingPatternError when `expr in pat` doesn't match
- Currently, single line pattern matching(`expr in pat`) returns true or false.
```
[1, 2, 3] in [x, y, z] #=> true (with assigning 1 to x, 2 to y, and 3 to z)
[1, 2, 3] in [1, 2, 4] #=> false
```
I think `expr in pat` should rais... -
07:38 PM Revision 1197a036 (git): Add a proper cast to pass JIT tests on mswin.
- https://ci.appveyor.com/project/ruby/ruby/builds/29001248/job/ye80bsrmewdgw294
-
- 05:44 PM Revision 9d6f7882 (git): Refactor filter_backtrace
- 05:44 PM Revision 04d0d93e (git): Fix filter_backtrace for context-mode 0
-
-
- 03:48 PM Revision f835a74d (git): * 2019-11-21 [ci skip]
-
03:47 PM Revision 6723aa07 (git): Change argument `Proc` to `#call` defined object.
- This is the same as the behavior of Readline.
-
-
11:14 AM Bug #16357 (Closed): `Segmentation fault (core dumped)` or `[BUG] object allocation during garbage collection phase`
- How to reproduce:
```
+$ tree .
.
├── config.ru
├── Gemfile
└── Gemfile.lock
0 directories, 3 files
+$ cat config.ru
require 'json'
require 'rack'
run ->(env) do
begin
req = Rack::Request.new(env)
JSON.load(... -
- https://github.com/seattlerb/minitest/pull/798 is closed.
-
- You can use `String#-@` and `String#+@` in method chain.
```ruby
"foo"[email protected]
[email protected]?
``` -
-
-
-
- `rb_resolve_refined_method_callable` is referenced in
`refine_sym_proc_call`, even when pre-compiling mjit header on
mswin. -
- Warned at making precompiled header on mswin.
```
building rb_mjit_header-2.7.0.pch
vm.c
d:\a\ruby\ruby\src\vm_args.c(1117): warning C4047: '=': 'const rb_callable_method_entry_t *' differs in levels of indirection from 'int'
rb_mjit_he... -
06:54 AM Revision 7608baf9 (git): re-add function prototypes
- This commit reverts a part of 0e8219f591f3f17cb7ee361e8a60dbef08145883
which broke icc. See also https://rubyci.org/logs/rubyci.s3.amazonaws.com/icc-x64/ruby-master/log/20191120T010006Z.fail.html.gz -
-
- This one can be closed (`Enumerator#produce` was implemented in 2.7)
-
- @hsbt
>> what's the maintenance status of the upstream?
> ...
I just noticed my documentation patches [#349](https://github.com/flori/json/pull/349) and [#347](https://github.com/flori/json/pull/347) and clarification request [#348... -
- merged. Thank you!
-
- @ko1 I've updated the PR to use `...` and `_`, and rebased it from recent `master`.
-
-
-
- Example:
def m(a, b=nil, *c, d:, e: nil, **rest, &block)
end
p method(:m)
#=> #<Method: m(a, b=<default>, *c, d:, e: <default>, **rest, &block) ...> -
- This behaviour has been there since the beginning. No ruby version since 0.49 has successfully dumped such long string. Same thing happens for a very big bignum, a very long array, a class that has very long classpath (Q::W::E::R::...)...
-
-
-
- meth do # the preceding token of "do" has EXPR_CMDARG
end
meth() do # the preceding token of "do" has EXPR_ENDFN
end
11/19/2019
-
-
-
- Applied in changeset commit:git|ff41663403d3eb76d95f465cb94e14d2faaa04d1.
----------
Fix memory corruption in Enumerable#reverse_each [ruby-dev:50867] [Bug #16354] -
- Enumerable#reverse_eachのブロック呼び出し中に、対象のEnumerableをto_aしたものを捕まえてサイズを変更するとSEGVすることがあります。
```
$ ruby -e '(0...1000).reverse_each {|i| i.inspect; ObjectSpace.each_object(Array) {|a| a.clear if a.length == 1000 }}'
-e:1: [BUG] Segmentatio... -
-
- @ko1 I happened to sit next to Matz on speakers' lunch at RubyConf and asked him (just in case). He agreed to both of your proposals, so I'll change it in a day or two in my patch :)
Thank you! -
- Great patch!
I think `<default>` is too long. How about `...`?
```
def foo9 a, b, o1=nil, *args, p1, k1:nil, rk1:, **kw, &bl
end
p method(:foo9)
#<Method: main.foo9(a, b, o1=..., *args, p1, rk1:, k1:..., **kw, &bl) /home/ko1/src/... -
- This reverts commit 0b8c73aa65add5c57b46b0cfdf4e661508802172, which
seems breaking RVALUE consistency check. - 03:07 PM Revision f3c98035 (git): * 2019-11-20 [ci skip]
-
-
- and rename from b.rb
[ruby-core:95055] [Bug #16177] -
-
- Sorry, we can not write enough discussion log.
At least for me, real time English logging is hard.
I hope enough information are added for each ticket.
Good idea or your help is welcome. -
- I fixed this issue, but no test. can anyone write it?
-
- Applied in changeset commit:git|a5fe08fdd9d11f12a6837291ee588ab933a823b6.
----------
care about TAG_FATAL.
TAG_FATAL represents interpreter closing state and ec->errinfo
contains FIXNUM (eTerminateSignal, etc). If we need to change the... -
- TAG_FATAL represents interpreter closing state and ec->errinfo
contains FIXNUM (eTerminateSignal, etc). If we need to change the
state, then errinfo is also changed because TAG_RAISE assumes that
ec->errinfo contains a Exception object.
... -
- Please backport 2a477e0e444de6344048101466fb9189b9defddc to ruby_2_5.
It may avoid occasional errors on macos.
https://github.com/ruby/actions/runs/309307228#step:17:201
```
1) Error:
FTPTest#test_retrbinary_read_timeout_not_exc... -
- Get rid of races in parallel configuration when using the
ext/Setup file. -
- Some minor optimizations.
Calculating -------------------------------------
ours trunk
vm2_regexp 8.479M 8.346M i/s - 6.000M times in 0.707612s 0.718916s
vm2_regexp_invert ... -
- Dan0042 (Daniel DeLorme) wrote:
> > - Possibility #3: renders SyntaxError. This requires a massive rewrite of our parser. Theoretically possible but not in practice.
> ...
It may be possible to know at runtime whether a literal block... -
- https://github.com/seattlerb/minitest/pull/798 is closed
-
- These functions are used from within a compilation unit so we can
make them static, for better binary size. This changeset reduces
the size of generated ruby binary from 26,590,128 bytes to
26,584,472 bytes on my macihne. - 02:40 AM Revision 78e266da (git): Clarify documentation for `InstructionSequence#compile`.
- We incorrectly assumed that the `file` argument should be the file name and
caused https://github.com/scoutapp/scout_apm_ruby/issues/307 because
exception backtrace did not contain correct path. This documentation
clarifies the role of t...
11/18/2019
-
06:01 PM Feature #13083: Regexp#{match,match?} with a nil argument are deprecated and will raise a TypeError in Ruby 3.0
- knu (Akinori MUSHA) wrote:
> I'm a bit surprised and confused. The change that has been made is not what this issue was originally about, and actually the opposite, I think.
Per matz's decision: https://bugs.ruby-lang.org/issues/130... -
01:36 PM Feature #13083: Regexp#{match,match?} with a nil argument are deprecated and will raise a TypeError in Ruby 3.0
- I'm a bit surprised and confused. The change that has been made is not what this issue was originally about, and actually the opposite, I think.
I believe many of us have got used to the original behavior, that is, methods of a Regex... -
- `stty` called in `Reline::ANSI.deprep` command shows the following
error message on macOS Apple Terminal, with some settings.
```
$ LANG=C irb
irb(main):001:0>
stty: 'standard input': unable to perform all requested operations
stty: 'st... -
-
-
-
-
- 03:27 PM Revision 9067f43c (git): * 2019-11-19 [ci skip]
-
-
-
-
-
01:16 PM Feature #15563: #dig that throws an exception if a key doesn't exist
- Removed the two discussion points in the previous edit. This edit adjusts the last sentence to reflect this.
-
- Changed naming from `#dig_e` to `#traverse`. Removed alternative options, and kept the strict version since `#fetch` is also strict. Possibility to expand upon this with a block or `:default` keyword argument is possible, but should be i...
-
11:39 AM Feature #16352 (Open): Modify Marshal to dump objects larger than 2 GiB
- Using a gem called Numo-array to handle matrix operations, I found the following error while saving a large matrix:
```
in `dump': long too big to dump (TypeError)
```
Github thread is https://github.com/ruby-numo/numo-narray/iss... -
-
-
-
- Suppress compiler warnings.
-
- > Some internal transient heap structs moved to the header file now leaks into all other reference sites where this source file (transient_heap.c) as previously just used for API
not a big issue, but I don't want to expose them...
-
-
-
- I think this is a documentation bug, since the comment makes it explicit that shifting is always disabled if shift_age is 0. I submitted a pull request to update the documentation: https://github.com/ruby/logger/pull/43 .
-
03:42 AM Feature #16348: Proposal: Symbol#start_with?, Symbol#end_with?, and Symbol#include?
- I personally think that we should be restrictive in adding new methods to `Symbol`. Otherwise, this very quickly becomes a slippery slope, and the distinction between `Symbol` and `String` becomes less and less clear.
I was personally... -
- naruse (Yui NARUSE) wrote:
> ```diff
> ...
`str` should be `sym`. -
-
- add casts to avoid compile error.
http://ci.rvm.jp/results/trunk_clang_39@silicon-docker/2402215 -
- Array#pack uses `opt_invokebuiltin_delegate_leave` now.
-
- opt_invokebuiltin_delegate and opt_invokebuiltin_delegate_leave
invokes builtin functions with same parameters of the method.
This technique eliminate stack push operations. However, delegation
parameters should be completely same as giv... -
- https://travis-ci.org/ruby/ruby/jobs/613242256#L2205
11/17/2019
-
- Looks like the forwardable keyword argument support was never merged. My previous attempt, developed before `ruby2_keywords`, added `**kw` to method definition and method calls on 2.7+. I've updated the pull request to use `ruby2_keywo...
-
- I merged these changes at commit:4c7dc9fbe604cc0c8343b1225c96d4e5219b8147 . Still one failing CI test, but the same one that is failing in the master branch for a few days, related to makefile dependencies.
- 11:00 PM Revision b7539298 (git): * remove trailing spaces. [ci skip]
-
-
-
- rb_eval_cmd takes a safe level, and now that $SAFE is deprecated,
it should be deprecated as well.
Replace with rb_eval_cmd_kw, which takes a keyword flag. Switch
the two callers to this function. -
- Ruby 2.7 deprecates taint and it no longer has an effect.
The lack of taint support should not cause a problem in
previous Ruby versions. -
- Ruby 2.7 deprecates taint and it no longer has an effect.
The lack of taint support should not cause a problem in
previous Ruby versions. -
- Ruby 2.7 deprecates taint and it no longer has an effect.
The lack of taint support should not cause a problem in
previous Ruby versions. -
- Ruby 2.7 deprecates taint and it no longer has an effect.
The lack of taint support should not cause a problem in
previous Ruby versions.
Still untaint the tmpdir object on Ruby <2.7, as returning
a tainted string there could cause prob... -
- Ruby 2.7 deprecates taint and it no longer has an effect.
-
- Ruby 2.7 deprecates taint and it no longer has an effect.
-
-
- This removes the related tests, and puts the related specs behind
version guards. This affects all code in lib, including some
libraries that may want to support older versions of Ruby. -
- This removes the security features added by $SAFE = 1, and warns for access
or modification of $SAFE from Ruby-level, as well as warning when calling
all public C functions related to $SAFE.
This modifies some internal functions that to... - 06:25 PM Revision 7b6a8b5b (git): * 2019-11-18 [ci skip]
-
-
- nobu (Nobuyoshi Nakada) wrote:
> By changing the last calling line as the following with making that `initialize` method public, you could observe the same numbers as `FooWithPlainParams`.
> ...
I'd like to add a note: `allocate.initia... -
- `FooWithKeyword#initialize` method is not called directly, but via `Class#new`.
A `Hash` is needed to delegate the keyword arguments.
By changing the last calling line as the following with making that `initialize` method public, you c... -
12:54 PM Bug #16351 (Closed): Why do Keyword arguments to initialize allocate a Hash, but not for other methods?
- Hello, while working on improving memory allocations in one of my apps, I stumbled upon the following behavior. I measured three different ways of passing variables to a new `Object`, using plain params, using a hash and using keyword ar...
-
- https://github.com/ruby/irb/commit/0180dc74bc
-
- https://github.com/ruby/irb/commit/4945d0e676
-
- https://github.com/ruby/reline/commit/d57c7ea252
-
- ```diff
diff --git a/string.c b/string.c
index 554aabad4b..d53fdc89fd 100644
--- a/string.c
+++ b/string.c
@@ -11166,6 +11166,64 @@ sym_swapcase(int argc, VALUE *argv, VALUE sym)
return rb_str_intern(rb_str_swapcase(argc, argv... -
- sam.saffron (Sam Saffron) wrote:
> A lot faster than no warning at all? Was just concerned looking up the callsite and a hashtable lookup might have some sort of cost. Also this technically will leak memory for the lifetime of the proce... - 04:12 AM Revision a8e4a9f0 (git): * 2019-11-17 [ci skip]
-