Menu

Code Commit Log


Commit Date  
[r7725] (HEAD) by chassell

resetting tag community_3_5_2 one more time

2022-07-15 20:44:58 Tree
[r7724] by chassell

fix problem that accidentally allows tapes to be overwritten

2022-07-15 20:43:27 Tree
[r7723] by chassell

update tag for community_3_5_2

2022-07-14 03:16:34 Tree
[r7722] by chassell

add a tag for community_3_5_2

2022-07-14 03:13:21 Tree
[r7721] by chassell

remove files re-created upon autogen and modify VERSION to 3.5.2

2022-07-14 03:12:18 Tree
[r7720] by chassell

disable auto-label from claiming non-amanda and "other-config" labels

2022-07-14 02:57:33 Tree
[r7719] by hitens

device-src/s3-device.c - Added debug logs

2019-02-14 10:52:30 Tree
[r7718] by hitens

device-src/s3.c
device-src/s3-device.c
Debug messages added for Glacier.

2019-02-13 06:18:57 Tree
[r7717] by hitens

Debug Branch

2019-02-12 06:15:11 Tree
[r7716] by hitens

client-src/rundump.c - Review comments fixes

Fixes done for security issues review comments.
Comments provided by Dustin. J. Mitchell-
1. It would probably be better to use the preprocessor conditionals (`#if defined(DUMP)`, etc.) here instead of trying to figure out which program is in use at runtime. If an Amanda install is set up with, say, XFSDUMP=/opt/fs/old-xfsdump, then the code above would never call `validate_xfsdump_options`, even though it's clear that it's driving xfsdump.
2. Why not have the `validate_..` functions call `error(..)` themselves, rather than printing something (which might get lost) and then giving a blank error message (or more oddly, a single space character??) here? Alternately, `validate_..` could return an allocated error message.

Fixed issue:
1. Using getopt() to check the command option failed to check the blacklist option if the command is provided like:
/usr/lib/amanda/rundump NOCONFIG xfsdump -0f /dev/null /sys -F "echo test"
It was working fine when the command is provided like:
/usr/lib/amanda/rundump NOCONFIG xfsdump -0f /dev/null -F "echo test" /sys

2019-02-07 07:31:09 Tree
Older >
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.