From: Darrick H. <dha...@dj...> - 2009-09-25 21:39:55
|
Do you have a specific commit in mind? All of the libusb-1.0 related changes were required to go. We're not using libusb-1.0. If there are changes which contribute positively towards a stable release, I'd be all ears for knowing which lines should go back in. Philip A. Prindeville wrote: > Ok, so that accounts for one line... What about all of the rest of the > changes that were needlessly backed out? > > > On 09/25/2009 02:01 PM, Darrick Hartman wrote: >> Philip, >> >> usbutils has been built this way (without using zlib) for a very long >> time (all of 0.6 for sure, probably longer). If we don't link against >> zlib, the .gz file is never created. Granted, in 0.6 with did not >> explicitly state --without-zlib, but that's because the order of >> compilation was fixed in trunk. >> >> pciutils works the same way. All I know is if usbutils and pciutils are >> linked against zlib, that both lspci and lsusb take about 30-40 seconds >> on more limited hardware. >> >> >> >> Philip A. Prindeville wrote: >> >>> You know what? You want to gratuitously diverge the branch from trunk, >>> that's your call. >>> >>> I don't recommend it. >>> >>> Deleting the usb.ids.gz file saves room in the ramfs, which as you >>> remember you said yesterday was getting crowded... >>> >>> >>> >>> On 09/25/2009 01:20 PM, Darrick Hartman wrote: >>> >>>> Philip, >>>> >>>> What items won't build properly with the way 0.7 is right now? Neither >>>> Lonnie or I are seeing any breakage with the current status. >>>> >>>> What does compiling against zlib get us if we're not using the generated >>>> file? My understanding is that not linking against zlib or deleting the >>>> usb.ids.gz file results in the same outcome. If that's not correct, >>>> please clarify. >>>> >>>> Philip A. Prindeville wrote: >>>> >>>> >>>>> So, can you make the necessary reversions please? >>>>> >>>>> -Philip >>>>> >>>>> >>>>> On 09/24/2009 11:42 AM, Philip A. Prindeville wrote: >>>>> >>>>> >>>>>> Since you didn't ask before making the changes, I figured you had that >>>>>> all worked out... >>>>>> >>>>>> Guess not. >>>>>> >>>>>> All you *really* needed to do, was switch "libusb-compat" back to >>>>>> "libusb" as a dependency, change "libusb-1.0" into "libusb" (or >>>>>> "-lusb-1.0" into "-lusb") wherever you saw that as a linker flag, >>>>>> disable BR2_PACKAGE_LIBUSB-COMPAT, and revert the version # and URL in >>>>>> package/libusb/libusb.mk (maybe also the setting for LIBUSB_CAT). >>>>>> >>>>>> That was it. >>>>>> >>>>>> The patch to libusb-config for instance is not needed, and should have >>>>>> been left out. And the extra flags being passed into Make, the shuffling >>>>>> of files, etc. was totally unnecessary and just confuses the issue. >>>>>> >>>>>> The patch to usbutils's makefile is correct, and fixes a bug... as well >>>>>> as being benign with earlier versions. >>>>>> >>>>>> And the fix leaving the linkage with zlib, but removing the usb.ids.gz >>>>>> file is the correct one: what install a file you're unequipped to read? >>>>>> That just wastes space... >>>>>> >>>>>> >>>>>> >>>>>> On 09/24/2009 05:11 AM, Lonnie Abelbeck wrote: >>>>>> >>>>>> >>>>>> >>>>>>> Philip, >>>>>>> >>>>>>> I reverted usb to trunk-3312 in 0.7. >>>>>>> >>>>>>> The resulting 0.7 build appears to work properly. >>>>>>> >>>>>>> If you have any specific cleanups that were a part of your usb-compat >>>>>>> changes I'm all ears. >>>>>>> >>>>>>> Lonnie >>>>>>> >>>>>>> >>>>>>> On Sep 23, 2009, at 8:02 PM, Philip A. Prindeville wrote: >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>>> Some of what you're backing out is actually needed cleanup to broken >>>>>>>> makefiles. >>>>>>>> >>>>>>>> >>>>>>>> On 09/23/2009 05:16 PM, abe...@us... wrote: >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> Revision: 3327 >>>>>>>>> http://astlinux.svn.sourceforge.net/astlinux/?rev=3327&view=rev >>>>>>>>> Author: abelbeck >>>>>>>>> Date: 2009-09-24 00:16:45 +0000 (Thu, 24 Sep 2009) >>>>>>>>> >>>>>>>>> Log Message: >>>>>>>>> ----------- >>>>>>>>> Remove libusb-compat from 0.7 branch >>>>>>>>> >>>>>>>>> Modified Paths: >>>>>>>>> -------------- >>>>>>>>> branches/0.7/astlinux.config >>>>>>>>> branches/0.7/package/Config.in >>>>>>>>> branches/0.7/package/apcupsd/apcupsd.mk >>>>>>>>> branches/0.7/package/dahdi-linux/dahdi-linux.mk >>>>>>>>> branches/0.7/package/dahdi-tools/dahdi-tools.mk >>>>>>>>> branches/0.7/package/lcdproc/lcdproc.mk >>>>>>>>> branches/0.7/package/libftdi/libftdi.mk >>>>>>>>> branches/0.7/package/libusb/libusb.mk >>>>>>>>> branches/0.7/package/usbutils/usbutils.mk >>>>>>>>> branches/0.7/package/zaptel/zaptel.mk >>>>>>>>> >>>>>>>>> Added Paths: >>>>>>>>> ----------- >>>>>>>>> branches/0.7/package/libusb/libusb-config >>>>>>>>> >>>>>>>>> Removed Paths: >>>>>>>>> ------------- >>>>>>>>> branches/0.7/package/libusb-compat/ >>>>>>>>> branches/0.7/package/usbutils/usbutils-makefile.patch >>>>>>>>> >>>>>>>>> > > > ------------------------------------------------------------------------------ > Come build with us! The BlackBerry® Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9-12, 2009. Register now! > http://p.sf.net/sfu/devconf > _______________________________________________ > Astlinux-devel mailing list > Ast...@li... > https://lists.sourceforge.net/lists/listinfo/astlinux-devel > > Donations to support AstLinux are graciously accepted via PayPal to pa...@kr.... |