Menu
▾
▴
#816 [PATCH] Only use FE_UNDERFLOW if it is defined
Hello!
Please excuse me if this is not the proper way to submit a patch, but I must admit I am not familiar with the sourceforge ways...
Gnuplot fails to build on architectures that do not handle the underflow floating-point exception, such as MIPS soft-float. This is because complexfun.c carries the implicit (and incorrect) assumption that, if the header fenv.h is available, then it must define FE_UNDERFLOW. In reality, the latter is only defined if the implementation can handle the exception.
The problem was uncovered by the autobuilders of the Buildroot project. The patch below fixes the following build failures (see the files build-end.log):
- https://autobuild.buildroot.org/results/76a97b62e01c9778b31c52ad8d391ec54158643e
- https://autobuild.buildroot.org/results/184d3e6ff0c2edc6511c55c858e7f8567a6c4738
- https://autobuild.buildroot.org/results/ce018eef26faca25c260be94afc49e06a8b6ba2d
- https://autobuild.buildroot.org/results/d43be86091c9bd9163c145264151532f0f485528
- https://autobuild.buildroot.org/results/8568504e6b217c75f3309f5389ad55dd338d8600
The patch was made against tag 6.0.1, and it applies cleanly on master.
Regards,
Edgar Bonet.
------------------------------------------------------------------ >8 --
From: Edgar Bonet <bonet@grenoble.cnrs.fr>
Subject: [PATCH] Only use FE_UNDERFLOW if it is defined
According to fenv(3), the macro FE_UNDERFLOW is defined by fenv.h only
if the implementation supports handling of the underflow exception. Do
not assume the presence of fenv.h implies FE_UNDERFLOW is defined.
Signed-off-by: Edgar Bonet <bonet@grenoble.cnrs.fr>
---
src/complexfun.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/complexfun.c b/src/complexfun.c
index a87d773c5..1d3c9aaf0 100644
--- a/src/complexfun.c
+++ b/src/complexfun.c
@@ -86,7 +86,7 @@
int_error(NO_CARET, "%s: error present on entry (errno %d %s)", who, errno, strerror(errno));
#endif
-#ifdef HAVE_FENV_H
+#ifdef FE_UNDERFLOW
#define handle_underflow( who, var ) \
if (errno) { \
if (fetestexcept(FE_UNDERFLOW)) { \
--
2.34.1
Applied. Thanks.