Menu

#40 ADF/AMS output support

v1
pending
nobody
adf (1) ams (1)
5
2023-09-14
2023-07-05
Diego Garay
No

Hi all,
I have observed that the support for ADF output files was not working too well: for geometry optimizations, only the initial geometry was grabbed, without actually being able to visualize the optimized structure. Moreover, vibrational displacements were being applied to this initial structure, which was not consistent.

Additionally, as newer versions of the code are now named Amsterdam Modeling Suite (AMS) instead of ADF, these files were also not properly supported.

This patch allows geometries throughout the optimization to be properly captured for both AMS and ADF, while also including the bonding energy as a model property.

1 Attachments

Discussion

  • Bob Hanson

    Bob Hanson - 2023-09-12

    Checking this now. Please send a few test files.

     
  • Bob Hanson

    Bob Hanson - 2023-09-12

    private String bondingEnergy = null;

    is not used?

     
    • Diego Garay

      Diego Garay - 2023-09-14

      Effectively, it is not used: I added it to have the final energy value stored, but probably it is not necessary.

       
  • Bob Hanson

    Bob Hanson - 2023-09-12

    ported also to Jmol-SwingJS (double precision)

     
  • Bob Hanson

    Bob Hanson - 2023-09-12

    I have checked in modified code that subclasses AdfReader as AmsReader. I have not tested it. Please test.

     
  • Bob Hanson

    Bob Hanson - 2023-09-12
    • status: open --> pending
     
  • Bob Hanson

    Bob Hanson - 2023-09-13

    checked in a series of changes using only older ADF sample data. This still needs testing with newer AMS files, particularly for readFrequencies(), for which I do not have an example file.

    This is released as Jmol 16..1.39 and 16.1.40 (Jmol-SwingJS on GitHub)

     
  • Diego Garay

    Diego Garay - 2023-09-14

    Adding two test files for geometry optimization + frequencies with both ADF2019 and AMS2021 (no access to later versions for the moment)

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.