Menu

#5701 TOOLS: compress_sci skips last resource?

Tools
closed-fixed
None
5
2011-05-29
2011-05-15
agf
No

The location is
scummvm-tools/engines/sci/compress_sci.cpp
CompressSci::execute()
The do-while loop counting the number of resources in the file

resourceCount is incremented after the end-of-file check

On the last resource, the loop is exited without incrementing resourceCount.

This appears to me to mean the last resource is skipped, and not added to the compressed file.

Unfortunately I can't test this as I only have one game with files this code recognizes (KQ6) and I already deleted the original RESOURCE.AUD and RESOURCE.SFX files after compressing them and confirming they appeared to work.

Discussion

  • agf

    agf - 2011-05-15

    Actually I could test this by looking at the number of entries for RESOURCE.AUD or RESOURCE.SFX in the RESOURCE.MAP and comparing it to the translation table at the beginning of each file, but I don't know the format of that MAP so maybe tomorrow.

     
  • Willem Jan Palenstijn

    You're absolutely right. Thanks; well spotted!

    (The text in my copy of KQ6 that's skipped by this is: "Alexander watches helplessly as the guards descend upon him.")

     
  • Willem Jan Palenstijn

    • assigned_to: nobody --> wjpalenstijn
    • status: open --> closed-fixed
     
  • Willem Jan Palenstijn

    • summary: Tools: compress_sci skips last resource? --> TOOLS: compress_sci skips last resource?
     
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.