wxlua-users Mailing List for wxLua

Hi,

in the override function for wxImage::SetAlpha() in wxcore_override.hpp there is
the following code:

size_t size = 3*self->GetWidth()*self->GetHeight();
memcpy(self->GetData(), data, wxMin(len, size));  

I think this is wrong because alpha channel data is only one byte per pixel.
Thus, the code above is likely to crash if the user calls SetAlphaData() with
a string containing more than width*height bytes. Instead, it should be:

size_t size = self->GetWidth()*self->GetHeight();
memcpy(self->GetData(), data, wxMin(len, size));  

-- 
Best regards,
 Andreas Falkenhahn                          mailto:an...@fa...

Hi,

there is the following code in scribble.wx.lua:

	local s = "Set pen color : "..colourWinColours[i]

	if colourWin:GetToolTip() ~= s then
       	colourWin:SetToolTip(s)
	end

But AFAICS, wxWindow::GetToolTip() will never return a string,
but will always push a value of type "userdata" on the stack. Thus,
the condition check is superfluous because it is always TRUE and
SetToolTip() will always be called.

Correct me if I overlooked something here...

-- 
Best regards,
 Andreas Falkenhahn                          mailto:an...@fa...