100% Came to write this. The window keeps getting focus and makes my hotkeys not work and resources to go all over the place. Very annoying.
I have the same symptoms (also on classic) but I haven't even reached Nightmare yet.
File corruption on classic character
Save file corruption for classic characters after normal dificulty
Move translations files outside of the .jar
Thank you very much, the problem is solved. На сб, 28.10.2023 г. в 21:05 ч. Silospen silospen@users.sourceforge.net написа: status: open --> closed-fixed [bugs:#30] https://sourceforge.net/p/gomule/bugs/30/ Rare Plate Belts crash the stash Status: closed-fixed Group: v1.0 (example) Created: Sun May 01, 2022 07:29 PM UTC by Tony Ford Last Updated: Sat Oct 28, 2023 06:05 PM UTC Owner: nobody java.lang.IllegalArgumentException: No translation for strap at gomule.translations.Translations$DefaultImpls.getTranslation(Translations.kt:15)...
Rare Plate Belts crash the stash
Thanks for the reports folks, sorry for the delay here. This should be fixed in the latest version (20) https://sourceforge.net/projects/gomule/files/gomule/R0.44/GoMuleR4.4.20-BETA_Resurrected_2.7.zip/download
Bump version
For some reason, the translation for Strap is missing which is causing some belt problems.
Hello Silospen. I have the same problem as Daniel. I use the latest version of GoMule.
Hello Silospen. I have the same problem as Daniel. I use the latest version of GoMule.
Hi Daniel, what version of GoMule are you working with? In the last release I made some updates to the translations. If you're on the latest or it still breaks, please go ahead and mail it over to me at silospen@silospen.com and I'll take a closer look!
I just encountered this issue as well. I attached a screenshot of the belt that triggered it. Any chance this is going to get fixed or should I just patch it locally? I guess it's just a new entry in one of the JSON files.
I just encountered this issue as well. I attached a screenshot of the image that triggered it. Any chance this is going to get fixed or should I just patch it locally? I guess it's just a new entry in one of the JSON files.
Add duplicates rule
Bump version
Bad fix for negative values
Pull the logic to do with rendering the items to a string out of the bloated D2Item class
Start on reading translations from JSON instead of legacy TBL files. Introduce new static file singleton until everything can be refactored to avoid singletons. Also a quick start on new infrastructure for reading tsv files, but not in use yet.
Remove badly written and incorrect drop calculator
Bugfix for writing stashes when the items themselves contain the magic JM byte sequence
Update to 2.7
Ignore skills if we get a bad offset back
Persist window locations
Add fix for strange under-reading of the cairn stones
Add example of failing charm name lookup
Fallback to the name column when we can't lookup the name. This really needs to be the full JSON lookup but it isn't time to get that yet
More helpful message for stash opening exception
Fix for naming of Token of Absolution, add recent quest items to Flavie
Update txt files for patch 2.6
I put in a PR over on github for the 2.4 to 2.5 changes, you can see it here: https://github.com/GoMule/GoMule/pull/9 It's pretty much what you'd expect, txt file changes, bumping character and stash versions and then some changes to the test code since the bytes have changed in several of the cases. This has been pretty consistent so far, in this case Blizz added a new way to display properties which also had to be added. Tell me more about your thoughts on a script to move over items? Interested...
Interesting. So I ended up porting the 2.5 changes over to my 2.4 code. Have got it built and running. I did think it was curious that I found myself bringing over stuff that I was sure had been removed or refactored just the opposite way from 2.3 - and didn't seem all that related to anything to do with reading a new format. If I may ask, what branch did you base your changes on? Are you up for upgrading the 2.4 branch to 2.5? I'd just like to see a diff of what kind of changes you made. Even a...
Interesting. So I ended porting the 2.5 changes over to my 2.4 code. Have got it built and running. I did think it was curious that I found myself bringing over stuff that I was sure had been removed or refactored just the opposite way from 2.3 - and didn't seem all that related to anything to do with reading a new format. If I may ask, what branch did you base your changes on? Are you up for upgrading the 2.4 branch to 2.5? I'd just like to see a diff of what kind of changes you made. Even a diff...
Interesting. So I ended porting the 2.5 changes over to my 2.4 code. Have got it built and running. I did think it was curious that I found myself bringing over stuff that I was sure had been removed or refactored just the opposite way from 2.3 - and didn't seem all that related to anything to do with reading a new format. If I may ask, what branch did you base your changes on? Are you up for upgrading the 2.4 branch to 2.5? I'd just like to see a diff of what kind of changes you made. Unfortunately...
Interesting. So I ended porting the 2.5 changes over to my 2.4 code. Have got it built and running. I did think it was curious that I found myself bringing over stuff that I was sure had been removed or refactored just the opposite way from 2.3 - and didn't seem all that related to anything to do with reading a new format. If I may ask, what branch did you base your changes on. Are you up for upgrading the 2.4 branch to 2.5? I'd just like to see a diff of what kind of changes you made. Unfortunately...
Hi Tony, the 2.5 branch is cut from an older version of master. Kotlin will be the future, if it ever happens :D I didn't run into any trouble - like you say there were no dependency or really any structural changes between the 2.4 and 2.5 branches. Not sure what to recommend :(
Hi Silospen, It looks like you've moved away from Kotlin for the 2.5. This is fine, but I'm now getting: General error during conversion: Unsupported class file major version 62 java.lang.IllegalArgumentException: Unsupported class file major version 62 Curiously, from looking at the build.gradle file, it seems to have all of the same dependencies and build against the same Java version. I can still build 2.4 no problem. Did you run into this when transitioning over?
I'm happy to take on maintenance duties as I've just started playing D2r relatively speaking, and have already done some modding of your code to work with an extended stash/inventory/cube size. But I'd like a walkthrough, especially with regards to how you spot the work that needs to be done for the updates.
I create real characters for each item type. So, there are 3 tiers of body armor, I have UniqBodyA, UniqBodyB, UniqBodyC, Each character can hold a full set of each tier unique body armor. I move those mules into a different folder and manage them with GoMule. That way, even if GoMule never gets updated, I still have the characters. I just need to move them to the save folders and load them if I can't use gomule. I think I have 57 mules, and they can hold 1 of each item in the game at least. GoMule...
I create real characters for each item type. So, there are 3 tiers of body armor, I have UniqBodyA, UniqBodyB, UniqBodyC, Each character a full set of each tier unique body armor. I move those mules into a different folder and manage them with GoMule. That way, even if GoMule never gets updated, I still have the characters. I just need to move them to the save folders and load them if I can't use gomule. I think I have 57 mules, and they can hold 1 of each item in the game at least. GoMule makes...
Been surprised as well, especially with Blizzard's seemingly anti-mod stance.
I haven't played since 2009, I've never played D2R. I think that's a concern for any open source project, but the code is out here for anyone to pick up should I disappear. To be honest, the bigger threat I'd say would be Blizz making some kind of change to lockdown character changes, we'd be screwed then. It's sort of amazing they haven't locked it down yet!
@silospen - I noticed on the PureDiablo forum you mentioned not playing D2 anymore, should we be concerned about this project being discontinued at some point even though Blizzard continues releasing new updates and eventually lose access to all of our GoMule stashes?
Hi Tony, I released a new version. 2.5 is not compatible with 2.4 created items, stashes and characters, instructions are here https://www.purediablo.com/forums/threads/gomule-for-d2-resurrected.2202/post-133494
2.5 patch out now. Looks like the character format has changed as well. Can't read the character. The character version is now 99.
So far, so good - can't thank you enough for this!
Updated version released, let me know how you get on. Instructions/caveats here: https://www.purediablo.com/forums/threads/gomule-for-d2-resurrected.2202/post-133494
Updates for patch 2.5
ehh, whatever, they all end up in my emails eventually.
@silospen - is this still the preferred place to post bug reports? I've also been posting on the Github site.
Thanks folks, I'll take a look over the weekend.
Wish I knew Java better. My biggest concern long-term is that Blizzard will continually update the game files; great for new content, but a pain for programs like this and mods.
Same issue here. Looking forward to a fix. Tried to look for previous commits for 2.4 fix so i could try to fix it myself, but did not found them. Save Data Changes Some changes to save data have been made in "ItemStatCost.txt". If an existing single player mod has edited these values, then their mod's saves may become corrupted when migrating old saves to the new save version. It is recommended to create backups of existing saves before loading them. "damageresist" and "magicresist" Save Bits: 8...
Same issue here. Looking forward to a fix. Tried to look for previous commits for 2.4 fix so i could try to fix it myself, but did not found them.| Patch notes with text changes: https://news.blizzard.com/en-us/diablo2/23827590/diablo-ii-resurrected-patch-2-5-now-live#Notes
Same issue here. Looking forward to a fix. Tried to look for previous commits for 2.4 fix so i could try to fix it myself, but did not found them.
Patch 2.5 characters are disconnected
Project text dump fails with Druid
.
It seems with the latest update that they have again changed the character stash format. Getting 'Disconnected' again.
Clipboard dumps on file change.
error: remote unpack failed: unable to create temporary object directory To https://git.code.sf.net/p/gomule/git ! [remote rejected] master -> master (unpacker error) error: failed to push some refs to 'https://git.code.sf.net/p/gomule/git' This update does include some new images. Perhaps there is an extra step I have to go through to add those? I'm happy to send anybody a copy of the files. They are modifications to have GoMule work with locbones' Expanded Inventory mod. There are still a couple...
error: remote unpack failed: unable to create temporary object directory To https://git.code.sf.net/p/gomule/git ! [remote rejected] master -> master (unpacker error) error: failed to push some refs to 'https://git.code.sf.net/p/gomule/git' This update does include some new images. Perhaps there is an extra step I have to go through to add those? I'm happy to send anybody a copy of the files. They are modifications to have GoMule work with locbones' Expanded Inventory mod. There are still a couple...
error: remote unpack failed: unable to create temporary object directory To https://git.code.sf.net/p/gomule/git ! [remote rejected] master -> master (unpacker error) error: failed to push some refs to 'https://git.code.sf.net/p/gomule/git' This update does include some new images. Perhaps there is an extra step I have to go through to add those? I'm happy to send anybody a copy of the files. They are modifications to have GoMule work with locbones' Expanded Inventory mod. There are still a couple...
So, at this point, we can move GoMule items to D2R. We cannot move items from D2R 2.4 back to GoMule, there is no fix for this (yet). Because when the shared stash is opened in D2R, it is converted to 2.4, and so no longer readable by GoMule.
Am I doing it wrong? 1) Close D2R and GoMule 2) Copy empty shared stash (from Silospen) into d2r saved games. 3) Open GoMule to verify it's working and put a heal in it. 4) Close GoMule 5) Open D2R, add a heal to shared stash. 6) Close D2R 7) Open GoMule 8) Shared stash is disconnected.
Thanks for the report! Could you mail it over to silospen@silospen.com please?
Character disconnected at gomule.item.D2Item.<init>(D2Item.java:174) at gomule.d2s.D2Character.readCorpse(D2Character.java:498) at gomule.d2s.D2Character.readChar(D2Character.java:250) at gomule.d2s.D2Character.<init>(D2Character.java:132) at gomule.gui.D2FileManager.addItemList(D2FileManager.java:1604) at gomule.gui.D2ViewChar.connect(D2ViewChar.java:446) at gomule.gui.D2ViewChar.<init>(D2ViewChar.java:425) at gomule.gui.D2FileManager.openChar(D2FileManager.java:1338) at gomule.gui.D2ViewProject$CharTreeNode.view(D2ViewProject.java:400)...
Rare Plate Belts crash the stash
Fire Absorb +XX% and +XX interchanged
here's some 2.3 character files for those that need it, to go with the 2.3 stash silospen posted above.
Took a while but worked, thank you for the help and this software!
Hi, unfortunately Blizzard decided to change the save file formats. You'll need to use the game to transport your items into the 2.4 patch, you can see some suggestions in the discussion here: https://sourceforge.net/p/gomule/bugs/27/#c90e
Hello, same problem shorter error message: Error Stash Version Incorrect! at gomule.d2x.D2Stash.readAtmaItems(D2Stash.java:153) at gomule.d2x.D2Stash.<init>(D2Stash.java:78) at gomule.gui.D2ViewClipboard.setProject(D2ViewClipboard.java:202) at gomule.gui.D2ViewClipboard.<init>(D2ViewClipboard.java:75) at gomule.gui.D2ViewClipboard.getInstance(D2ViewClipboard.java:146) at gomule.gui.D2FileManager.createRightPane(D2FileManager.java:492) at gomule.gui.D2FileManager.<init>(D2FileManager.java:127) at...
Hey guys, figured I add to this thread. I noticed ATMA stashes are also not loading into GoMule 4.4.14, I had them on GoMule 4.13 but not longer open a bug shows up, attaching image of error.
Is there a way to get the Map Seed?
Hello, thank you so much for working on an update for 2.4 of D2:R. With the latest GoMule beta, I can open my characters and stashes but not sharedstashes that I was using previously to store items prior to 2.4. Here's the error: Error Stash Version Incorrect! at gomule.d2x.D2Stash.readAtmaItems(D2Stash.java:153) at gomule.d2x.D2Stash.<init>(D2Stash.java:78) at gomule.gui.D2FileManager.addItemList(D2FileManager.java:1618) at gomule.gui.D2ViewStash.connect(D2ViewStash.java:352) at gomule.gui.D2ViewStash.<init>(D2ViewStash.java:286)...
Hello, thank you so much for working on an update for 2.4 of D2:R. With the latest GoMule beta, I can open my characters and stashes but not sharedstashes that I was using previously to store items prior to 2.4.
refactoring: replace 'new FileInputStream()' with 'Files.newInputStream()' call in D2FileReader <eom>
refactoring: change access modifer D2FileReader.getCounterBoolean() method 'public' -> 'private' <eom>
refactoring: rename D2FileReader field 'iFileName' -> 'fileName' <eom>
refactoring: rework D2FileReader(String pathToFile) constructor <eom>
refactoring: replace StringBuffer with StringBuilder in D2FileReader.getCounterBoolean() method <eom>
refactoring: replace C-style arrays declaration with Java-style in D2FileReader <eom>
refactoring: rename D2FileReader field 'iCounterBit' -> 'counterBit' <eom>
refactoring: rename D2FileReader field 'iConterPos' -> 'counterPosition' <eom>
refactoring: rename D2FileReader field 'iBuffer' -> 'buffer' <eom>
refactoring: remove auto-generated comment in D2FileReader class <eom>
refactoring: format code in D2FileReader class <eom>
refactoring: add default option for switch in D2TxtFile.getCharacterCode() method <eom>
refactoring: rework D2TxtFile.search() method <eom>
refactoring: rework D2TxtFile.propToStat() method <eom>