Hi Silospen, It looks like you've moved away from Kotlin for the 2.5. This is fine, but I'm now getting:
General error during conversion: Unsupported class file major version 62
java.lang.IllegalArgumentException: Unsupported class file major version 62
Curiously, from looking at the build.gradle file, it seems to have all of the same dependencies and build against the same Java version. I can still build 2.4 no problem. Did you run into this when transitioning over?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi Tony, the 2.5 branch is cut from an older version of master. Kotlin will be the future, if it ever happens :D
I didn't run into any trouble - like you say there were no dependency or really any structural changes between the 2.4 and 2.5 branches. Not sure what to recommend :(
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Interesting. So I ended up porting the 2.5 changes over to my 2.4 code. Have got it built and running. I did think it was curious that I found myself bringing over stuff that I was sure had been removed or refactored just the opposite way from 2.3 - and didn't seem all that related to anything to do with reading a new format. If I may ask, what branch did you base your changes on? Are you up for upgrading the 2.4 branch to 2.5? I'd just like to see a diff of what kind of changes you made. Even a diff file would be interesting. Unfortunately it's all been buried in me bringing over lots of code into the 2.4 branch to capture the update (for which now understand why). Maybe we won't have to pester you so much every time a patch comes out.
P.S. Any ideas on a script to automate the moving over of items?
Last edit: Tony Ford 2022-10-02
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
It's pretty much what you'd expect, txt file changes, bumping character and stash versions and then some changes to the test code since the bytes have changed in several of the cases. This has been pretty consistent so far, in this case Blizz added a new way to display properties which also had to be added.
Tell me more about your thoughts on a script to move over items? Interested in anything that doesn't violate the general GoMule approach of not modifying any of the character file bytes aside from the location of items.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi Silospen, It looks like you've moved away from Kotlin for the 2.5. This is fine, but I'm now getting:
Curiously, from looking at the build.gradle file, it seems to have all of the same dependencies and build against the same Java version. I can still build 2.4 no problem. Did you run into this when transitioning over?
Hi Tony, the 2.5 branch is cut from an older version of master. Kotlin will be the future, if it ever happens :D
I didn't run into any trouble - like you say there were no dependency or really any structural changes between the 2.4 and 2.5 branches. Not sure what to recommend :(
Interesting. So I ended up porting the 2.5 changes over to my 2.4 code. Have got it built and running. I did think it was curious that I found myself bringing over stuff that I was sure had been removed or refactored just the opposite way from 2.3 - and didn't seem all that related to anything to do with reading a new format. If I may ask, what branch did you base your changes on? Are you up for upgrading the 2.4 branch to 2.5? I'd just like to see a diff of what kind of changes you made. Even a diff file would be interesting. Unfortunately it's all been buried in me bringing over lots of code into the 2.4 branch to capture the update (for which now understand why). Maybe we won't have to pester you so much every time a patch comes out.
P.S. Any ideas on a script to automate the moving over of items?
Last edit: Tony Ford 2022-10-02
I put in a PR over on github for the 2.4 to 2.5 changes, you can see it here: https://github.com/GoMule/GoMule/pull/9
It's pretty much what you'd expect, txt file changes, bumping character and stash versions and then some changes to the test code since the bytes have changed in several of the cases. This has been pretty consistent so far, in this case Blizz added a new way to display properties which also had to be added.
Tell me more about your thoughts on a script to move over items? Interested in anything that doesn't violate the general GoMule approach of not modifying any of the character file bytes aside from the location of items.