Activity
From 05/03/2015 to 05/09/2015
05/09/2015
-
07:02 AM Bug #11088: On Exception too expensive inspect is called on recursive object graph with 3000 elements in it, swallows memory and ultimately doesn't deliver exception
- Hi Jurgen,
I executed bug_hunt.rb and I was able to reproduce this issue. But when I tried a simple test (attached in 11088_test.rb) I did not see this bug. Can you tell us how you generated the ruby_object.dump? Do you have code for ... -
04:53 AM Bug #11071: Stack consistency error while using RSpec and Timecop
- Possibly shortest code.
~~~ruby
def doit
yield nil
end
doit(&proc {doit {}}.method(:call))
~~~
But it doesn't happen, if the inner block has a single argument or arbitrary number arguments `*`.
Oppositely, it's similar bu... -
12:40 AM Feature #6647: Exceptions raised in threads should be logged
- Eric Wong wrote:
> I have an actual patch which is only 2 lines, but there's some test
> ...
Hot diggity! I bet there's several of these that indicate bugs to be fixed. At the very least, they indicate exceptions that are being raised ...
05/08/2015
- 10:31 PM Revision 933e586e (git): * 2015-05-09
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50450 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
10:31 PM
Bug #11123 (Closed): [PATCH] bsock_recmvsg_internal needs GC guard for control buffer
- Applied in changeset r50449.
----------
ext/socket/ancdata.c (bsock_recvmsg_internal): GC guard
The control buffer may be used throughout the function, so
prevent the string from being lost to GC.
* ext/socket/ancdata.c (bsock_recvmsg... - 10:31 PM Revision c3d826bb (git): ext/socket/ancdata.c (bsock_recvmsg_internal): GC guard
- The control buffer may be used throughout the function, so
prevent the string from being lost to GC.
* ext/socket/ancdata.c (bsock_recvmsg_internal): GC guard
[Bug #11123]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50449 b2dd0... -
09:48 PM Feature #6647: Exceptions raised in threads should be logged
- I have an actual patch which is only 2 lines, but there's some test
failures and MANY warnings I don't feel motivated to fix just yet
unless matz approves the feature:
http://80x24.org/spew/m/0a12f5c2abd2dfc2f055922a16d02019ee70739... -
05:26 PM Feature #6647: Exceptions raised in threads should be logged
- Not sure if a +1 would do anything, but I like the idea of
`Thread#report_on_exception` defaults to true.
For quick and one time scripts, it's tedious to write
`Thread.current.abort_on_exception = true` all the time,
and it shouldn... -
09:00 PM Bug #11120: Unexpected behavior when mixing Module#prepend with method aliasing
- I gave some more thought to this but I can't really find a way to improve the migration path from aliases to prepend without creating new problems.
I think this issue should be closed. -
- * test/matrix/test_matrix.rb (test_determinant): refactor test on
Matrix#determinant, by merging with test_det for an alias method
det. [Fix GH-897]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50448 b2dd03c8-39d4-4d8f-98ff-82... -
- * ext/io/console/extconf.rb: only nmake needs remove style VPATH.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50447 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/io/console/depend: remove nmake style VPATH, for normal makes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50446 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Shugo Maeda wrote:
> ```
> ...
Why they make the same symbol?
`a`, `@a` and `$a` are irrelevant, separate variables.
I'd expect `{:a=>1, :@a=>2, :$a=>3}` without any warnings. -
06:48 AM Revision 77da7216 (git): Revert "support ES6-like hash literals."
- This reverts commit 0d3797f8b62394f5634f4b2b529d28cb46bebf8a.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50445 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Applied in changeset r50444.
----------
* lib/net/imap.rb (body_ext_mpart): should work even if body-fld-dsp
is omitted. [ruby-core:69093] [Bug #11128] -
06:16 AM Bug #11128 (Assigned): IMAP parsing issue wih body_ext_mpart
-
- patch is here https://github.com/ruby/ruby/pull/895
-
- is omitted. [ruby-core:69093] [Bug #11128]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50444 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50443 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Is there this issue on Ruby 2.1 or 2.2? Ruby 1.9.3 is EOL.
-
-
- [fix GH-888][ci skip] Patch by @riffraff
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50442 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 03:11 AM Revision db336692 (git): * 2015-05-08
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50441 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_eval.c (rb_method_call_status): resolve refined method entry
to check if undefined. [ruby-core:69064] [Bug #11117]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50440 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Yukihiro Matsumoto wrote:
> I am interested why referencing the target object could cause problem. The target object must be existed before the exception, and exception should disappear soon after handling.
Oh I see, you were asking ... -
- Yukihiro Matsumoto wrote:
> I am interested why referencing the target object could cause problem. The target object must be existed before the exception, and exception should disappear soon after handling.
I'm not sure it's the refe... -
02:05 AM Feature #11129: block-level hash destructuring only works for the last argument
- I'd rename this bug to something like "block-level hash destructuring only works for the last argument" if Redmine let you rename bugs...
-
- ```ruby
[{a: 2}].each_with_index{ |a:, index| }
SyntaxError: unexpected tIDENTIFIER
[{a: 2}].each_with_index{ |(a:), index| }
SyntaxError: unexpected tLABEL
[{a: 2}].each_with_index.map{ |hash, index| [index, hash] }.map{ |index...
05/07/2015
-
10:33 PM Bug #11128 (Closed): IMAP parsing issue wih body_ext_mpart
- ResponseParser raises an error given a valid (RFC 3501) "body_ext_mpart" of the format "body-fld-param SP body-fld-dsp".
sample response:
"* 4 FETCH (BODY (((\"text\" \"plain\" (\"charset\" \"utf-8\") NIL NIL \"7bit\" 257 9 NIL NIL N... -
- Nevermind.
-
- Oops, I may be mistaken...I see on trunk that Symbol does define #==. This may just be JRuby being a bit behind the times.
-
- Symbol#== is implemented by Comparable, which uses Symbol#<=>, which coerces the symbol to a String so it can use String#<=> logic.
Most people don't know this, but it adds many hidden allocations to any Symbol-heavy code that that's ... -
04:05 PM Bug #11040: Mutex can be locked by multiple threads, causing Monitor to sometimes hang
- So now that I added a patch for `lib/monitor.rb` I guess this should be assigned to Shugo Maeda (shugo) per https://bugs.ruby-lang.org/projects/ruby/wiki/MaintainersStdlib, could someone do that for me? Or should I make a new issue?
-
02:22 PM Bug #11126 (Closed): CSV field converters doesn't attempt to convert nil value.
- following code behaves differently between ruby 2.2.2/trunk and 2.1.5.
```ruby
require 'csv'
converter = lambda { |field| field.nil? }
p CSV.parse_line('nil,', converters: converter)
```
```console
$ ruby -v
ruby 2.1.5p273 (2... - 01:28 PM Revision daed9129 (git): * proc.c: [DOC] fix Binding#local_variable_set example. [ci skip]
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50439 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
01:13 PM Bug #11125 (Rejected): Unable to build trunk on Windows
- 見間違えで、ビルドはできるようになっていたので撤回します。すみません。
-
- r50437でgperfがない限りビルドできなくされてしまっていますが、
この変更に強く反対します。 -
- FYI, naruse-san has already surveyed it, and some parts of its result have been committed into trunk.
See also: https://github.com/ruby/ruby/pull/884/files -
- * tool/checksum.rb (Checksum#update?): check if the target exists
too.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50438 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- * ext/io/console/win32_vk.inc: renamed not to be included in HDRS
by mkmf.rb and regenerated unexpectedly.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50437 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
02:39 AM Revision c4324e31 (git): * Makefile.in (rbconfig.rb): add rule to make.
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50436 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- Eric Wong <[email protected]> wrote:
> Thank you for proposing this. I think this will simplify working with
> Ruby IO and make me happier since I work with a lot of IO-related code.
> Outside of test cases, I don't forsee compa... -
01:04 AM Bug #11080: [PERF] bm_so_concatenate.rb regression
- Thank you for your work Nobu!
05/06/2015
-
- * test/excludes/TestConst.rb: skip very expensive test.
* test/excludes/TestThread.rb: ditto.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50435 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- The monotonic clock is preferred as it is guaranteed to be
continuous and not subject to jumps due to adjustments.
Given the identical "now" method in both files (and similar code in
lib/benchmark.rb), I wonder if we should implemen... -
- Which version of OpenSSL is this? I wonder if OpenSSL is not returning
SSL_ERROR_WANT_READ and SSL_ERROR_WANT_WRITE properly when it sees
EWOULDBLOCK.
Assuming OpenSSL returns SSL_ERROR_WANT_* properly, I'm not seeing
where we ca... -
- * ext/io/console/depend: check if VK table is modified by the
checksum.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50434 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- The control buffer may be used throughout the function, so
prevent the string from being lost to GC.
I'm pretty sure this is correct and we'll need it, I'll commit in a day or two
unless I missed something. I was planning to introd... -
- I would like to reduce exceptions for non-blocking operations on
Queue/SizedQueue in the same way we are reducing exceptions for non-blocking
I/O with *_nonblock(..., exception: false) methods.
However, I'm unclear what the API woul... - 08:33 PM Revision fe6c545d (git): * 2015-05-07
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50433 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
08:31 PM
Feature #11081 (Closed): [PATCH] stdlib: use IO#wait_*able instead of IO.select when possible
- Applied in changeset r50432.
----------
stdlib: use IO#wait_*able instead of IO.select when possible
In case a process encounters high-numbered FDs, this allows
consistent performance on systems with ppoll support.
[ruby-core:35572]
*... - 08:30 PM Revision 84b012e0 (git): stdlib: use IO#wait_*able instead of IO.select when possible
- In case a process encounters high-numbered FDs, this allows
consistent performance on systems with ppoll support.
[ruby-core:35572]
* ext/socket/lib/socket.rb (connect_nonblock): use IO#wait_writable
* lib/drb/drb.rb (DRB::DRbTCPSocket#... -
- Applied in changeset r50430.
----------
vm_eval.c: undefined refined check_funcall
* vm_eval.c (rb_method_call_status): undefined refined method is
not callable unless using. [ruby-core:69064] [Bug #11117] - 01:50 PM Revision 8e08552e (git): * 2015-05-06
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50431 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * vm_eval.c (rb_method_call_status): undefined refined method is
not callable unless using. [ruby-core:69064] [Bug #11117]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50430 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- I don't mind this patch and even see it as an opportunity to drop
`objspace->total_allocated_objects` entirely and rely exclusively on
thread-local counters for GC.
I toyed around with a similar idea last year in [ruby-core:61424] f...
05/05/2015
-
02:15 PM Bug #10702: Constant look up inconsistency with constants defined in included modules
- Thanks for the response. I can't say that it is intuitive at all, but I think I get what is happening now.
-
12:36 PM Feature #11105: ES6-like hash literals
- Yukihiro Matsumoto wrote:
> Question:
> ...
CoffeeScript would compile to this:
~~~
@a=1; a=2; {@a, a} => {a: this.a, a: a}
~~~
If the same happens in Ruby, this is what I get in IRB:
~~~
> {a: 1, a: 2}
(irb):2: warning: d... - 10:54 AM Revision 3d680dd2 (git): * 2015-05-05
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50429 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/io/console/extconf.rb: vk_header is used only on Windows,
nonsense to update on other platforms.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50428 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:05 AM Bug #11121 (Third Party's Issue): openssl ext does not handle EWOULDBLOCK
- On Windows, non-blocking IO on sockets seems to return EWOULDBLOCK instead of EAGAIN. The openssl ruby library only handles EAGAIN, which results in EWOULDBLOCK being raised to the caller.
This was noticed while using httpclient to se... -
01:48 AM Bug #11118: Unable to build Ruby with Visual Studio 2015 RC
- This issue is due to the runtime name change.
Since the Visual Studio 2014, the runtime is vcruntime140.dll.
Refer to http://mariusbancila.ro/blog/2014/06/05/crt-refactored-in-visual-studio-14/
The other huddle is FILE structure E...
05/04/2015
-
- Yes, see "Backport" field.
-
04:21 PM Bug #11091: Symbolized Strings May Break Keyword Arguments
- We just ran into this bug as well. Our script to reproduce is attached. We also noticed the same requirements as the original poster: multiple required keyword arguments, a `**splat`, and a dynamically created symbol.
We ran the scr... -
06:37 PM Bug #11113: Time ranges cannot be used in case statements in 1.9+ but they could in 1.8.7
- Thanks for the prompt fix, @nobu!!
On a side note, I wasn't notified by email of your fix even though I'm watching this issue so I get notified of updates. Do you know why that is? -
- I'm not completely sure myself if this should be considered a bug, but at least it should be up for discussion.
I stumbled upon this behavior when migrating some code using alias chains to Module#prepend.
Consider the following code:... -
- A simple rule for future Rubies might be "if you want an anonymous module/class to have a useful path-based #name, ensure the parent namespace is itself named, all parents provide the same guarantee, and the namespace hierarchy is eventu...
-
- Nobuyoshi Nakada wrote:
> What kind of changes?
The kind of changes that make it impossible to pass all current tests in JRuby :-)
* For namespaces with multiple parents, traversal order will change #name
* For unrooted anonymous... -
- What kind of changes?
-
- MRI lazily determines the name of a class or module by walking all defined constants starting from `Object` and looking for the namespace in question. This allows deferring the full name calclation until the class/module is finished bein...
-
02:12 AM Feature #9423: Improve warning semantics
- Any thoughts on structured warnings core team?
05/03/2015
-
- I installed the latest Visual Studio, and then tried to build Ruby 2.2.2 on Windows 7. But, I'm having trouble right away. This is an RC candidate (so I guess that's why the CLI shows Visual Studio 14).
C:\Program Files (x86)\Microsof... -
07:16 PM Bug #11117 (Closed): When you refine String with to_regexp, then it breaks Regexp.try_convert even when the refinement is not used
- I’ve run into a very strange bug with refinements. Let me show you:
~~~ruby
module Ref
refine String do
def to_regexp
end
end
end
Regexp.try_convert('foo')
# or Regexp.union('foo', 'bar')
~~~
~~~
bug.rb:8:in... -
- * ext/io/console/console.c (console_key_pressed_p): new method
IO#pressed? on Windows. [EXPERIMENTAL]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50427 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 06:11 PM Revision ff332256 (git): * 2015-05-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50426 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
- 06:11 PM Revision daa18e50 (git): * 2015-05-04
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50426 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/io/console/console.c (console_goto): new method IO#goto on
Windows. [EXPERIMENTAL]
* ext/io/console/console.c (console_cursor_pos): new method
IO#cursor on Windows. [EXPERIMENTAL]
* ext/io/console/console.c (console_cursor_... -
- * ext/io/console/console.c (console_beep): new method IO#beep.
[EXPERIMENTAL]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50424 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 01:54 PM Revision fadd0160 (git): * ext/-test-/file/fs.c: need to include sys/statvfs.h
- to use statvfs().
* ext/-test-/file/extconf.rb: check the existence of
sys/statvfs.h
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50423 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
- Patch by @miketheman
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50422 b2dd03c8-39d4-4d8f-98ff-823fe69b080e -
10:36 AM Bug #11116 (Closed): The spec of String#dump
- The current spec says:
call-seq:
str.dump -> new_str
Produces a version of +str+ with all non-printing characters replaced by
-
- George Millo wrote:
> Is this a bug, or a feature?
A feature. -
06:17 AM Bug #11115 (Rejected): Assigning a non-existent local variable to itself sets it to nil; unintuitive behaviour?
- Here's what normally happens when I try to reference a local variable that doesn't exist:
~~~ruby
def foo
bar
end
foo
# => NameError: undefined local variable or method `bar'
~~~
But if I assign bar to "itself", it doesn'... -
- You have to reinstall `sqlite3_native.bundle`.
-
- Applied in changeset r50421.
----------
range.c: covered for linear objects
* range.c (linear_object_p, range_include): test if covered for
linear objects. [ruby-core:69052] [Bug #11113] -
- * range.c (linear_object_p, range_include): test if covered for
linear objects. [ruby-core:69052] [Bug #11113]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50421 b2dd03c8-39d4-4d8f-98ff-823fe69b080e - 12:36 AM Revision 06cb3200 (git): * 2015-05-03
- git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50420 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
-
- * ext/io/console/console.c (LAST_ERROR): remove old ifdef, should
use rb_w32_map_errno always.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@50419 b2dd03c8-39d4-4d8f-98ff-823fe69b080e