Activity
From 10/11/2019 to 10/17/2019
10/17/2019
-
11:59 PM Bug #13903 (Closed): cant compile ruby with /MT on windows
-
-
-
-
-
- With the separation of keyword arguments and positional arguments in #14183, I think this can be closed.
-
- Vit, do you still get this test suite error?
-
- `$SAFE` is being deprecated in 2.7 and will revert to normal global variable in 3.0, so this can be closed.
-
-
-
-
-
-
-
- It looks like this error message has not been changed. Attached is a patch with a slightly more verbose and descriptive error message:
```ruby
class C1; end
C2 < C1.new; end
# TypeError (superclass must be an instance of Class (gi... -
-
- Fixed by commit:1d5066efb08cbb328ba528a5f8be1708584b659f.
-
-
-
-
-
09:16 PM Feature #16245: Add interfaces to count and measure size all IMEMO objects
- Yes!
ObjectSpace.memsize_of_imemo_objects sounds perfect to me.
I also support adding `ObjectSpace.each_iseq` which seems the simplest way to get iteration working.
I get the concern about not wanting to pollute MRI with MRI ... -
- Koichi,
What about rb_str_fstring_lookup and rb_str_fstring_lookup_enc? Both will not create strings so shared strings should not be a problem.
To be honest creation can be somewhat inefficient, the one place I can see this being... -
05:55 AM Feature #16029: Expose fstring related APIs to C-extensions
- Hi.
(1) implementation
Current implementation can have issue (related to shared string) and this issue can cause something wrong behavior for C-extension.
Sorry, we need a time to confirm.
(2) naming
i think it should be `rb... -
08:35 PM Revision 1d564ace (git): Remove unused constant.
- This constant isn't used, so lets remove it.
-
- The global can go bad if the compactor runs, so we need to look up the
constant instead of caching it in a global. -
-
- `test/net/fixtures` was updated in commit:f234e6c3d3170f37508e214cdaef78d4b2584e5a and commit:1e0b49a293d3792826c67b7e05c5fcbd09c9ea6e. Rubygems cert was updated in commit:ae2a904ce9bffedee7d110dc60fd51c0a2879a5b. I think this can be clo...
-
-
07:22 PM Bug #16030 (Closed): test_memsize fails on x32 ABI: Unsupported RVALUE_SIZE=24
- Applied in changeset commit:git|ee821e90741ebedc6c7a3bb0e8b67e59f3a44022.
----------
Update test to handle x32 ABI compiled Ruby on Linux
Suggestion from Laurence Parry.
Fixes [Bug #16030] -
- Suggestion from Laurence Parry.
Fixes [Bug #16030] -
- Matz wants to make it as an extension library, so I moved it as extension library.
-
- I agree this is a bug that should be fixed. I have submitted a pull request to fix it: https://github.com/ruby/thwait/pull/1
-
05:55 PM Feature #13683: Add strict Enumerable#single
- > instead of `#select`, shouldn't you use `#find` so it doesn't need to check the others when it already found a match?
No, because it should return nil when there's more than one match. -
07:24 AM Feature #13683: Add strict Enumerable#single
- Dan0042 (Daniel DeLorme) wrote:
> +1
> ...
instead of `#select`, shouldn't you use `#find` so it doesn't need to check the others when it already found a match? -
06:24 AM Feature #13683: Add strict Enumerable#single
- ```
[1, 2].mono
[1, 2].solo
[1, 2].alone
``` -
05:59 AM Feature #13683: Add strict Enumerable#single
- I don't like `only` either since these names do not describe the behavior.
Matz. -
05:54 PM Revision 8c0629ba (git): Treat key sequences from getwch() that start from 0 or 0xE0 correctly
-
-
-
- The function getwch() returns some key sequences which start from 0 or 0xE0
with a following key code. Alt+` that is on/off key for input methods gives 0
and 41 so Reline was always ignoring 0 and following keys but numeric keypad
keys g... -
-
-
-
-
-
-
-
- Applied in changeset commit:git|0162e7e6471b639dfeeded29943e9e27c9519826.
----------
Make circular argument reference a SyntaxError instead of a warning
Fixes [Bug #10314] -
- I think it's OK now to make this error.
Matz.
-
- Fixes [Bug #10314]
-
- The blocker on merging the pull request is that test-bundled-gems is failing due to the `rake` test failure. https://github.com/ruby/rake/pull/329 needs to be merged (and I don't have permissions to merge it), and a new rake released an...
-
06:58 AM Feature #16131: Remove $SAFE, taint and trust
- Hi @jeremyevans0,
> I've rebased my pull request against master and fixed the conflicts
Thank you for the great work! I've discussed this issue on the developer meeting, and all agreed with the change.
> ...
This should be disc... - 03:46 PM Revision fdfb5100 (git): * 2019-10-18 [ci skip]
-
-
03:24 PM Feature #13083 (Closed): Regexp#{match,match?} with a nil argument are deprecated and will raise a TypeError in Ruby 3.0
- Merged at commit:2a22a6b2d8465934e75520a7fdcf522d50890caf
-
- This error occurs in sassc, an external gem:
```
c:0059 p:---- s:0449 e:000448 CFUNC :compile_data_context
c:0058 p:0298 s:0444 e:000443 METHOD /Users/johnny/env/ebm/vendor/cache/ruby/2.5.0/gems/sassc-2.2.1/lib/sassc/engine.rb:42
... -
10:18 AM Bug #16259 (Third Party's Issue): Err when running 'rails test'
- Got this error when running 'rails test'
Please ask if something's missing!
Best of luck! -
02:32 PM Feature #15822: Add Hash#except
- @matz About use-cases, there are multiple, like:
* Logging/debug printing some hash with sensitive or too large data excluded:
```ruby
puts "REQUEST: #{request_data.except(:body, :apikey)}
```
* Data tidying:
```r... -
- `Hash#slice` was introduced via discussion in #13563. We didn't see the need for `Hash#except` yet. Any (real world use-case)?
I don't think the name `except` is the best name for the behavior.
Matz. -
- I am so sad :-(
I was really looking forward to using this beautiful syntax instead of numbered parameters which I find so ugly I prefer to use an explicit block variable.
Am I the only one who thinks the omitted parameter is by far th... -
- After reconsideration, I came to the conclusion that we should use numbered parameters instead of this feature.
Thank you for a pretty interesting idea. It was good food for thought.
Matz.
-
10:43 AM Revision 4f13927f (git): [DOC] no change on Windows [Bug #15267] [ci skip]
-
- Applied in changeset commit:git|e169ad93f44e1944ecf7bb65133fd34e8b868ea8.
----------
Fixed File.extname at a name ending with a dot
File.extname now returns a dot string at a name ending with a dot.
[Bug #15267] -
- https://github.com/ruby/ruby/pull/2565
-
05:41 AM Bug #15267: File.basename + File.extname does not restore the original name
- I think we should change File.extname instead of File.basename, as:
```
File.basename("name.", ".*") #=> "name"
File.extname("name.") #=> "."
```
We can explain File.extname as:
File.extname(x) returns what File.basename(x, ".*... -
05:14 AM Bug #15267: File.basename + File.extname does not restore the original name
- > basename(1) seems to result in the base name with the dot, when stripping a wildcard suffix.
basename(1) doesn't handle wildcard.
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/basename.html -
- File.extname now returns a dot string at a name ending with a dot.
[Bug #15267] - 08:45 AM Revision 2a261909 (git): * remove trailing spaces. [ci skip]
-
- Thank you for your patch.
Conclusion: OK.
Points:
* Current implementation separates ci and cc because of CoW friendliness (ci is immutable data and cc is mutable data). However, there are no measurements how it affect on CoW fr... -
01:46 AM Misc #16258 (Closed): [PATCH] Combine call info and cache to speed up method invocation
- Proposed change: https://github.com/ruby/ruby/pull/2564
To perform a regular method call, the VM needs two structs, `rb_call_info`
and `rb_call_cache`. At the moment, we allocate these two structures in
separate buffers. In the wors... -
08:44 AM Revision 2a22a6b2 (git): Regexp#match{?} with nil raises TypeError as String, Symbol (#1506)
- * {String|Symbol}#match{?} with nil returns falsy
To improve consistency with Regexp#match{?}
* String#match(nil) returns `nil` instead of TypeError
* String#match?(nil) returns `false` instead of TypeError
* Symbol#match(nil) returns ... -
-
07:53 AM Bug #16257: Gem::Version instances are silently created as singletons
- Fixed and scheduled for rubygems v3.1.0.
-
-
- I feel changing the default behavior of IO#rewind is dangerous.
We use IO#rewind when we modify a file in place.
```
open(filename, "r+") {|f|
f.read
f.rewind
f.truncate(0)
f.write "..."
}
```
If IO#rewind moves t... -
- I agree with fixing this. Nobu will investigate the patch and consider the issue detail.
Matz.
-
-
02:37 AM Misc #16232: DevelopersMeeting20191017Japan
- * [Feature #16142] Implement code_range in Proc and Method - Ruby master - Ruby Issue Tracking System
* Propose an API to get code position of Proc and Method so that we can get body of them (especially of a Proc).
* I want to disc... -
- - [Misc #16258] Combine call info and cache to speed up method invocation
- Looking for feedback and reviews. I think this offers a good perf boost.
- [Bug #15912] Allow some reentrancy during TracePoint events
- I have seen quit... -
- * [[Feature #13083]](https://bugs.ruby-lang.org/issues/13083) {String|Symbol}#match{?} with nil returns falsy as Regexp#match{?}
* Matz said "Those methods (but =~) should consistently raise exceptions." and pull request's conflicts r... -
- hi.
I want to use it when I want to get the block source code.
e.g. https://github.com/osyo-manga/gem-binding-debug
https://github.com/osyo-manga/gem-binding-debug/blob/a5e19728893ddb92ec04170fcd8afbdf43db2eab/lib/binding/debug.rb#L10...
10/16/2019
-
- Applied in changeset commit:git|567e312d1f56c27ecb4fa20deac4311f05ee5507.
----------
Do not raise an exception on a closed DRb socket
This rescues some exceptions that could happen with a closed or
shutdown DRb socket. This can prevent... -
- Applied in changeset commit:git|50b8033d6b7404670ee985de1473fffc10dd7d9c.
----------
Handle subclasses of Exception in drb
This makes it so that client instances that call a method on a
server-side object that raise a subclass of Excep... -
- My previous fix in d0ed935d5bf8c3fce9800742a36e44fb7f63dda4 was
not correct, as pointed out by cremno on GitHub.
This simplifies things by just using Kernel#to_s. Also switch to
bind_call(obj) instead of bind(obj).call for better perfo... -
- This rescues some exceptions that could happen with a closed or
shutdown DRb socket. This can prevent the server from
exiting if an client socket is closed directly after it is
accepted.
Fixes [Bug #8039] -
- This makes it so that client instances that call a method on a
server-side object that raise a subclass of Exception are handled
similarly to those that raise a subclass of StandardError.
Only reraise exceptions that we are fairly sure ... -
- Applied in changeset commit:git|2993b24a1ecc5fa3cc9f140bfd80669c3a3b7b9c.
----------
Warn for calling public/protected/private/module_function without arguments inside method
Calling these methods without an argument does not have the
... -
- nobu (Nobuyoshi Nakada) wrote:
> * Is it necessary that check is placed inside the function `vm_cref_set_visibility`?
> ...
I agree, that makes more sense.
> * `rb_frame_callee` returns the called name, that may be an aliased name.
... -
- * Is it necessary that check is placed inside the function `vm_cref_set_visibility`?
What about calling a separate function where `check_method` flag is 1?
* `rb_frame_callee` returns the called name, that may be an aliased name.
... -
- @nobu Could you review the patch?
-
- Calling these methods without an argument does not have the
desired effect inside a method.
Fixes [Bug #13249] -
- Given the very interesting use case that zverok presented, I'm leaning more in favor of a lexically-scoped "operator" that doesn't need to be present in the method signature. So no invocation via block, just like `super`. Actually, the m...
-
- The disadvantage I see to this proposal is increased complexity. Both internal complexity in the implementation, and also more complexity for the user, as this adds more syntax Ruby programmers need to understand. However, I think the ...
-
- > But it's true that often we want to operate on the arguments before forwarding, so I think maybe an asymmetric syntax like this would work best?
BTW, that's very valid point — similar problem was discussed here: https://bugs.ruby-la... -
- > * Is `*` or `...` an expression? What does `def m(...); a = ...; p a; end; m(1, a: 2) {}` print?
I would tend to say `a = ...` is a syntax error; my intention was to use this only in the argument list of a method call, with an imple... -
10:33 AM Feature #16253: Shorthand "forward everything" syntax
- Things to consider:
* Is `*` or `...` an expression? What does `def m(...); a = ...; p a; end; m(1, a: 2) {}` print?
* Do we want to support required arguments before? It would be useful for `method_missing`:
```ruby
def method_mis... -
-
-
- * Makes it easier to copy-paste and add code backticks.
-
- * [Feature #16120] Omitted block argument if block starts with dot-method call (Dan0042)
* last time Matz said "Give me time to consider it"; there is now a patch ready; is it ok to accept?
-
- * [Feature #16150] Add a way to request a frozen string from to_s
* `Symbol#to_s` now returns a frozen string, and this brought at least seven incompatibility issues. To make sure: is it okay to introduce this change in 2.7.0-preview2? -
- * [Feature #16253] Shorthand "forward everything" syntax (mame)
* How about introducing `def foo(...); bar(...); end`? It does not solve the compatibility issue of keyword argument separation, but it would provide a useful shorthand ... -
- * [Feature #16255] Make `monitor.rb` built-in (ko1)
* maybe there is no problem.
* Should we make `MonitorMixin` built-in?
* [Feature #16254] MRI internal: Define built-in classes in Ruby with `__intrinsic__` syntax (ko1)
* onl... -
- Rebased my patch to the latest master and cleaned up the code a bit:
https://github.com/dan42/ruby/commit/11f609af003370396d0e82381b57ea5a73ff6d8a - 03:29 PM Revision e003f29e (git): * 2019-10-17 [ci skip]
-
03:28 PM Revision 5c80dffd (git): Revert "Disable ccache on arm64 build"
- This reverts commit e8124729fbeaf159ae615f61980ee10018ed5134.
It worked once, but soon after that it stopped working again
https://travis-ci.org/ruby/ruby/jobs/598491972 -
-
- Done: https://github.com/rubygems/rubygems/issues/2948
-
- It is an issue of rubygems.
Please report it at https://github.com/rubygems/rubygems/ -
- Attached the full stack trace.
-
- Instantiating `Gem::Version` objects via `new` actually returns singletons, which is not obvious nor is this documented anywhere:
~~~
irb(main):001:0> v1 = Gem::Version.new("2.2.0")
=> #<Gem::Version "2.2.0">
irb(main):002:0> v1.fr... -
- This reverts commit 43015275b9a7f2833c93ad11ea96ae4cb3b7acd7.
`assert_raise_message` in test-unit is different from
`assert_raise_with_message`. It checks the exception message
only, but not the exception class, -
- It should be fixed.
-
-
-
08:30 AM Feature #16256: A "did you mean" hint for OptionParser
- \o/
-
- How about showing "did you mean" when a unknown option is passed for OptionParser?
```ruby
require 'optparse'
OptionParser.new do |opts|
opts.on("-f", "--foo", "foo") {|v| }
opts.on("-b", "--bar", "bar") {|v| }
opts.on("-... -
- Current design is for compatibility for future changes.
-
- Still some CIs are failing:
https://ci.appveyor.com/project/ruby/ruby/builds/28141041/job/v4hfc99sjefqabkk
http://ci.rvm.jp/results/trunk-vm-asserts@silicon-docker/2317313
I'll fix them later. -
-
-
-
-
- because it started to run on Travis.
-
- Follow up https://github.com/ruby/ruby/pull/2559
According to experiments in https://github.com/ruby/ruby/pull/2560,
disabling cache seems to make arm64 build succeed. -
- Already we have:
```ruby
require 'objspace'
pp ObjectSpace.count_imemo_objects
#=>
{:imemo_env=>42,
:imemo_cref=>177,
:imemo_ment=>3662,
:imemo_iseq=>1194,
:imemo_tmpbuf=>117,
:imemo_ast=>22,
:imemo_svar=>40,
:imemo_... -
-
-
- and let RUBY_DEBUG=1 job test it.
We usually don't use --jit-debug and we should test no --jit-debug by
default. - 03:59 AM Revision d97229de (git): Add arm64 case on Travis. (#2559)
- misc-16234
-
- There's something I'm not sure I understood so I'd like to clarify if this proposal can be described as
A) write the boilerplate `rb_define_class` and `rb_define_method` using a ruby-like macro language;
B) write core classes and m...
10/15/2019
-
- # Abstract
`monitor.rb` introduces `MonitorMixin` module and `Monitor` class.
Now, `rubygems.rb` requires `monitor.rb` so that most of Ruby applications (*1) requires `monitor.rb`
[*1] running MRI with `--disable-gems` can elimin... -
- * [Feature #16131] Remove $SAFE, taint and trust (jeremyevans)
* Does anyone have time to review the patch (extensive changes, mostly code deletion)?
* How do we want to handle included libraries with separate upstreams that want t... -
- * [Feature #15822] Add `Hash#except`
* The method is really useful, even with ActiveSupport-less codebases I constantly tend to redefine it with core ext or refinements. `Hash#slice` was merged in 2.5; it was initially discussed in #8... -
10:55 AM Misc #16232: DevelopersMeeting20191017Japan
- * [Bug #16143] BOM UTF-8 is not removed after rewind (kou)
* Can we commit this? I've reviewed. I think that this is ready to merge. -
- Local variables are "hoisted" to the beginning of the method/block in Ruby (and start with value `nil`).
With that in mind, I think the behavior is logical. IMHO, it is spec. -
- I have no idea whether this is a spec or undefined behavior, but the current implementation is actually intentional.
```
def x
"x"
end
def foo
eval("x = 1") # foo has no variable named x, so 1 is assigned to a temporal vari... -
01:19 PM Bug #16251 (Closed): Evaluation in binding differs from ruby execution
- In specific situation, I found that result of string evaluation in Binding returns different from ruby execution result.
In following sample code, ruby evaluates `method_or_local_var` as method call and returns `"method"`.
However, `... -
08:16 PM Misc #16234: Enabling ARM 64/32-bit cases by Drone CI
- I sent a PR: https://github.com/ruby/ruby/pull/2559 adding a native arm64 environment on Travis.
I also tried to add arm32 case by running gcc-multilib on the native arm64 like "i686-linux" case to Travis too. But so far, I have not s... -
- This sounds great.
We have very a similar mechanism in TruffleRuby, inherited from Rubinius, which is called "primitives" (ala Smalltalk).
Compared to Rubinius we changed the syntax and always use the `invoke_primitive` form (like `_... -
- # Abstract
MRI defines most of built-in classes in C with C-APIs like `rb_define_method()`.
However, there are several issues using C-APIs.
A few methods are defined in Ruby written in `prelude.rb`.
However, we can not define all... -
- When ruby2_keywords is used on a method, keywords passed to the method
are flagged. When the hash is passed as the last element of an
argument splat to another method, the hash should be treated as a
keyword splat. When keyword splatti... -
- Eregon (Benoit Daloze) wrote:
> jeremyevans0 (Jeremy Evans) wrote:
> ...
I should preface this by saying all of my comments related to performance implications were and are implicitly refering to CRuby's implementation. I have no know... -
- jeremyevans0 (Jeremy Evans) wrote:
Thank you for your detailed reply.
> Internally, there are not really performance implications for the choice to treat keyword arguments as a last positional hash. If we not do so, the `foo(key: ... -
-
- Hmm. I have not decided whether I like the proposal or not; I guess I am mostly
neutral, but with a slight tendency towards not being in favour of it. But leaving
this aside, I think there are perhaps a few points of note.
1) Part o... -
- `...` has been proposed a few times as well, I'm not sure if there is a ticket for it:
```ruby
def foo(...)
@bar.foo(...)
``` -
- What about using this:
```ruby
def foo(*)
@bar.foo(*)
```
to mean this:
```ruby
def foo(*a, **o, &b)
@bar.foo(*a, **o, &b)
```
I used `def foo(*)` because that's currently valid ruby code, but I'm fine with ... -
-
- Applied in changeset commit:git|929d5fd3b99c1413f737ff16cf0680698036e60f.
----------
Comparable#clamp with a range [Feature #14784] - 04:42 PM Revision 1c50ce2c (git): * 2019-10-16 [ci skip]
-
-
- Eregon (Benoit Daloze) wrote:
> jeremyevans0 (Jeremy Evans) wrote:
> ...
That's a possible argument for keeping `ruby2_keywords` longer or indefinitely. :)
> I believe removing `ruby2_keywords` is going to break those gems if we rec... -
- jeremyevans0 (Jeremy Evans) wrote:
> It certainly could. I believe the idea of removing it after Ruby 2.6 is EOL is that gems that work on supported Ruby versions could continue to have a single method definition. That method definiti... -
- Eregon (Benoit Daloze) wrote:
> @jeremyevans0 That is not future proof and will break as soon as `ruby2_keywords` is removed.
I did say: `That will work in all ruby versions until ruby2_keywords is removed`.
> ...
It certainly cou... -
- At the end of my comment in https://bugs.ruby-lang.org/issues/16188#note-5 I discussed why I believe `ruby2_keywords` is a non-trivial cost on performance, and so should be IMHO only in Ruby 2.7.
I also propose there an explicit way to ... -
-
- @jeremyevans0 That is not future proof and will break as soon as `ruby2_keywords` is removed.
I don't think we want to keep using `ruby2_keywords` forever, i.e., does it make sense to use `ruby2_keywords` in Ruby 4?
From the name and... -
- Hash#partition is implemented by Enumerable so it just returns two arrays of arrays
```ruby
{1=>2,3=>4}.partition{|k,|k==1} #=> [[[1, 2]], [[3, 4]]]
```
But I think it would make more sense to behave similarly to Hash#select and ... -
- Try using a different `--prefix` for the 32bit and 64bit versions, and please report whether that fixes the issues.
-
12:17 PM Bug #16179: ruby binaries generate "already initialized constant" warnings on AIX 6.1
- 64bit
-----
./configure \
--host=powerpc-ibm-aix6.1.0.0 --target=powerpc-ibm-aix6.1.0.0 --build=powerpc-ibm-aix6.1.0.0 \
--prefix=/opt/freeware \
--libdir=/opt/freeware/lib64 \
--libexecdir=/opt/freeware/lib64 \
... -
- Here's the results of `$:` extracted from the uploaded .docx log:
```
/opt/freeware/lib64/ruby/gems/2.6.0/gems/did_you_mean-1.3.0/lib
/opt/freeware/lib64/ruby/site_ruby/2.6.0
/opt/freeware/lib64/ruby/site_ruby/2.6.0/powerpc-aix6.1.... -
-
- I've submitted a pull request that raises ArgumentError for invalid shift_age values: https://github.com/ruby/logger/pull/42
For backwards compatibility and to keep the tests passing, values of `'now'` and `'everytime'` are considered... -
- Eregon (Benoit Daloze) wrote:
> What tests does it break, could you copy the output?
I didn't keep the output. From a brief analysis, it appeared to be to be tests that you wouldn't want to break. Using `data->iclass` instead of `d... -
- Thanks for the patch.
What tests does it break, could you copy the output?
The tests might be wrong too. -
- Attached is a patch that fixes this issue. @wanabe was correct that we need to use `data->iclass` if available. However, changing just that breaks some existing tests. To keep existing tests working but also fix this issue, if the obje...
-
- of "setting Encoding.default_internal".
-
- https://github.com/ruby/ruby/commit/f94202fcc228d0348ca050a7b18a8f8a538a7305#commitcomment-35505076
Co-Authored-By: Ary Borenszweig <[email protected]> -
- replaced "anObject" with "obj". also marked up with simple `_`s
instead of `<i>`. -
11:57 AM Revision e0e93a19 (git): [rubygems/rubygems] Bump version to 3.1.0.pre2
- https://github.com/rubygems/rubygems/commit/a7a673ce22
-
- https://github.com/rubygems/rubygems/commit/97e9768612
-
-
-
- https://rubyci.org/logs/rubyci.s3.amazonaws.com/openbsd-current/ruby-master/log/20191015T070011Z.fail.html.gz
```
1) Failure:
TestProcess#test_kill_at_spawn_failure [/home/chkbuild/chkbuild/tmp/build/20191015T070011Z/ruby/test/ruby/tes... -
-
- Great catch, thanks!
> By the way, I had to create a new account to report this bug. I already tried to reset my password for account [email protected] but after I reset it if I try to login it always says the password is incorrect. ... -
04:25 AM Bug #16250 (Closed): IRB can't print recursive Arrays or Hashes
- Applied in changeset commit:git|96617ad1d57a13e9a282fb663ea73e4801519389.
----------
IRB colorize: take into account recursive arrays and hashes (#2555)
[Bug #16250] -
- [Bug #16250]
-
- Applied in changeset commit:git|978276a7d9249535f855088f866551b6557f321f.
----------
Update documentation for File#{readable,writable,executable}{,_real}? [ci skip]
Some OS-level security features cause these methods to not return
expe... - 12:55 AM Revision ddd42d8e (git): * 2019-10-15 [ci skip]
-
- Some OS-level security features cause these methods to not return
expected results. For example fs.protected_regular sysctl on Linux,
or pledge(2)/unveil(2) on OpenBSD.
Fixes [Bug #16002]
10/14/2019
-
09:05 PM Bug #16250: IRB can't print recursive Arrays or Hashes
- Fix here: https://github.com/ruby/ruby/pull/2555
-
- By the way, I had to create a new account to report this bug. I already tried to reset my password for account `[email protected]` but after I reset it if I try to login it always says the password is incorrect. Could you try verifying ...
-
- This is on Ruby 2.7.0dev but I'm almost sure it happens on master because this code has no check for recursion: https://github.com/ruby/ruby/blob/c3a626030235c0349e14c6bc07177810daee841c/lib/irb/color.rb#L73-L88
Code to reproduce:
... -
- `pass_keywords` was renamed to `ruby2_keywords`. The correct and portable way to handle generic delegation is now:
```ruby
class Proxy < BasicObject
def initialize(target)
@target = target
end
def method_missing(*a, &b)... - 01:56 PM Revision c3a62603 (git): add require "monitor"
- 11:30 AM Revision 8488d5b5 (git): Automatically close fds on fork (and GC). The connection pools are maintained at thread scope.
-
10:54 AM Revision a4cf11c1 (git): [flori/json] fix test as reported in #343
- https://github.com/flori/json/commit/565c72ba9e
- 10:54 AM Revision 308bbb4e (git): [flori/json] Add ascii_only option to JSON::Ext::Generator::State.new.
- https://github.com/flori/json/commit/0e99a9aac5
-
10:54 AM Revision 98a9445d (git): [flori/json] Add shortcut converting to String
- In where to convert Hash key to String for json, this patch will add shortcut for String/Symbol in Hash key.
```
$ ruby bench_json_generate.rb
Warming up --------------------------------------
json 65.000 i/100ms
Cal... -
- To convert Hash convert, this part was using following pseudo code
```
obj.keys.each do |key|
value = obj[key]
...
end
```
and `rb_funcall()` was called for `obj.keys`.
It might be slightly heavy to call the Ruby method.
This patch... -
- flori/json@c34d01ff6a18dac04a90b2e0f820cdb1d5c7e1b2 does not
consider US-ASCII compatible but non-UTF-8 encodings, and causes
an error in RDoc tests.
https://github.com/flori/json/commit/4f471bf590 -
- ## Before
```
$ ruby bench_json_generate.rb
Warming up --------------------------------------
json 129.000 i/100ms
Calculating -------------------------------------
json 1.300k (± 2.3%) i/s - ... -
- `rb_funcall` might be slightly heavy to call the Ruby method.
This patch will convert String encoding using `rb_str_encode()` instead of `rb_funcall()`.
## Before
```
$ ruby bench_json_generate.rb
Warming up ----------------------------... -
- ## Before
```
$ ruby bench_json_generate.rb
Warming up --------------------------------------
json 25.000 i/100ms
Calculating -------------------------------------
json 250.478 (± 4.8%) i/s - ... - 10:54 AM Revision d9e50fcb (git): [flori/json] Pass args all #to_json in json/add/*.
- https://github.com/flori/json/commit/36a7ef6790
-
- https://github.com/flori/json/commit/167ada8da7
-
-
-
- To get rid of a bug of `onig_region_set` which takes `int`s
instead of `OnigPosition`s, set elements of `beg` and `end`
members directly, for the time being. -
- I was thinking something like?
```
VALUE
rb_fstring_lookup(char *ptr, rb_encoding *enc)
{
st_data_t fstring;
struct RString fake_str;
setup_fake_str(&fake_str, ptr, len, ENCINDEX_US_ASCII)
st_table *frozen_str... -
- Applied in changeset commit:git|d0ed935d5bf8c3fce9800742a36e44fb7f63dda4.
----------
Fix some DRb issues (#2552)
* Handle BasicObject in drb
Also fix a bug in rescue clause of any_to_s because sprintf
does not handle the %l modifier.
... -
- Applied in changeset commit:git|d0ed935d5bf8c3fce9800742a36e44fb7f63dda4.
----------
Fix some DRb issues (#2552)
* Handle BasicObject in drb
Also fix a bug in rescue clause of any_to_s because sprintf
does not handle the %l modifier.
... -
- Applied in changeset commit:git|d0ed935d5bf8c3fce9800742a36e44fb7f63dda4.
----------
Fix some DRb issues (#2552)
* Handle BasicObject in drb
Also fix a bug in rescue clause of any_to_s because sprintf
does not handle the %l modifier.
... -
- Applied in changeset commit:git|d0ed935d5bf8c3fce9800742a36e44fb7f63dda4.
----------
Fix some DRb issues (#2552)
* Handle BasicObject in drb
Also fix a bug in rescue clause of any_to_s because sprintf
does not handle the %l modifier.
... -
- * Handle BasicObject in drb
Also fix a bug in rescue clause of any_to_s because sprintf
does not handle the %l modifier.
Fixes [Bug #7833]
* Do not send a reply to the client if there is a connection error
This allows for normal TCP ... - 03:40 AM Revision 95c420c4 (git): Import StringScanner 1.0.3 (#2553)
-
- in active_units
Hoping to fix:
http://ci.rvm.jp/results/trunk-mjit@silicon-docker/2311375 -
02:02 AM Feature #16146: Array .difference allow custom comparison
- jonathanhefner (Jonathan Hefner) wrote:
> Dan0042 (Daniel DeLorme) wrote:
> ...
Well, that assumes that the block return values can be ordered. But it's easy to create cases where values can be compared for equality, but not ordered. E...
10/13/2019
-
- `if (unit->iseq)` might have referred to a freed unit. Therefore this
commit delays its free. -
- The crash reported here was definitely a bug, but it was fixed in Ruby 2.1. It still generates a SystemStackError. I think that behavior is reasonable. If you want a recursion depth check, use `Object#to_json`, not `JSON.dump`. `Objec...
-
-
- As tainting will be removed from Ruby 2.7, this can be closed.
-
- jxf (John Feminella) wrote:
> When collecting excess keyword arguments, Ruby's ArgumentError message doesn't count the `**kwargs` as possible arguments.
> ...
As keyword arguments will be separated from positional arguments in Ruby 3, ... -
-
-
- 05:05 PM Revision 673f3842 (git): * 2019-10-14 [ci skip]
-
-
- Now I'm not exactly sure why I needed to check `stop_worker_p` after
`mjit_copy_cache_from_main_thread` of `convert_unit_to_func`
in 4161674b2fbea6bdd01783ac5d3b39d88db22972.
If it's for avoiding deadlock under `in_gc` condition, we shou... -
-
-
-
-
-
-
-
-
01:34 PM Bug #15490: socket.rb - recurring segmentation faults
- I got a similar issue.
I uploaded a reproducible code and a crash report.
https://gist.github.com/abicky/1263fd5c7d39db257f663382970bc2b0
I hope they help.
-
12:48 AM Revision 6a1809e2 (git): Enhance doc for ENV.delete
-
- Its greated!!
Thanks jeremy :)
I will read pull request.
10/12/2019
-
- Fixing this first requires fixing #16242, which allows including a module that uses prepend and is refined. However, the fix for #16242 does not fix the example in this case, as this prepends the included module after the module is incl...
-
- This issue is specific to modules that are refined and use prepend. The reason it does not work:
1. Refining a module or class that prepends other modules places the refinements in the class itself and not the origin iclass.
2. Inc... - 03:54 PM Revision 6ee2fb50 (git): * 2019-10-13 [ci skip]
-
- Coverity Scan points out that all the return values of GLOB_ALLOC_N are
NULL-checked except this call. -
- Coverity Scan points out that ext/socket/unixsocket.c may pass -1 to
rb_update_max_fd. I'm unsure whether it can happen actually or not, but
it would be good for the function to reject a negative value. -
- Found by Coverity Scan
-
-
- If fmt is NULL, ptitle is uninitialized and used.
SETPROCTITLE(3bsd) says "If fmt is NULL, the process title is restored",
but looks like the feature is not implemented in missing/setproctitle.c.
At least the source code of ruby does not... -
- Personally I think I have wanted/needed this in the past. It has not been
that important to me to suggest it myself, though, but +1 on the name/API.
> (as nobody complained about it, or I can't find similar proposals), but
> ...
I t... -
- ```c
return rb_dir_s_empty_p(rb_cDir, rb_str_dup(dirp->path));
```
This checks a directory named the current `Dir` object opened, instead of the opened directory itself.
-
- I don't think it is a super-valuable addition (as nobody complained about it, or I can't find similar proposals), but seems logical to me:
```ruby
# Existed since 2.4
Dir.empty?('dirname') #=> true/false
File.empty?('filename') # =... -
-
-
- This macro is used here before defined in ruby.h.
-
08:39 AM Feature #15923: New independent string without memcpy
- I've implemented string bindings using growing ruby string. It was a bit tricky - I had to use `rb_protect`. I will leave here a link, so everyone can see an example. https://github.com/andrew-aladev/ruby-lzws/blob/master/ext/lzws_ext/st...
-
- Cited from mount(8):
```
strictatime
Always update the file access time when reading from a
file. Without this option the filesystem may default to a
less strict update mode, where some access time updates
... - 05:03 AM Revision 92df7d98 (git): Import CSV 3.1.2 (#2547)
-
- 03:07 AM Revision f6a666a1 (git): * 2019-10-12 [ci skip]
- 03:07 AM Revision 412cd567 (git): Import REXML 3.2.3 (#2548)
10/11/2019
-
05:26 PM Misc #16232: DevelopersMeeting20191017Japan
- * [Feature #13683] Add strict Enumerable#single
* Matz didn't like the `single` name but we have a proposal for `#only` -
- This appears to be fixed by commit:6f522455bf801acefcd2ade0b2e4a2fef3cb70a4.
-
- ioctl accepts int as request arguments on some platforms, but some
requests are more than INT_MAX, e.g., RNDGETENTCNT(0x80045200).
Passing (0x80045200 | (-1 << 32)) may work around the issue, but it may
not work on a platform where ioctl... -
- On Android, nl_langinfo() always returns UTF-8 even when LANG is C.
-
- On Android 28, LOG_PERROR is defined, but not implemented yet.
This change skips Syslog#log explicitly. -
- This is already closed.
"Third Party's Issue" is one of the close statuses. -
07:26 AM Bug #16133: 2.5 --> 2.6: backwards incompatible change in MalformedCSVError
- may close with `Won't resolve` probably, coz of this:
https://github.com/ruby/csv/issues/104 -
-
04:48 AM Revision ddfb306e (git): win32.c: Remove unused calls to StartSockets (#2312)
- NtSocketsInitialized behavior changed in e33b1690, requiring
a call to rb_w32_sysinit for starting Windows Sockets.
This commit removes NtSocketsInitialized entirely to avoid confusion.
Signed-off-by: Gabriel Nagy <gabriel.nagy@puppet.... -
02:34 AM Feature #15323: [PATCH] Proposal: Add Enumerable#filter_map
- Could this take argument as well? I'd be keen for something in the spirit of `Enumerable#grep` but where an (optional) pattern evaluates the result of the block, rather than each element of the array. If omitted, there's the default te...
-
02:20 AM Revision 7cc1cd3d (git): Module#define_method: Add UnboundMethod to expected classes
-
02:16 AM Revision 9c24ce55 (git): Reduce the minimum string buffer size from 127 to 63 bytes
-
-
12:33 AM Revision 87958520 (git): set real path to __FILE__ and __dir__ in Binding#irb
- When reading Binding#irb, the file of the calling source is reflected in __FILE__ and __dir__.