Activity
From 01/04/2023 to 01/10/2023
01/10/2023
-
07:12 PM Bug #19316: YJIT crash in 3.2.0
- Here is a reproducer for 3.1.3:
```ruby
def foo(_, a, b, c)
a & b & ~c
end
n = 2 ** 64
args = [0, -n, n, n-1]
GC.stress = true
p foo(0, -n, n, n-1)
p foo(0, -n, n, n-1)
p foo(0, -n, n, n-1)
__END__
$ ruby-3.1.3/bin/... -
- Applied in changeset commit:git|aeddc19340c7116d48fac3080553fbb823857d16.
----------
YJIT: Save PC and SP before calling leaf builtins (#7090)
Previously, we did not update `cfp->sp` before calling the C function of
ISEQs marked with `... -
03:29 AM Bug #19316 (Assigned): YJIT crash in 3.2.0
-
06:54 PM Revision 5bf7218b (git): Differentiate T_ARRAY and array subclasses (#7091)
- * Differentiate T_ARRAY and array subclasses
This commit teaches the YJIT context the difference between Arrays
(objects with type T_ARRAY and class rb_cArray) vs Array subclasses
(objects with type T_ARRAY but _not_ class rb_cArray). ... -
05:12 PM Feature #19325: YJIT: Windows support lacking.
- Sorry my tone seemed to be complaining - I appreciate all the hard work being done and seeing that #18439 is being looked at eases my mind. I will try to contribute with some tooling to help ease the pain since I do use windows at work ...
-
05:02 AM Feature #19325: YJIT: Windows support lacking.
- Sorry, not intended to change the tracker
-
- dsisnero (Dominic Sisneros) wrote:
> Also, windows compiler support has matured enough and vcpkg support has evolved enough that it seems it should be possible to finally get a ruby version without having to use msys2.
Well, you can ... -
03:31 AM Feature #19325: YJIT: Windows support lacking.
- The reason Windows being second class is not lack of interest but lack of contributors with extensive experience with (non WSL) Windows platform. Any contributors?
I understand your frustration, but complaining does not improve the situ... -
03:23 AM Feature #19325 (Assigned): YJIT: Windows support lacking.
-
- > With rust having first class windows support and threading support, is there a reason why yjit is not able to work on windows?
Whether the tool (rustc) used to write a (YJIT) compiler supports a platform and whether the compiler sup... -
- Previously, we did not update `cfp->sp` before calling the C function of
ISEQs marked with `Primitive.attr! "inline"` (leaf builtins). This
caused the GC to miss temporary values on the stack in case the function
allocates and triggers a... -
04:00 PM Revision 6a585dbd (git): YJIT: Fix a compilation warning with release build (#7092)
- warning: unused variable: `start_addr`
--> ../yjit/src/asm/mod.rs:359:39
|
359 | pub fn remove_comments(&mut self, start_addr: CodePtr, end_addr: CodePtr) {
| ^^^^^^^^^^ help: if this ... -
03:51 PM Feature #18190: Split `Random::Formatter` from securerandom
- To clarify, random/formatter is now a stdlib (not loaded by default).
`Random::Formatter` is defined in core but has few methods before `require 'random/formatter'`:
```
$ ruby -e 'puts Random::Formatter.instance_methods(false)'
ra... -
-
01:59 PM Revision 2861c8de (git): Remove ARY_SET_SHARED
- We don't need ARY_SET_SHARED since we already have rb_ary_set_shared.
-
- 12:18 PM Revision 97f8f2c4 (git): [ruby/reline] Add key binding for Delete
- https://github.com/ruby/reline/commit/603eacee22
-
-
09:58 AM Feature #19261: `Data#members` is not important
- > But Data randomly lacking some shorthand methods that exist for Struct would make such refactoring harder.
Yes, that was the only reason I preserved the method in `Data`. Don't recall using it myself, but don't see harm in its exis... -
01:25 AM Feature #19261: `Data#members` is not important
- k0kubun (Takashi Kokubun) wrote in #note-2:
> If we were to remove this from Data instances, I'd like Struct instances to not have that method either for consistency. Let's say you replace Struct.new with Data.define for something that'... -
09:35 AM Feature #18285: NoMethodError#message uses a lot of CPU/is really expensive to call
- maybe we could add some conditions when the object should be printed instead of the class for NoMethodError?
* if object overwrites `method_missing` and maybe `respond_to_missing` then print the object instead of the class
* if the o... -
- zverok (Victor Shepelev) wrote in #note-26:
> Say, in a complicated algorithm working with nested data structures, `undefined method transform_keys for object Array` is significantly worse than `undefined method transform_keys for [{id:... -
09:20 AM Bug #19005: Ruby interpreter compiled XCode 14 cannot build some native gems on macOS
- nobu (Nobuyoshi Nakada) wrote in #note-33:
> Adding `-no_fixup_chains -undefined dynamic_lookup` together will break old compilers.
> ...
Good point. I've updated https://github.com/ruby/ruby/pull/7086. -
-
- from https://github.com/rubygems/rubygems/commit/0635c1423db5d7c461d53bf0c3329bca75de7609
-
05:27 AM Bug #19266: URI::Generic should use URI::RFC3986_PARSER instead of URI::DEFAULT_PARSER
- The attached patch adds a failing test and a change that fixes it.
The rest of the test suite passes with this patch. -
- What's used for compiling YJIT itself, which was changed from a C compiler to `rustc`, wasn't a huge concern for supporting Windows. Given that @usa has an idea for the `mmap` part, the main challenge for supporting Windows would be ABI ...
-
- YJIT has been rewrote with rust in Ruby 3.2. Should we close this?
-
-
-
-
03:58 AM Revision 2e0159c5 (git): [rubygems/rubygems] Fix resolver edge case
- Let it deal with legacy gems with equivalent version and different
dependencies.
https://github.com/rubygems/rubygems/commit/b430babe97 -
- 02:20 AM Revision 97d52a8e (git): [rubygems/rubygems] Bump rb-sys
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.53 to 0.9.54.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.53...v0.9.54)
---
updated-depende... -
- This reverts commit 650a20a3e1205f47224a987676cdbad7d826d597.
Now that 3.2.0 is released, let's disable flaky tests. Koichi said he'll
rework Ractor implementation for this, and it has not been done yet. -
- With --enable-yjit, you see an annoying warning like this:
warning: Missing auto-load script at offset 0 in section .debug_gdb_scripts
of file /home/k0kubun/src/github.com/ruby/ruby/.ruby/miniruby.
Use `info auto-load python-scripts [RE... -
- Applied in changeset commit:git|72eb33066fa9e7dacb7470cd140b219abe37667e.
----------
Fix off-by-one error in rb_vm_each_stack_value
Applying the following patch to test/erb/test_erb.rb and running that
file will cause Ruby to crash on ... -
- Applying the following patch to test/erb/test_erb.rb and running that
file will cause Ruby to crash on my machine (macOS 13.1 on M1 Pro):
```
--- a/test/erb/test_erb.rb
+++ b/test/erb/test_erb.rb
@@ -7,6 +7,12 @@
class TestERB < Test::...
01/09/2023
-
- This would mean breaking code working on 3.0/3.1/3.2, of course that's not acceptable.
Adding `**` there is not a big deal and it makes a lot of sense once you understand keyword arguments are now separated from positional arguments. -
09:05 PM Feature #19328: Please bring back the use of Hash objects for keyword arguments
- jeremyevans0 (Jeremy Evans) wrote in #note-2:
>
> ...
Many developers are working on legacy systems that aren't immediately up to date with the latest version of ruby. To imply this is "established" across the entire community is misle... -
08:50 PM Feature #19328: Please bring back the use of Hash objects for keyword arguments
- Considering:
* That separating keyword and positional arguments was done for good reasons (as explained in the
"Why we're deprecating the automatic conversion" section of the page you linked to),
* That reverting the change would r... -
- The change in 3.0 (linked here https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/) no longer automatically converts Hash objects into keyword arguments. This takes Ruby away from wha...
-
- Updated the Backport field. Looking at the patch, we probably need to backport this to 3.1 as well (the same logic needs to be rewritten in C for https://github.com/ruby/ruby/blob/v3_1_0/yjit_codegen.c#L3638-L3661).
-
- Thank you for the report and for providing a reliable repro -- it makes diagnosing the problem that much easier!
We have a [fix](https://github.com/ruby/ruby/pull/7090) in the pipeline now. -
11:03 AM Bug #19316: YJIT crash in 3.2.0
- Looks like a SIGABRT, address 0x38. This isn't one I've seen yet.
-
- Warning: 'set logging on', an alias for the command 'set logging enabled', is deprecated.
Use 'set logging enabled on'. -
- Please file it to https://github.com/rubygems/rubygems
-
09:28 PM Bug #19329 (Third Party's Issue): "gem install" installs logs and other "noisy", non-reproducible files
- Hello, Ruby!
When building/installing C extensions via `gem install`, log files produced during the build get installed to the `GEM_VENDOR` location. This is undesirable because these files are not functional and they contain non-rep... -
- - [Bug #19289] RbConfig::CONFIG["STRIP"] should keep `rb_abi_version` and `rb_abi_version` should always be part of Ruby
- In dev meeting #18557 it was decided that we would keep `rb_abi_version` on both development and release (so ... -
- If we were to remove this from Data instances, I'd like Struct instances to not have that method either for consistency. Let's say you replace Struct.new with Data.define for something that's already immutable, I don't want that change t...
-
07:12 PM Revision 40bf8987 (git): Update yjit.md
- Add Alan Wu's keynote & Maxime's talk to the list of YJIT-related talks :)
- 06:43 PM Revision 93b2de82 (git): [rubygems/rubygems] Bump rb-sys in /test/rubygems/test_gem_ext_cargo_builder/custom_name
- Bumps [rb-sys](https://github.com/oxidize-rb/rb-sys) from 0.9.53 to 0.9.54.
- [Release notes](https://github.com/oxidize-rb/rb-sys/releases)
- [Commits](https://github.com/oxidize-rb/rb-sys/compare/v0.9.53...v0.9.54)
---
updated-depende... -
- Please backport commits [3be2acfafd3b3c6168e2266c7c6561d143d7ae5c](https://github.com/ruby/ruby/commit/3be2acfafd3b3c6168e2266c7c6561d143d7ae5c) and [9726736006b3f74635fd8af05814fe0908e2cf84](https://github.com/ruby/ruby/commit/972673600...
-
-
-
-
-
- The reference updating code for strings is not re-embedding strings
because the code is incorrectly wrapped inside of a
`if (STR_SHARED_P(obj))` clause. Shared strings can't be re-embedded
so this ends up being a no-op. This means that s... -
-
-
- With arguments, mkmf skips compilation check for the function as RHS.
https://github.com/ruby/zlib/commit/9ed9d6d36e -
- https://github.com/ruby/zlib/commit/fc89ff9ef0
-
09:39 AM Revision f6952a94 (git): [ruby/psych] Fix wrong package name of MSYS2/MINGW dependency
- There is no package called "libyaml-devel". "libyaml" is enough.
-
03:07 AM Feature #19324: Enumerator.product => Enumerable#product
- For `product`, one important issue not yet mentioned here is whether it's calculated on e.g. two or three separate arrays, where making the first of the arrays the receiver, or whether it's calculated on an array of arrays where the firs...
-
12:17 AM Feature #19324: Enumerator.product => Enumerable#product
- >[T]wo methods [...] do completely different things and differ by one letter, both being somewhat vague verbs
`produce` is (most of the time) a verb or (sometimes) a noun. `product` is no doubt a noun.
01/08/2023
-
11:14 PM Revision 41a947e7 (git): [ruby/uri] [DOC] Enhanced RDoc for URI
- (https://github.com/ruby/uri/pull/55)
https://github.com/ruby/uri/commit/89ab4f1407 -
07:31 PM Feature #19326 (Closed): Please add a better API for passing a Proc to a Ractor
- Example 1:
```ruby
class Worker
def initialize(&block)
@block = block
end
def run
Ractor.new(@block, &:call)
end
end
worker = Worker.new { 1 }
puts worker.run.take
```
Errors with:
```
<internal:racto... -
- I've attached a patch with the changes to remove the aforementioned method. Also, I run the test suite in `test_data.rb` to validate my changes but there was one test failure that I'm unable to explain. However, the test failure looks to...
-
- Ruby's support on windows has always been second class. With some of the recent decisions, windows support is falling even more behind. Recent developments in mjit and yjit that exclude windows are two glaring issues that should be cor...
-
- (https://github.com/ruby/uri/pull/53)
https://github.com/ruby/uri/commit/ce379e6125 -
- I know it might be too late after introducing a feature and releasing a version, but I find `Enumerator.product` quite confusing, and can't find any justification in #18685.
**Problem 1: It is `Array#product` but `Enumerator.product`*... -
-
- Oh, OK, I see where you are coming from (the formal correctness of correspondence to Unicode standard/known standard definitions), while I was operating in vague and informal terms "what the user might've meant".
I still don't know w... -
01:24 PM Feature #19317: Unicode ICU Full case mapping
- zverok (Victor Shepelev) wrote in #note-5:
> Also, I believe that having a formal language code in the API (instead of a small informal list of writing systems supported) creates a false expectation that every language specificity might... -
- @noraj I believe the important point here is that [there are many](https://en.wikipedia.org/wiki/Turkic_languages#Members) **turkic** languages, and as far as I understand, more than two of them use "dotless i".
At least Crimean Tata... -
- duerst (Martin Dürst) wrote in #note-3:
> Something like this was discussed. My recollection was that it was rejected because it was overkill for the case at hand, and there was no other functionality in core Ruby that needed it.
May... -
- Applied in changeset commit:git|1cdf8ab07b24ebd16e93621957196e8b1d67f2ba.
----------
[Bug #19323] Raise `RangeError` instead of integer overflow -
- https://github.com/ruby/ruby/pull/7087
-
- ```ruby
require 'rbconfig/sizeof'
char_bit = RbConfig::LIMITS["UCHAR_MAX"].bit_length
size_max = RbConfig::LIMITS["SIZE_MAX"]
size_bit_max = size_max * char_bit
1 << size_bit_max
```
The above code raises an "integer overflow" e... -
-
-
-
- Thanks, @mame, it is pretty educative and exactly the answer I was looking for in my first ("historical") question!
-
- https://bugs.ruby-lang.org/issues/19285
https://github.com/rubygems/rubygems/commit/1e22219ed4 -
- https://github.com/rubygems/rubygems/commit/a31f5d1a18
-
- Since RDoc does not parse string literals as documents, `eval` the
entire file instead of embedding in a here-document.
On the contrary, as `gem_original_require` alias is an implementation
detail but not for users, it should not be docu... -
- Adding `-no_fixup_chains -undefined dynamic_lookup` together will break old compilers.
`-no_fixup_chains` should be checked solely **before** `-undefined dynamic_lookup`, at least. -
07:01 AM Bug #19005 (Open): Ruby interpreter compiled XCode 14 cannot build some native gems on macOS
-
01/07/2023
-
- https://github.com/ruby/uri/commit/be8047028f
-
- Submitted https://github.com/ruby/ruby/pull/7086.
-
- A possible fix is to squelch this warning via `-no_fixup_chains`:
```diff
diff --git a/configure.ac b/configure.ac
index a2a0c1e387..d653a13bb8 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3104,7 +3104,7 @@ AS_IF([test "$rb_c... -
-
- Ok, I see this was reported in https://bugs.ruby-lang.org/issues/19082.
-
-
- I think this problem was "accidentally" fixed in Ruby 2.7.7 and 3.0.5, but it's not working in Ruby 3.1.3 and up due to a simple removal of a dollar sign (https://github.com/ruby/ruby/commit/667aa81219ca080c0a4b9f97d29bb3221bd08a33).
I... -
02:48 PM Bug #19321: BigDecimal multiplication giving different result since Ruby 3.1
- > The old result was incorrect. The new, correct result is due to a bug fix. I'm going to close this. If you can find a result that is incorrect in Ruby 3.1 or 3.2, please post it.
I see, makes sence. Thanks for the explanation
-
- JFI: it is https://github.com/ruby/bigdecimal/pull/180, which fixed https://github.com/ruby/bigdecimal/issues/70 and #13331.
-
- The old result was incorrect. The new, correct result is due to a bug fix. I'm going to close this. If you can find a result that is incorrect in Ruby 3.1 or 3.2, please post it.
-
- The newer result seems arithmetically correct.
-
- I have this math operation 120.to_d * 0.07 and I noticed that since upgrading to Ruby 3.1 I get different results. I would expect to get the same result as in previous versions.
```
rbenv local 3.0.3
➜ irb
require 'bigdecimal/util.r... -
- It might be interesting to limit the depth or maximum number of fields shown for inspect via some argument/fiber locals (so it'd work to some extent with custom `#inspect`)/etc.
But that should be a separate new proposal then. -
- zverok (Victor Shepelev) wrote in #note-26:
> Honestly, I would much rather prefer users to be advised "make sure your `#inspect` is efficient" than make everybody suffer.
That's not reasonable to ask. `#inspect` was never meant to b... -
01:23 PM Feature #18285: NoMethodError#message uses a lot of CPU/is really expensive to call
- > The vast majority of classes out there don't define a custom inspect. So Ruby should do something reasonable for these cases.
+1 My intention with my bug report was to call this out -- `inspect` can get really expensive, and you jus... -
- Spec fixed in https://github.com/ruby/ruby/compare/651a098ea1526b363e85fd8d3f30e9783f6c5de1...28cfc0c116b6c6e40bf3b391f026a51b3b208047, so only RangeError for when above the limit.
-
- CRuby actually can give NoMemoryError, RangeError but also ArgumentError (seems a bug:
```
$ ruby -e '1 << (2**67-1)'
-e:1:in `<<': integer overflow: 4611686018427387905 * 4 > 18446744073709551615 (ArgumentError)
``` -
- nobu (Nobuyoshi Nakada) wrote in #note-8:
> It is a test for the development branch and unrelated to users using released versions.
It might not be clear given the original bug report, but the behavior of NoMemoryError vs RangeError on ... -
- It is a test for the development branch and unrelated to users using released versions.
-
- * It seems a better exception class too than NoMemoryError.
-
- * The limit depends on the implementation and platform, it seems unavoidable.
* See https://bugs.ruby-lang.org/issues/18518#note-9 -
- Just answering to one part:
noraj (Alexandre ZANNI) wrote:
> ## language-sensitive case mapping
> ...
'turkic' was chosen because it includes both Turkish and Azeri languages (see https://en.wikipedia.org/wiki/Turkic_languages).... -
-
- > That shouldn't cost much compared to copying many bytes.
This proposal shows two use cases: text editor and NAT, which doesn't copy many bytes. -
09:24 AM Feature #19322: Support spawning "private" child processes
- Apologies if I wasn’t clear, but I definitely don’t intend for the proposed interface to be platform specific. It would make use of clone/pdfork if they were available, but the fallback implementation (either the “proxy everything throug...
-
- I'm not very positive to implement platform specific methods, and rather suggest to create a gem as the first step.
-
- I did think about something in that shape @nobu for unsupported systems, but I think there are two problems -
- SIGCHLD will still be received, which is undesirable on its own
- if a different thread is running `Process.waitpid2(-1)` co... -
- Already possible solution would be a daemon process:
```ruby
IO.popen("-", "r+") do |childio|
if childio
# In parent process
Process.wait(childio.pid)
# `Process.wait` no longer consume the returned status code.
... -
- ## Background
The traditional Unix process APIs (`fork` etc) are poorly isolated. If a library spawns a child process, this is not transparent to the program using the library. Any signal handler for `SIGCHLD` in the program will be c... - 08:47 AM Revision 651a098e (git): [ruby/did_you_mean] Keep the deprecated API for another year in case this could break 'bundle install'
- https://github.com/ruby/did_you_mean/commit/0f4b0806b7
-
- Ok, this is indeed a bug. While Ruby 2.7.7 and 3.0.5 work, Ruby 3.1.3 and up have reintroduced https://bugs.ruby-lang.org/issues/19005. See https://bugs.ruby-lang.org/issues/19005#note-25.
-
- Running the file with shebang has a few issues.
* shebang is an OS dependent feature. Many modern UNIX-like OSes
support it, but not all, e.g., Windows.
* `env` command may not be in `/usr/bin`.
* "ruby" command may not be "ruby", whe... -
- https://github.com/ruby/bigdecimal/commit/99db3c9754
-
01/06/2023
-
-
- This was discovered by @aardvark179.
The following spec in `spec/ruby/core/float/round_spec.rb` fails on CRuby:
```ruby
ruby_bug "", ""..."3.3" do
# These numbers are neighbouring floating point numbers round a
# precise... -
- * YJIT: Make iseq_get_location consistent with iseq.c
* YJIT: Call it "YJIT entry point"
Co-authored-by: Maxime Chevalier-Boisvert <[email protected]>
Co-authored-by: Maxime Chevalier-Boisvert <[email protected]> -
- * YJIT: Colorize outlined code differently
on --yjit-dump-disasm
* YJIT: Reduce the number of escape sequences -
- Fix PR: https://github.com/ruby/ruby/pull/7081
Applying the following patch to test/erb/test_erb.rb and running that file will cause Ruby to crash on my machine (macOS 13.1 on M1 Pro):
```diff
--- a/test/erb/test_erb.rb
+++ b/tes... -
- Applied in changeset commit:git|d8ef0a98c670449b20436947f5ebbd327ed5ab0d.
----------
[Bug #19319] Fix crash in rb_str_casemap
The following code crashes on my machine:
```
GC.stress = true
str = "testing testing testing"
puts str.ca... -
- Fix here: https://github.com/ruby/ruby/pull/7080
The following code crashes on my machine:
```ruby
GC.stress = true
str = "testing testing testing"
puts str.capitalize
```
I can repro this issue on Ruby 2.7.7, 3.0.5, 3.1... -
04:46 PM Revision 66bc6209 (git): Remove unused function `rb_shape_flags_mask`
-
04:37 PM Bug #18518: NoMemoryError + [FATAL] failed to allocate memory for twice 1 << large
- There's no practical reason to support left shift of greater than integer max, so I would support a fast check and RangeError. It would make more sense than just blowing up memory and raising NoMemoryError for something that should never...
-
- So on 32-bit platforms it already behaves as I would expect, from the log in https://bugs.ruby-lang.org/issues/19260?next_issue_id=19259&prev_issue_id=19261#note-1
```ruby
1 << (2**40) #=> RangeError (shift width too big)
```
I thi... -
- The following code crashes on my machine:
```
GC.stress = true
str = "testing testing testing"
puts str.capitalize
```
We need to ensure that the object `buffer_anchor` remains on the stack
so it does not get GC'd. -
-
- I think we can close this issue.
-
- With `git grep -P '\b3\.3\b'`, I found:
```
lib/did_you_mean.rb:116: # TODO: Remove on 3.3:
lib/did_you_mean.rb:135: # TODO: Remove on 3.3:
```
cc @yuki24
```
re.c:3851: rb_warn_deprecated_to_remove("3.3", "3rd argument... -
- All good now, thanks for creating this ticket.
-
- Going in the order of https://github.com/ruby/ruby/commit/a236661a62dc89173dcdd9e071365929db1201a7
* `Encoding#replicate has been removed FAILED` I'll remove it and adjust guard, it's #18949: https://github.com/ruby/ruby/pull/7079
* `do... -
03:34 PM Bug #19293: The new Time.new(String) API is nice... but we still need a stricter version of this
- > A trustworthy version of ISO8601 parser method perhaps with another name than .new that accepts strict ISO8601-ish String only
Can we improve `Time.iso8601`?
Alternatively we could introduce a method based on https://www.rfc-edit... -
-
- This is all done now, only https://github.com/ruby/ruby/pull/7079 left and I'll merge that when it passes CI.
Overall:
* We deprecated and removed `Encoding#replicate`
* We removed `get_actual_encoding()`
* We limited to 256 encodi... -
- @ko1 did https://github.com/ruby/ruby/pull/6935, great, thank you!
-
- As announced in [Case Mapping](https://docs.ruby-lang.org/en/master/case_mapping_rdoc.html#label-Default+Case+Mapping), Ruby support for Unicode case mapping is not complete yet.
Unicode supports in Ruby is pretty awesome, it works by... -
- * [Bug #18518] NoMemoryError + [FATAL] failed to allocate memory for twice 1 << large (eregon)
* I would like a decision on this ticket
* I propose to raise `RangeError (shift width too big)` if `shift width` is >= 2**31 (32-bit si... -
- EDIT: I remove #19315 for this meeting's agenda, let's discuss it at a later meeting.
-
11:19 AM Misc #19240: DevMeeting-2023-01-19
- * [Feature #19314] String#bytesplice should support partial copy
* Not only I but also kazuho-san wants this feature: https://twitter.com/kazuho/status/1611279616098070532
* Can the length be omitted in the destination? -
- * [Misc #16671] BASERUBY version policy
* How about my proposal?
-
02:35 PM Bug #19316 (Closed): YJIT crash in 3.2.0
- When I check out this commit from GitHub, https://github.com/jdashton/aoc2022-ruby/tree/5702dac483cd6e95f7be35bfebaf9d4a654796d8 , and run the following command, `RUBYOPT="-v --yjit" bin/rspec spec/aoc2022/puzzles/unstable_diffusion_spec...
-
02:33 PM Bug #8973: Allow to configure archlibdir for multiarch
- Actually, the real intention here is to get rid of the `${arch}` from the paths. The thing is that `--enable-multiarch` used to make it possible, because this is the implementation:
~~~
rubyarchprefix=${multiarch+'${archlibdir}/${RUBY_B... -
- nobu (Nobuyoshi Nakada) wrote in #note-9:
> @vo.x With your patch and `--with-multiarch --with-archlibdir='${libdir}'`, not only libruby.so but also all standard library extensions are placed under `${libdir}` without `${arch}`.
> ...
... -
- (https://github.com/ruby/uri/pull/50)
https://github.com/ruby/uri/commit/7ff4fb372b -
- @duerst Could you take a look at this? It's not fixed yet in 3.2.0.
-
- shugo (Shugo Maeda) wrote in #note-4:
> > * Do not use String and e.g. use an Array of byte values or a C extension
> ...
The typical approach is to flatten (or convert) the Rope to String before matching (whether the Rope is in Ruby o... -
- Eregon (Benoit Daloze) wrote in #note-5:
> Now that we have IO::Buffer and there is https://docs.ruby-lang.org/en/master/IO/Buffer.html#method-i-copy, why not use that?
So this does what you want I believe:
```ruby
x = "0123456789"... -
- Ah, something I missed though is that with lazy substrings, there would still need to be a copy of the bytes to "unshare" the string when writing to it.
That copy would also be needed if the string was shared before (e.g. with .dup), but... -
- naruse (Yui NARUSE) wrote in #note-3:
> But your proposal: Lazy substrings is not a solution because it also creates an object especially for small strings which is embedded in RVALUE.
Yes it creates a String instance reusing the sam... -
- I agree that this is a workaround and a VM should solve this as an optimization.
But your proposal: Lazy substrings is not a solution because it also creates an object especially for small strings which is embedded in RVALUE.
I agr... -
- I think this is too hard to read and parse for a human and 5 arguments seems way too much for a core method.
It feels like a full memcpy/arraycopy which I don't think in general is a good idea for String.
The implementation complexity ... -
- String#bytesplice should support partial copy without temporary String objects.
For example, given `x = "0123456789"`, either of the following replaces the contents of `x` with `"0167856789"`:
```ruby
x.bytesplice(2, 3, x, 6, 3)
... -
- Applied in changeset commit:git|cee5beab1d7bf6f99530957494ab9775696d42ce.
----------
[Bug #19312] Return end-of-input at `__END__` -
- https://github.com/ruby/ruby/pull/7077
Maybe old versions should use `END_OF_INPUT` instead of 0 and -1. -
- `SHARABLE_MIDDLE_SUBSTRING` was introduced circa 2014 in https://github.com/ruby/ruby/commit/a707ab4bc8a by @nobu.
@nobu maybe you have some insights to share on this topic? Is there a reason you remember why this flag was never enabl... -
- The documentation of RSTRING_PTR() doesn't specify it returns a \0-terminated `char*`, but it seems assumed in various places and it would likely be a security issue if that's not always \0-terminated.
So RSTRING_PTR() needs to realloc ... -
- CRuby should implement lazy substrings, i.e., "abcdef"[1..3] must not copy bytes.
Currently CRuby only reuse the char* if the substring is until the end of the buffer.
But it should also work wherever the substring starts and ends.
... -
-
- The command line arguments to `configure` are stored in `rbconfig.rb`.
Usually these are just useless but harmless after the installation,
however could affect unexpectedly when updating default gems. -
-
-
-
- What we often tend to write frequently are safe navigation operator and indented here-docs.
So I'll be happy it were 2.3 or later. -
- How about the Ruby version provided by the stable Ubuntu release?
* https://packages.ubuntu.com/search?keywords=ruby
* bionic (18.04LTS): 2.5.1, standard EOL date is 2023/04
* focal (20.04LTS): 2.7, standard EOL date is 2025/04
... -
08:53 AM Revision bdd35045 (git): Fix typos [ci skip]
-
- Useless history talk. I once asked matz why Kernel exists. If I remember correctly, matz said the following.
* In the beginning, there was a usage distinction of putting global function-like methods (exit, eval, etc.) in Kernel and me... - 07:02 AM Revision 1be669d0 (git): Update bundled gems list at 2023-01-06
-
- https://github.com/ruby/psych/commit/e07b16ad8b
-
- https://github.com/ruby/psych/commit/9a3816d903
-
-
- https://github.com/ruby/spec/pull/990 has been merged. I'll close this.
-
- Cf. https://github.com/ruby/ruby/pull/7069
-
- We should differentiate between set and get for megamorphic exits. This
patch fixes the megamorphic exit name in gen_setinstancevariable so that
we can tell the difference between megamorphic get / set sites -
12:53 AM Feature #18814: Ractor: add method to query incoming message queue size
- I heard from @ko1 in person that _he_ doesn't need this feature to implement his ractor pool. From what I understand he would have a single ruby-level Queue instance for all incoming messages and instead of pushing those messages to eac...
-
12:22 AM Bug #19262 (Closed): Segmentation fault on RubyVM::AbstractSyntaxTree.node_id_for_backtrace_location
- Applied in changeset commit:git|979dd02e2f0a70f3f30d47c6115780d8fac6147e.
----------
Check if the argument is Thread::Backtrace::Location object
[Bug #19262] -
- [Bug #19262]
01/05/2023
-
10:21 PM Bug #19275: Bundled gems extensions are not installed with 3.2.0 release tarball
- Thanks. The patch in https://bugs.ruby-lang.org/issues/19275 is literally the same as the one I posted here as a workaround, which I know works as expected.
I think this issue can be closed now, maybe as a duplicate of #19271. -
- We will fix this issue at https://github.com/ruby/ruby/pull/7066
-
- I could reproduce this with BASERUBY and fresh install with tarball.
`tool/outdate-bundled-gems.rb` will removing `debug.so` and `rbs_extension.so` while `make install`.
-
- Ah sorry, that is not correct. The output before `make install` (right after `make` with no target specified) should read:
```
rm -f ./.bundle/specifications/debug-1.7.1.gemspec
rm -f ./.bundle/specifications/rbs-2.8.2.gemspec
rm -... -
- This commit adds `"embedded":true` in ObjectSpace.dump for T_OBJECTs
that are embedded. -
- FWIW on JRuby:
```
$ ruby -v
jruby 9.4.1.0-SNAPSHOT (3.1.0) 2022-12-19 6416265092 OpenJDK 64-Bit Server VM 17.0.5+8 on 17.0.5+8 +jit [x86_64-linux]
$ jruby -e 'p(1 << (2**64))'
RangeError: bignum too big to convert into `long'
$ jruby -e... -
- This is still not fixed.
I think CRuby should check if RHS is bigger than 2**31 and if so raise an exception immediately instead of taking a lot of time and run into OOM:
https://github.com/ruby/ruby/commit/5df711844586312891bb466dbc72... -
-
- Fixes a compiler warning about the function unknown_directive:
pack.c:160:1: warning: function 'unknown_directive' could be declared with attribute 'noreturn' [-Wmissing-noreturn] -
-
- > The vast majority of classes out there don't define a custom inspect. So Ruby should do something reasonable for these cases.
That's true.
(I still maintain that it could/should be a good community practice to define better `#in... -
- > Note that in the example provided in the original issue
I just realized my response was confusing. To clarify I meant `ActionController::Base#inspect`. Which resolve to `Object#inspect`. Controllers simply are the root of a very lar... -
- > What if #inspect is very inefficient? In this case a) actually, yes, I believe that it is client's code responsibility
Note that in the example provided in the original issue, the slow `#inspect` is simply the default `Object#inspec... -
- @byroot I am not denying the problem exists or saying it shouldn't be handled (and I acknowledge my Rails remark was inappropriate).
I am just saying that the way of fixing it by replacing the object representation with class name bre... -
- > As far as I understand, the problem originates in Rails, which (as they do) doesn't try to follow good practices for #inspect (which is honestly frequently irritating)
This absolutely isn't specific to Rails. It can happen with any ... -
- I understand I am late to the party, but I am extremely concerned with how the discussion in this ticket went.
From my understanding:
1. There are many contexts, especially with designing, experimenting, and prototyping with Ruby, wh... -
- ```
$ make test-all TESTOPTS="-j8"
Run options:
--seed=25187
"--ruby=./miniruby -I./lib -I. -I.ext/common ./tool/runruby.rb --extout=.ext -- --disable-gems"
--excludes-dir=./test/excludes
--name=!/memory_leak/
-j8
... -
- I have extra files locally which triggers this and that's why the CI doesn't see it.
Anything with `__END__` dies:
```
$ ruby -e 'RubyVM::AbstractSyntaxTree.parse("p 1\n__END__\nfoobar", keep_tokens: true)'
<internal:ast>:59: [BUG... -
- ```
$ make test-all TESTOPTS="test/ruby/test_ast.rb"
...
# Running tests:
<internal:ast>:76: [BUG] parser_token2id: unknown token -1
ruby 3.3.0dev (2023-01-05T14:24:32Z old 358f325bf8) [x86_64-linux]
-- Control frame informatio... -
-
- I flagged it for backporting so it will be available on Ruby 3.2.1 :)
-
- Applied in changeset commit:git|273dca3aed7989120d57f80c789733d4bc870ffe.
----------
Fix undefined behavior in shape.c
Under strict aliasing, writing to the memory location of a different
type is not allowed and will result in undefine... -
- peterzhu2118 (Peter Zhu) wrote in #note-20:
> @vo.x Do you need this backported to Ruby 3.2 or is it ok to keep it only on the master branch (i.e. it will be part of Ruby 3.3)?
Unfortunately, I have no idea how likely is to hit this ... -
- @vo.x You might want to consider packaging with `-fno-strict-aliasing`.
I suspect the perf loss should be minimal if noticeable at all and it would
mitigate these type of strict aliasing violations, yielding an artifact more likely to ... -
- @vo.x Do you need this backported to Ruby 3.2 or is it ok to keep it only on the master branch (i.e. it will be part of Ruby 3.3)?
-
- Thank you @alanwu for looking into this and @vo.x for confirming the fix. I've also confirmed that this fix does indeed make the tests pass. I've opened a PR here: https://github.com/ruby/ruby/pull/7067
-
- alanwu (Alan Wu) wrote in #note-17:
> Maybe try this patch to confirm?
The patch helps to mitigate the issue. -
- Under strict aliasing, writing to the memory location of a different
type is not allowed and will result in undefined behavior. This was
happening in shape.c due to `rb_id_table_lookup` writing to the memory
location of `VALUE *` that wa... -
- Done in https://github.com/ruby/ruby/commit/03dd37775afb40eef392ae2920d728235af302c8, also needed changes in specs: https://github.com/ruby/spec/commit/9d69b95a7bbac3d89e7218a98bd50ecf173d9c6f
- 06:06 PM Revision 54950a78 (git): * remove trailing spaces, append newline at EOF. [ci skip]
-
-
-
- * [Bug #19150]
-
-
01:06 PM Revision f9148d15 (git): [ruby/irb] Group command test cases with class
- (https://github.com/ruby/irb/pull/491)
Currently, IRB has 35 test cases for 10 non-debugging commands, with the
rest 10 commands untested. So in the long-term, it could have around 70
test cases for all existing commands.
With this num... -
- hsbt (Hiroshi SHIBATA) wrote in #note-5:
> How test `bundler` in Fedora builder?
We don't test Bundler unfortunately (in any automated way). But the Bundler test suite is not executed as part of Ruby `make check`
> ...
If this was... -
-
- Oh, sorry. I'm working to upgrade redis server for bugs.ruby-lang.org. Now, It works.
-
- Just FTR, I have received the same error also after closing this ticket ...
-
- Ups, sorry for the duplicates. Redmine is throwing following error when the ticket is created:
~~~
Internal error
An error occurred on the page you were trying to access.
If you continue to experience problems please contact your... -
- CentOS 9 / RHEL 9 requires prohibits SHA1 for signing purposes, therefore these specs fail:
~~~
1)
OpenSSL::X509::Name.verify returns true for valid certificate ERROR
OpenSSL::X509::CertificateError: invalid digest
/builddir/build... -
- Just FYI. Here is an ad-hoc workaround for ruby 3.2.0 tarball.
```
$ tar xf ruby-3.2.0.tar.gz
$ cd ruby-3.2.0
$ rm tool/outdate-bundled-gems.rb
$ touch tool/outdate-bundled-gems.rb
$ ./configure --prefix=/path/to/ruby/installed/
... -
- Applied in changeset commit:git|4959e01932cf6c4d3e5e90d3e0b4fa780f754fa6.
----------
common.mk: Do not invoke outdate-bundled-gems by default
If baseruby is available (and its version is different from one being
built) when compiling r... -
- I have created a PR to work around this issue. https://github.com/ruby/ruby/pull/7066
-
- We have two issues.
* Installation failure of C extension provided by bundled gems.
* https://bugs.ruby-lang.org/issues/19275
* Ignore messages will be displayed despite installation successfully.
* I didn't confirm yet.
-
- ```
Ignoring debug-1.6.3 because its extensions are not built. Try: gem pristine debug --version 1.6.3
Ignoring rbs-2.7.0 because its extensions are not built. Try: gem pristine rbs --version 2.7.0
```
@k0kubun debug-1.6.3 and rbs-... -
- I couldn't reproduce this with fresh install of Ruby 3.2.0 from tarball.
If you use `GEM_HOME` and share it with each Ruby versions or builds, you may encounter this (It's known issue). After I removed `GEM_HOME` environmental variabl... -
- If baseruby is available (and its version is different from one being
built) when compiling ruby, tool/outdate-bundled-gems.rb (which is
invoked by `make install`) wrongly deletes debug.so and rbs_extension.so
in .bundle/extension/*.
Th... -
-
- CentOS 9 / RHEL 9 requires prohibits SHA1 for signing purposes, therefore these specs fail:
~~~
1)
OpenSSL::X509::Name.verify returns true for valid certificate ERROR
OpenSSL::X509::CertificateError: invalid digest
/builddir/build... -
-
- CentOS 9 / RHEL 9 requires prohibits SHA1 for signing purposes, therefore these specs fail:
~~~
1)
OpenSSL::X509::Name.verify returns true for valid certificate ERROR
OpenSSL::X509::CertificateError: invalid digest
/builddir/build... -
-
- CentOS 9 / RHEL 9 requires prohibits SHA1 for signing purposes, therefore these specs fail:
~~~
1)
OpenSSL::X509::Name.verify returns true for valid certificate ERROR
OpenSSL::X509::CertificateError: invalid digest
/builddir/build... -
- @deivid @nagachika did backport the installer toolchain like `rbinstall.rb` into `ruby_3_1` branch for releasing Ruby 3.1.3. Maybe, this issue contained its time.
-
-
- CentOS 9 / RHEL 9 requires prohibits SHA1 for signing purposes, therefore these specs fail:
~~~
1)
OpenSSL::X509::Name.verify returns true for valid certificate ERROR
OpenSSL::X509::CertificateError: invalid digest
/builddir/build... -
- > Fixing this and **describing public and private methods correctly** would not be confusing.
This is option (4) of my initial list, I believe.
Option (2) — the easiest and the least desirable of them — is just to dump everything ... -
- @zverok The `Kernel` page is entirely broken anyway from its first sentence:
> The `Kernel` module is included by class `Object`, so its methods are available in every Ruby object.
the latter half of which is not true since the introdu... -
- * [Feature #18285] NoMethodError#message uses a lot of CPU/is really expensive to call (mame)
* I have created a PR to change the message of NoMethodError based on @akr 's proposal. https://github.com/ruby/ruby/pull/6950
* Why don'... -
- * [Bug #19260] ruby/spec is failed with Ruby 3.3
* <del>How handles these issues?</del>
* https://bugs.ruby-lang.org/issues/13671 is still open status
* https://bugs.ruby-lang.org/issues/18518#note-8 @nobu ? -
- Both of `$(srcdir)/revision.h` and `revision.h` exist because they are
the same file when in-place build.
01/04/2023
-
- Thank you so much for the fix :-)
-
- Applied in changeset commit:git|837ef8911c638c3e2bdb6af710de7c1fac7b5f90.
----------
Fix crash in TracePoint c_call for removed method
trace_arg->id is the ID of the original method of an aliased method. If
the original method is remov... -
- Thank you for reporting this bug. I have a fix in this PR: https://github.com/ruby/ruby/pull/7064
-
-
- Looking at `rb_shape_traverse_from_new_root()`, it seems like it's triggering UB
in a way that also failed with LTO in the past. Maybe try this patch to confirm?
```patch
diff --git a/shape.c b/shape.c
index 7580003412..8e75f4a270 ... -
- Thanks to @mtasaka and @vo.x for debugging this further! Using this information, I think this is a bug in GCC. Here's what I did:
- I can confirm that I can reproduce this bug on Ubuntu 22.04 and GCC 11.3.0 with:
```
CFLAGS='-O2... -
- jeremyevans0 (Jeremy Evans) wrote in #note-3:
> austin (Austin Ziegler) wrote in #note-2:
> ...
You made a point. Creating non-destructive variant of any destructive method seems unnecessary since there is dup that is pretty easy to us... -
- https://github.com/ruby/openssl/commit/0d4cd8b9ca
-
- trace_arg->id is the ID of the original method of an aliased method. If
the original method is removed, then the lookup will fail. We should use
trace_arg->called_id instead, which is the ID of the aliased method.
Fixes [Bug #19305] -
- (https://github.com/ruby/uri/pull/49)
https://github.com/ruby/uri/commit/02dfc79366 -
- One way nowadays to do this is to use the `Primitive.foo` system and define the method in Ruby files.
Another would be to add a new `rb_define_method` variant to which the parameters can be passed.
That could then be used for all core m... -
04:48 PM Feature #8088: Method#parameters (and friends) should provide useful information about core methods
- I've been bitten by this same issue (see #19301) in Ruby 3.2.0 with the introduction of the new [Data](https://www.alchemists.io/articles/ruby_data) class. At the time of opening that issue, I didn't fully realize how *untruthful* `Metho...
-
- Benoit, thanks. I found what I was looking for in #8088. I've added a comment to that issue referring back to this issue.
Victor, thanks for discussion on this and learning just how far down this C-based implementation problem really ... -
- bkuhlmann (Brooke Kuhlmann) wrote in #note-7:
> Would it be better if I move this discussion to a new issue where the focus is on asking if `Method#parameters` could properly answer the argument signature for C objects? Maybe that's too... -
- Here it is:
```
rm -f ./.bundle/specifications/debug-1.7.1.gemspec
rm -f ./.bundle/specifications/rbs-2.8.2.gemspec
rm -rf ./.bundle/gems/debug-1.7.1/
rm -rf ./.bundle/gems/rbs-2.8.2/
rm -f .bundle/specifications/debug-1.7.1.gems... -
- Could you show the output from `ruby tool/outdate-bundled-gems.rb -n .`?
-
- ObjectSpace.trace_object_allocations_start could crash since it adds a
TracePoint for when objects are freed. However, TracePoint could crash
since it modifies st tables while inside the GC that is trying to free
the object. This could c... -
- We should allow malloc during GC when GC has been explicitly disabled
since garbage_collect_with_gvl won't do anything if GC has been disabled. -
01:42 PM Bug #19269: Constant lookup and #instance_eval
- @zverok
Thank you for clarification 🙇. -
- This is expected because constant lookup is lexicial, i.e., it's only changed by `module/class` keywords, and by eval'ed strings.
-
01:17 PM Bug #19115: RubyGems fails to detect OpenSSL in --with-static-linked-ext builds
- I built Ruby 3.1.2 that we use in our product with this patch applied, and it worked on our systems. Would be nice to see it backported.
- 01:13 PM Revision 799d805e (git): [rubygems/rubygems] Raise invalid option when bundle open --path is called without a value
- https://github.com/rubygems/rubygems/commit/c242311158
- 01:13 PM Revision 87c17a14 (git): [rubygems/rubygems] Enhance bundle open with --path option
- https://github.com/rubygems/rubygems/commit/3bf8e59304
-
- @sawa
> Can you expand on why option 2 would be super-confusing? I think that option is the best.
Because those are two different categories of methods (as this and the previous ticket discuss in detail), and having them in one mixe... -
- Can you expand on why option 2 would be super-confusing? I think that option is the best.
-
- Is the option 3 like this?
https://github.com/ruby/rdoc/pull/961 -
- @alanwu By `attached_object_class` you mean `a.class` so `A`?
Constant lookup behaves lexically, here the scopes around method `c` are `A` and top-level/Object.
So here it looks in `A`, then `Object`, then ancestors of A. It never lo... -
- * [Feature #19179] Support parsing SCM_CRED(ENTIALS) messages from ancillary messages
* Various UNIX-y OS's support getting the (e)uid, (e)gid, and pid from unix sockets - some with a socket option, some with an ancillary message
* R... -
- (https://github.com/ruby/irb/pull/489)
* Remove unnecessary Binding#source_location check
`Binding#source_location` was added in 2.6, which is the minimum supported
version now. So this check is no longer necessary.
* Remove unused IR... -
- How test `bundler` in Fedora builder? It needs to download RSpec from rubygems.org since Ruby 2.5.
-
- Note: email integration was successfully at https://bugs.ruby-lang.org/issues/16986#note-64. I'm not sure why it works.
-
07:02 AM Feature #19306 (Open): Expand zlib interface
- Introduce some extra methods like `window_size`, `level` (compression/decompression), enhance `inspect` and various other quality of life improvements.
- 06:32 AM Revision e25c173c (git): [ruby/reline] correct Win32API capitalization for JRuby
- JRuby 9.4.0.0 introduced a change in case sensitivity in require statements,
meaning that an inclusion of `win32api` loaded Win32API.rb. With this change,
the require statement needs to be updated to the correct capitalization of the
fil... -
-
- Thanks @k0kubun and @vo.x.
I created the backport request at https://github.com/ruby/ruby/pull/7061 - 01:02 AM Revision b8673f8b (git): Bump ruby/setup-ruby from 1.128.0 to 1.133.0
- Bumps [ruby/setup-ruby](https://github.com/ruby/setup-ruby) from 1.128.0 to 1.133.0.
- [Release notes](https://github.com/ruby/setup-ruby/releases)
- [Commits](https://github.com/ruby/setup-ruby/compare/4b2d1d631efa087f8896c15a0c6023dc2f...