fix(file sharing): various improvements

- non-english locale support
- restart notice
- advanced sharing settings shortcut
- enable sharing wizard

Author: he3als

src/playbook/Configuration/atlas/services.yml

@@ -26,6 +26,7 @@ actions:
     command: '.\AtlasModules\Scripts\ScriptWrappers\DisableFileSharing.ps1 -Silent'
     exeDir: true
     wait: true
+    runas: currentUserElevated
 
   - !writeStatus: {status: 'Disabling Location'}
   - !cmd:

src/playbook/Configuration/tweaks.yml

@@ -167,6 +167,7 @@ actions:
   - !task: {path: 'tweaks\qol\disable-screen-capture-hotkey.yml', option: 'remove-snipping-tool'}
   - !task: {path: 'tweaks\qol\disable-dynamic-lighting.yml'}
   - !task: {path: 'tweaks\qol\disable-auto-app-archival.yml'}
+  - !task: {path: 'tweaks\qol\add-sharing-settings-shortcut.yml'}
 
   # -------------------------------------------------------------------------- #
   #  qol\appearance                                                            #
@@ -202,7 +203,6 @@ actions:
   - !task: {path: 'tweaks\qol\explorer\disable-check-boxes.yml'}
   - !task: {path: 'tweaks\qol\explorer\disable-folders-this-pc.yml'}
   - !task: {path: 'tweaks\qol\explorer\disable-network-navigation-pane.yml'}
-  - !task: {path: 'tweaks\qol\explorer\disable-sharing-wizard.yml'}
   - !task: {path: 'tweaks\qol\explorer\full-context-on-more-than-15-items.yml'}
   - !task: {path: 'tweaks\qol\explorer\hide-frequently-used-items.yml'}
   - !task: {path: 'tweaks\qol\explorer\import-power-plan.yml'}

src/playbook/Configuration/tweaks/qol/add-sharing-settings-shortcut.yml

@@ -0,0 +1,12 @@
+---
+title: Add Network Sharing Shortcut
+description: Adds a network sharing settings shortcut to the Atlas 'File Sharing' folder for QoL
+actions:
+  - !powerShell:
+    command: |
+      .\AtlasModules\initPowerShell.ps1
+      New-Shortcut -Source 'control.exe' `
+        -Destination """$([Environment]::GetFolderPath('Windows'))\AtlasDesktop\3. General Configuration\File Sharing\Sharing Settings.lnk""" `
+        -Arguments '/name Microsoft.NetworkAndSharingCenter /page Advanced'
+    exeDir: true
+    wait: true

src/playbook/Configuration/tweaks/qol/explorer/disable-sharing-wizard.yml

@@ -25,7 +25,9 @@ foreach ($profile in $profiles) {
 }
 
 # Disable network discovery firewall rules
-Get-NetFirewallRule | Where-Object { 
+Get-NetFirewallRule | Where-Object {
+    # File and Printer Sharing, Network Discovery
+    ($_.Group -eq "@FirewallAPI.dll,-28502" -or $_.Group -eq "@FirewallAPI.dll,-32752") -or
     ($_.DisplayGroup -eq "File and Printer Sharing" -or $_.DisplayGroup -eq "Network Discovery") -and
     $_.Profile -like "*Private*"
 } | Disable-NetFirewallRule
@@ -35,7 +37,7 @@ reg import "$fileSharingConfigPath\Give Access To Menu\Disable Give Access To Me
 
 if ($Silent) { exit }
 
-Write-Host "`nCompleted!" -ForegroundColor Green
-Write-Host "Press any key to exit... " -NoNewLine
-$Host.UI.RawUI.ReadKey('NoEcho,IncludeKeyDown') | Out-Null
+Write-Host "`nCompleted! " -ForegroundColor Green -NoNewLine
+Write-Host "You'll need to restart to apply the changes." -ForegroundColor Yellow
+$null = Read-Host "Press Enter to exit..."
 exit

src/playbook/Executables/AtlasModules/Scripts/ScriptWrappers/DisableFileSharing.ps1

@@ -25,8 +25,10 @@ if ($LASTEXITCODE -eq 1) {
         Set-ItemProperty -Path $profile.PSPath -Name "Category" -Value 1 | Out-Null
     }
 
-    # Enable network discovery firewall rules
-    Get-NetFirewallRule | Where-Object { 
+    # Disable network discovery firewall rules
+    Get-NetFirewallRule | Where-Object {
+        # File and Printer Sharing, Network Discovery
+        ($_.Group -eq "@FirewallAPI.dll,-28502" -or $_.Group -eq "@FirewallAPI.dll,-32752") -or
         ($_.DisplayGroup -eq "File and Printer Sharing" -or $_.DisplayGroup -eq "Network Discovery") -and
         $_.Profile -like "*Private*"
     } | Enable-NetFirewallRule
@@ -46,7 +48,7 @@ if ($LASTEXITCODE -eq 1) {
     reg import "$([Environment]::GetFolderPath('Windows'))\AtlasDesktop\3. General Configuration\File Sharing\Give Access To Menu\Enable Give Access To Menu.reg" | Out-Null
 }
 
-Write-Host "`nCompleted!" -ForegroundColor Green
-Write-Host "Press any key to exit... " -NoNewLine
-$Host.UI.RawUI.ReadKey('NoEcho,IncludeKeyDown') | Out-Null
+Write-Host "`nCompleted! " -ForegroundColor Green -NoNewLine
+Write-Host "You'll need to restart to apply the changes." -ForegroundColor Yellow
+$null = Read-Host "Press Enter to exit..."
 exit