BUG/MEDIUM: stconn: Don't block sends if there is a pending shutdown

capflam · capflam · commit b50a471adbb4 · 2023-09-01T14:18:26.000+02:00
For the same reason than the previous patch, we must not block the sends when there is a pending shutdown. In other words, we must consider the sends are allowed when there is a pending shutdown. This patch must slowly be backported as far as 2.2. It should partially fix issue haproxy#2249.
diff --git a/include/haproxy/sc_strm.h b/include/haproxy/sc_strm.h
@@ -351,6 +351,8 @@ static inline int sc_is_send_allowed(const struct stconn *sc)
 {
 	if (sc->flags & SC_FL_SHUT_DONE)
 		return 0;
+	if (sc->flags & SC_FL_SHUT_WANTED)
+		return 1;
 
 	return !sc_ep_test(sc, SE_FL_WAIT_DATA | SE_FL_WONT_CONSUME);
 }

Original file line number	Diff line number	Diff line change
`@@ -351,6 +351,8 @@ static inline int sc_is_send_allowed(const struct stconn *sc)`
`351`	`351`	`{`
`352`	`352`	`if (sc->flags & SC_FL_SHUT_DONE)`
`353`	`353`	`return 0;`
	`354`	`+ if (sc->flags & SC_FL_SHUT_WANTED)`
	`355`	`+ return 1;`
`354`	`356`
`355`	`357`	`return !sc_ep_test(sc, SE_FL_WAIT_DATA \| SE_FL_WONT_CONSUME);`
`356`	`358`	`}`